From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web09.6757.1581689836051436018 for ; Fri, 14 Feb 2020 06:17:16 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=R0H+oT9V; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581689835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jPoN1MiMDAJcEPcbihAvcKmNjlRz/gEE2rmmClXpo6M=; b=R0H+oT9VT4VTMTNSHaOczLBmj003P3wFjwB9Kg2Ig0JickIkpaNzlLZ21U1Xcg9DQqnQ/r a0ae4EOb8XDkuuUM7ydhmnaLKmBDDx2DpW4+sZhwI5NUUM4pSPR8umCU4pDkYwFD8+mfLv HqUoCgZOGJFK1hX+p8XV3zQYEo2Re/M= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-297-DzXxBxvfP6WhWsllQtPHQQ-1; Fri, 14 Feb 2020 09:17:11 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DE0D8107B27E; Fri, 14 Feb 2020 14:17:09 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-153.ams2.redhat.com [10.36.116.153]) by smtp.corp.redhat.com (Postfix) with ESMTP id BDC1A60BF1; Fri, 14 Feb 2020 14:17:05 +0000 (UTC) Subject: Re: [edk2-devel] [RFC PATCH 1/1] OvmfPkg: add 'initrd' shell command to expose Linux initrd via device path To: "Ni, Ray" , "devel@edk2.groups.io" , Ard Biesheuvel Cc: "leif@nuviainc.com" , "philmd@redhat.com" , "Gao, Zhichao" References: <20200211180304.21669-1-ard.biesheuvel@arm.com> <734D49CCEBEEF84792F5B80ED585239D5C434F30@SHSMSX104.ccr.corp.intel.com> <071f3dac-9518-9452-fbaf-3de4a48f8e25@redhat.com> <734D49CCEBEEF84792F5B80ED585239D5C43B65F@SHSMSX104.ccr.corp.intel.com> From: "Laszlo Ersek" Message-ID: <3036ae47-af76-b82a-6123-890f185ee02e@redhat.com> Date: Fri, 14 Feb 2020 15:17:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C43B65F@SHSMSX104.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: DzXxBxvfP6WhWsllQtPHQQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/14/20 01:55, Ni, Ray wrote: >=20 >=20 >> -----Original Message----- >> From: Laszlo Ersek >> Sent: Friday, February 14, 2020 7:15 AM >> To: Ni, Ray ; devel@edk2.groups.io; Ard Biesheuvel >> >> Cc: leif@nuviainc.com; philmd@redhat.com; Gao, Zhichao >> >> Subject: Re: [edk2-devel] [RFC PATCH 1/1] OvmfPkg: add 'initrd' shell >> command to expose Linux initrd via device path >> >> On 02/12/20 15:21, Ni, Ray wrote: >>>> (3) However: I think this should be added as a Dynamic Command instead= . >>>> I'm basing this on the message of commit 0961002352e9 ("ShellPkg/tftp: >>>> Convert from NULL class library to Dynamic Command", 2017-11-28), >> which >>>> is the first commit in edk2 ever to introduce a Dynamic Command. >>>> >>>> And the commit message there says: >>>> >>>> The guideline is: >>>> 1. Only use NULL class library for Shell spec defined commands. >>>> 2. New commands can be provided as not only a standalone applicati= on >>>> but also a dynamic command. So it can be used either as an >>>> internal command, but also as a standalone application. >>>> >>>> I'm not asking for the command to be usable as a separate application, >>>> but I think we might want to follow the first guideline. >>>> >>>> (I've checked the UEFI Shell 2.2 spec. While it talks about dynamic >>>> commands, it does not seem to spell out guideline#1. So I think it's >>>> rather an edk2-specific guideline than a standard one. Nonetheless we >>>> might want to adhere to it.) >>> >>> Laszlo, thanks for the comments=F0=9F=98=8A. >>> I didn't remember that I said these guideline publicly. >>> The reason behind that is we can have the same shell binary everywhere >>> and new non-spec commands can be added through dynamic command >> without >>> impacting the shell binary. >> >> Thanks for the explanation -- this means that the NULL class lib >> approach is good for OvmfPkg after all. I'm putting the remaining parts >> of this patch back on my review queue (it will take a while). >=20 > Please don't misunderstand my points. OK. From your response, I thought that the guidelines you captured in the commit message in question were only for internal shell builds. > I still prefer to use dynamic commands > for all non-spec defined shell internal commands. > Sorry for the confusion caused by my previous mail. It's OK, I understand better now. So I guess I'll de-queue the review of the rest of this patch once again, and wait for the next version (with the dynamic command implementation). Thank you! Laszlo