From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 247E3740045 for ; Tue, 19 Mar 2024 08:53:32 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=NDp+S9jVGqlkybpNfZd/9E8c/DBkjcFR/Ib+H4ZVesI=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20240206; t=1710838411; v=1; b=TTYJtGsg4NKmGGH53sZAG76lbM+rLcvS1iwsDflZyv3l9gbV4CG5Ch/puHK3XwEc5bFMjQXN HbTGs8GD/AJseGwKx9yPSxI54q3f5V/utueMbtoW9lIsYrQntLDjW+6dBaW47VCXU57kq1n6/iA xXUxcmdP5xiJvOZZt3miq2Ktox5Yi27ANcxetuzWBa83zkpkUinA1v/QnjpcSbvv81J3wC45YGZ ijRLT1BBoFv5B0ttAqq2O1zm8Pfym3tnssPlzJwq1Ot/gPZtxB3GBDP58EeijwX6dfZDBg/iuVY glvK4cqKShz9Gp5GEWdzWePD36969LJrNBgWKylf/i7aw== X-Received: by 127.0.0.2 with SMTP id DeayYY7687511xt1sTV9TZeZ; Tue, 19 Mar 2024 01:53:31 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mx.groups.io with SMTP id smtpd.web11.10304.1710838410910412142 for ; Tue, 19 Mar 2024 01:53:31 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,11017"; a="23150163" X-IronPort-AV: E=Sophos;i="6.07,136,1708416000"; d="scan'208";a="23150163" X-Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2024 01:53:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,136,1708416000"; d="scan'208";a="18455651" X-Received: from babiosdev005.gar.corp.intel.com ([10.223.9.180]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2024 01:53:29 -0700 From: "Nayana Patel" To: devel@edk2.groups.io Cc: bhavana.s@intel.com, tabassum.yasmin@intel.com, Nayana Patel Subject: [edk2-devel] [PATCH] REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4647 Date: Tue, 19 Mar 2024 14:23:07 +0530 Message-Id: <303c9d1771d145f0eef982cf979835316bc8fc96.1710838372.git.nayana.patel@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 19 Mar 2024 01:53:31 -0700 Reply-To: devel@edk2.groups.io,nayana.patel@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: eqk51gdWiUGKL1dfbeAFapWmx7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=TTYJtGsg; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Clear out the variable SmmCommunicateVerifyPassword which contains password before goto Exit. To avoid vulnerability. Signed-off-by: Nayana Patel --- .../UserAuthenticationDxeSmm/UserAuthenticationSmm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm/UserAuthenticationSmm.c b/Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm/UserAuthenticationSmm.c index 98f40c1812..ba01d599e0 100644 --- a/Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm/UserAuthenticationSmm.c +++ b/Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm/UserAuthenticationSmm.c @@ -555,6 +555,7 @@ SmmPasswordHandler ( if (PasswordLen == sizeof(SmmCommunicateVerifyPassword.Password)) { DEBUG ((DEBUG_ERROR, "SmmPasswordHandler: Password invalid!\n")); Status = EFI_INVALID_PARAMETER; + ZeroMem (&SmmCommunicateVerifyPassword, sizeof (SmmCommunicateVerifyPassword)); goto EXIT; } if (!IsPasswordVerified (UserGuid, SmmCommunicateVerifyPassword.Password, PasswordLen + 1)) { @@ -565,6 +566,7 @@ SmmPasswordHandler ( } else { Status = EFI_SECURITY_VIOLATION; } + ZeroMem (&SmmCommunicateVerifyPassword, sizeof (SmmCommunicateVerifyPassword)); goto EXIT; } mPasswordVerified = TRUE; -- 2.39.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116881): https://edk2.groups.io/g/devel/message/116881 Mute This Topic: https://groups.io/mt/105020521/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-