From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [edk2-devel] [PATCH v1 09/10] DynamicTablesPkg: Deprecate Crs specific methods in AmlLib To: PierreGondois ,devel@edk2.groups.io From: "Sami Mujawar" X-Originating-Location: Great Shelford, England, GB (217.140.106.53) X-Originating-Platform: Windows Firefox 92 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Wed, 22 Sep 2021 08:56:43 -0700 References: <20210623110525.6171-10-Pierre.Gondois@arm.com> In-Reply-To: <20210623110525.6171-10-Pierre.Gondois@arm.com> Message-ID: <30544.1632326203009941536@groups.io> Content-Type: multipart/alternative; boundary="obLeZBsOjOXy1uynfUju" --obLeZBsOjOXy1uynfUju Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Pierre, Thank you for this patch. On Wed, Jun 23, 2021 at 04:05 AM, PierreGondois wrote: >=20 > - Create aliases having of the 'Crs' function prototypes. These > aliases are available when DISABLE_NEW_DEPRECATED_INTERFACES > is not defined. They will be deprecated in a near future. Is it possible to list the deprecated APIs in the commit message, please? Other than that this patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar --obLeZBsOjOXy1uynfUju Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Pierre,

Thank you for this patch.

On Wed, Jun 23, = 2021 at 04:05 AM, PierreGondois wrote:
- Create aliases having of the 'Crs' function prototypes. These=
aliases are available when DISABLE_NEW_DEPRECATED_INTERFACES
is = not defined. They will be deprecated in a near future.
Is it possible to list the deprecated APIs in the commit message, please?
Other than that this patch looks good to me.

Reviewed-= by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar --obLeZBsOjOXy1uynfUju--