From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F098721C8EFB5 for ; Mon, 14 Jan 2019 21:55:40 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jan 2019 21:55:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,480,1539673200"; d="scan'208";a="311882343" Received: from shzintpr03.sh.intel.com (HELO [10.253.24.32]) ([10.239.4.100]) by fmsmga005.fm.intel.com with ESMTP; 14 Jan 2019 21:55:39 -0800 To: "Wang, Jian J" , "edk2-devel@lists.01.org" Cc: "Wu, Hao A" , star.zeng@intel.com References: <1547479196-40248-1-git-send-email-star.zeng@intel.com> <1547479196-40248-6-git-send-email-star.zeng@intel.com> From: "Zeng, Star" Message-ID: <308358cf-205d-8389-58e4-accdc712becd@intel.com> Date: Tue, 15 Jan 2019 13:55:08 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Subject: Re: [PATCH V2 05/15] MdeModulePkg: Add PcdEmuVariableNvModeEnable in dec X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jan 2019 05:55:41 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 2019/1/15 13:05, Wang, Jian J wrote: > Hi Star, > > >> -----Original Message----- >> From: Zeng, Star >> Sent: Monday, January 14, 2019 11:20 PM >> To: edk2-devel@lists.01.org >> Cc: Zeng, Star ; Wang, Jian J ; >> Wu, Hao A >> Subject: [PATCH V2 05/15] MdeModulePkg: Add PcdEmuVariableNvModeEnable >> in dec >> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 >> Merge EmuVariable and Real variable driver. >> >> Add PcdEmuVariableNvModeEnable (support both static and >> dynamic) to indicate if Variable driver will enable >> emulated variable NV mode. >> >> This patch prepares for adding emulated variable NV mode >> support in VariableRuntimeDxe. >> >> Cc: Jian J Wang >> Cc: Hao Wu >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Star Zeng >> Reviewed-by: Laszlo Ersek >> --- >> MdeModulePkg/MdeModulePkg.dec | 10 ++++++++-- >> MdeModulePkg/MdeModulePkg.uni | 10 ++++++++-- >> 2 files changed, 16 insertions(+), 4 deletions(-) >> >> diff --git a/MdeModulePkg/MdeModulePkg.dec >> b/MdeModulePkg/MdeModulePkg.dec >> index 217ede1f7163..8fbc0af61365 100644 >> --- a/MdeModulePkg/MdeModulePkg.dec >> +++ b/MdeModulePkg/MdeModulePkg.dec >> @@ -3,7 +3,7 @@ >> # It also provides the definitions(including PPIs/PROTOCOLs/GUIDs and library >> classes) >> # and libraries instances, which are used for those modules. >> # >> -# Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.
>> +# Copyright (c) 2007 - 2019, Intel Corporation. All rights reserved.
>> # Copyright (c) 2016, Linaro Ltd. All rights reserved.
>> # (C) Copyright 2016 Hewlett Packard Enterprise Development LP
>> # Copyright (c) 2017, AMD Incorporated. All rights reserved.
>> @@ -1586,7 +1586,13 @@ [PcdsFixedAtBuild, PcdsPatchableInModule, >> PcdsDynamic, PcdsDynamicEx] >> # @Prompt 64-bit Base address of flash FTW working block range. >> >> gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingBase64|0x0 >> |UINT64|0x80000010 >> >> - ## This PCD defines a reserved memory range for the EMU Variable driver's NV >> Variable Store. >> + ## Indicates if Variable driver will enable emulated variable NV >> mode.

>> + # TRUE - An EMU variable NV storage will be allocated or reserved for NV >> variables.
>> + # FALSE - No EMU variable NV storage will be allocated or reserved for NV >> variables.
>> + # @Prompt EMU variable NV mode enable. >> + >> gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvModeEnable|FALSE|BO >> OLEAN|0x01100001 >> + >> + ## This PCD defines a reserved memory range for EMU variable NV storage. >> # The range is valid if non-zero. The memory range size must be >> PcdVariableStoreSize. >> # @Prompt Reserved memory range for EMU variable NV storage. >> > > The description is a little bit confuse to me. The value of this PCD is actually the > base address of reserved memory range, but not the range (size). A complete > memory range includes both base address and its size. But this PCD contains > only base address information. Maybe something like below would be better > (just for example): > > ---------------------- > This PCD defines the base address of reserved memory range for EMU variable > NV storage. A non-ZERO value indicates a valid range reserved with size given by > PcdVariableStoreSize. > > @Prompt Base of reserved memory range for EMU variable NV storage. > ---------------------- > > If you agree, please update the uni help string below as well. In fact, it is not related to this task directly. But I agree we can make the description to be more clear, I can handle it in a new separated patch. Thanks, Star > >> gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvStoreReserved|0|UINT6 >> 4|0x40000008 >> diff --git a/MdeModulePkg/MdeModulePkg.uni >> b/MdeModulePkg/MdeModulePkg.uni >> index 35af744d89be..9c413a98f65d 100644 >> --- a/MdeModulePkg/MdeModulePkg.uni >> +++ b/MdeModulePkg/MdeModulePkg.uni >> @@ -4,7 +4,7 @@ >> // It also provides the definitions(including PPIs/PROTOCOLs/GUIDs and library >> classes) >> // and libraries instances, which are used for those modules. >> // >> -// Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.
>> +// Copyright (c) 2007 - 2019, Intel Corporation. All rights reserved.
>> // >> // This program and the accompanying materials are licensed and made >> available under >> // the terms and conditions of the BSD License that accompanies this >> distribution. >> @@ -389,9 +389,15 @@ >> >> #string >> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdFlashNvStorageFtwWorkingBase6 >> 4_HELP #language en-US "64-bit Base address of the FTW working block range >> in flash device. If PcdFlashNvStorageFtwWorkingSize is larger than one block >> size, this value should be block size aligned." >> >> +#string >> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdEmuVariableNvModeEnable_PRO >> MPT #language en-US "EMU variable NV mode enable" >> + >> +#string >> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdEmuVariableNvModeEnable_HELP >> #language en-US "Indicates if Variable driver will enable emulated variable NV >> mode.

" >> + "TRUE - An EMU variable NV >> storage will be allocated or reserved for NV variables.
" >> + "FALSE - No EMU variable NV >> storage will be allocated or reserved for NV variables.
" >> + >> #string >> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdEmuVariableNvStoreReserved_PR >> OMPT #language en-US "Reserved memory range for EMU variable NV storage" >> >> -#string >> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdEmuVariableNvStoreReserved_HE >> LP #language en-US "This PCD defines a reserved memory range for the EMU >> Variable driver's NV Variable Store. The range is valid if non-zero. The memory >> range size must be PcdVariableStoreSize." >> +#string >> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdEmuVariableNvStoreReserved_HE >> LP #language en-US "This PCD defines a reserved memory range for EMU >> variable NV storage. The range is valid if non-zero. The memory range size must >> be PcdVariableStoreSize." >> >> #string >> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdHelloWorldPrintTimes_PROMPT >> #language en-US "HelloWorld print times" >> >> -- >> 2.7.0.windows.1