public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liming Gao" <liming.gao@intel.com>
To: "Hsu, Lan-chinX" <lan-chinx.hsu@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Feng, Bob C" <bob.c.feng@intel.com>
Subject: Re: [PATCH] BaseTools:Fix tools_def.txt contains hard-coded path to mtoc
Date: Wed, 15 Jan 2020 15:24:58 +0000	[thread overview]
Message-ID: <3087b9413cf6480c8f02657b4ca3dcd3@intel.com> (raw)
In-Reply-To: <20200115104219.530-1-lan-chinx.hsu@intel.com>

Hi, 
  DSYMUTIL path can be changed together.

Thanks
Liming
> -----Original Message-----
> From: Hsu, Lan-chinX <lan-chinx.hsu@intel.com>
> Sent: Wednesday, January 15, 2020 6:42 PM
> To: devel@edk2.groups.io
> Cc: Hsu, Lan-chinX <lan-chinx.hsu@intel.com>; Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>
> Subject: [PATCH] BaseTools:Fix tools_def.txt contains hard-coded path to mtoc
> 
> BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2030
> 
> Change MTOC PATH to reference $PATH to find mtoc.
> 
> The Patch is going to fix this issue
> 
> Signed-off-by: Lan-chinX Hsu <lan-chinx.hsu@intel.com>
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Bob Feng <bob.c.feng@intel.com>
> ---
>  BaseTools/Conf/tools_def.template | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
> index feee2bbf16..39b8c2e7df 100755
> --- a/BaseTools/Conf/tools_def.template
> +++ b/BaseTools/Conf/tools_def.template
> @@ -2853,7 +2853,7 @@ NOOPT_CLANGPDB_X64_DLINK2_FLAGS     =
>  *_XCODE5_*_ASLPP_PATH    = clang
> 
>  *_XCODE5_*_ASLDLINK_PATH = ld
> 
>  *_XCODE5_*_DSYMUTIL_PATH = /usr/bin/dsymutil
> 
> -*_XCODE5_*_MTOC_PATH     = /usr/local/bin/mtoc
> 
> +*_XCODE5_*_MTOC_PATH     = mtoc
> 
>  *_XCODE5_*_DEPS_FLAGS    = DEF(GCC_DEPS_FLAGS)
> 
> 
> 
>  ##################
> 
> --
> 2.25.0.windows.1


  reply	other threads:[~2020-01-15 15:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-15 10:42 [PATCH] BaseTools:Fix tools_def.txt contains hard-coded path to mtoc Lan-chinX Hsu
2020-01-15 15:24 ` Liming Gao [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-01-15 10:39 Lan-chinX Hsu
2020-01-15 10:15 Lan-chinX Hsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3087b9413cf6480c8f02657b4ca3dcd3@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox