[PATCH v2 1/1] pip: bump antlr4-python3-runtime from 4.7.1 to 4.11.1

[PATCH v2 1/1] pip: bump antlr4-python3-runtime from 4.7.1 to 4.11.1

[Michael Kubacki]

From: Michael Kubacki <michael.kubacki@microsoft.com>

Bumps [antlr4-python3-runtime](http://www.antlr.org)
from 4.7.1 to 4.11.1.

Original automated dependabot PR:
https://github.com/tianocore/edk2/pull/3672

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Co-authored-by: dependabot[bot] <support@github.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 pip-requirements.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pip-requirements.txt b/pip-requirements.txt
index be8c7a1c37e6..597cb674c573 100644
--- a/pip-requirements.txt
+++ b/pip-requirements.txt
@@ -15,4 +15,4 @@
 edk2-pytool-library==0.12.1
 edk2-pytool-extensions~=0.20.0
 edk2-basetools==0.1.39
-antlr4-python3-runtime==4.7.1
+antlr4-python3-runtime==4.11.1
-- 
2.28.0.windows.1

Re: [PATCH v2 1/1] pip: bump antlr4-python3-runtime from 4.7.1 to 4.11.1

[Michael D Kinney]

Hi Michael,

Dependabot did not pick up the change list between those two versions.

I think this is a link to the release notes that contains the change
list from 4.7.1.to 4.11.1.

    https://github.com/antlr/antlr4/releases

This update pulls in 5 years of changes.  That is a large leap.

I recommend this be added to the commit message and for the reviewers
to review the change list to make sure there are not changes that 
might impact edk2 repo use of this component.

I am looking at the edk2 sources and I only see 2 python tools using
antlr.  These are ecc and eot.  I recommend the BaseTools maintainers
verify that the functionality of these tools are not impacted by
this update.

Thanks,

Mike



> -----Original Message-----
> From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
> Sent: Tuesday, November 29, 2022 6:02 AM
> To: devel@edk2.groups.io
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>
> Subject: [PATCH v2 1/1] pip: bump antlr4-python3-runtime from 4.7.1 to 4.11.1
> 
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> Bumps [antlr4-python3-runtime](http://www.antlr.org)
> from 4.7.1 to 4.11.1.
> 
> Original automated dependabot PR:
> https://github.com/tianocore/edk2/pull/3672
> 
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Co-authored-by: dependabot[bot] <support@github.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>  pip-requirements.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/pip-requirements.txt b/pip-requirements.txt
> index be8c7a1c37e6..597cb674c573 100644
> --- a/pip-requirements.txt
> +++ b/pip-requirements.txt
> @@ -15,4 +15,4 @@
>  edk2-pytool-library==0.12.1
>  edk2-pytool-extensions~=0.20.0
>  edk2-basetools==0.1.39
> -antlr4-python3-runtime==4.7.1
> +antlr4-python3-runtime==4.11.1
> --
> 2.28.0.windows.1

Re: [edk2-devel] [PATCH v2 1/1] pip: bump antlr4-python3-runtime from 4.7.1 to 4.11.1

[Michael Kubacki]

Sure. Dependabot was added to find these old dependencies and keep the 
project on more current releases in the future.

Bob and Christine, I filed the following BZ to track your feedback:
https://bugzilla.tianocore.org/show_bug.cgi?id=4174

If you approve the changes, please go ahead and send your R-b on the 
list so I can capture that.

Thanks,
Michael


On 11/29/2022 10:37 AM, Michael D Kinney wrote:
> Hi Michael,
> 
> Dependabot did not pick up the change list between those two versions.
> 
> I think this is a link to the release notes that contains the change
> list from 4.7.1.to 4.11.1.
> 
>      https://github.com/antlr/antlr4/releases
> 
> This update pulls in 5 years of changes.  That is a large leap.
> 
> I recommend this be added to the commit message and for the reviewers
> to review the change list to make sure there are not changes that
> might impact edk2 repo use of this component.
> 
> I am looking at the edk2 sources and I only see 2 python tools using
> antlr.  These are ecc and eot.  I recommend the BaseTools maintainers
> verify that the functionality of these tools are not impacted by
> this update.
> 
> Thanks,
> 
> Mike
> 
> 
> 
>> -----Original Message-----
>> From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
>> Sent: Tuesday, November 29, 2022 6:02 AM
>> To: devel@edk2.groups.io
>> Cc: Sean Brogan <sean.brogan@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
>> <gaoliming@byosoft.com.cn>
>> Subject: [PATCH v2 1/1] pip: bump antlr4-python3-runtime from 4.7.1 to 4.11.1
>>
>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>
>> Bumps [antlr4-python3-runtime](http://www.antlr.org)
>> from 4.7.1 to 4.11.1.
>>
>> Original automated dependabot PR:
>> https://github.com/tianocore/edk2/pull/3672
>>
>> Cc: Sean Brogan <sean.brogan@microsoft.com>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>> Co-authored-by: dependabot[bot] <support@github.com>
>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>> ---
>>   pip-requirements.txt | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/pip-requirements.txt b/pip-requirements.txt
>> index be8c7a1c37e6..597cb674c573 100644
>> --- a/pip-requirements.txt
>> +++ b/pip-requirements.txt
>> @@ -15,4 +15,4 @@
>>   edk2-pytool-library==0.12.1
>>   edk2-pytool-extensions~=0.20.0
>>   edk2-basetools==0.1.39
>> -antlr4-python3-runtime==4.7.1
>> +antlr4-python3-runtime==4.11.1
>> --
>> 2.28.0.windows.1
> 
> 
> 
> 
> 
> 

Re: [edk2-devel] [PATCH v2 1/1] pip: bump antlr4-python3-runtime from 4.7.1 to 4.11.1

[Michael Kubacki]

Updated patch with antlr4 release info in commit message here:
https://edk2.groups.io/g/devel/message/96686

Thanks,
Michael

On 11/29/2022 11:37 AM, Michael Kubacki wrote:
> Sure. Dependabot was added to find these old dependencies and keep the 
> project on more current releases in the future.
> 
> Bob and Christine, I filed the following BZ to track your feedback:
> https://bugzilla.tianocore.org/show_bug.cgi?id=4174
> 
> If you approve the changes, please go ahead and send your R-b on the 
> list so I can capture that.
> 
> Thanks,
> Michael
> 
> 
> On 11/29/2022 10:37 AM, Michael D Kinney wrote:
>> Hi Michael,
>>
>> Dependabot did not pick up the change list between those two versions.
>>
>> I think this is a link to the release notes that contains the change
>> list from 4.7.1.to 4.11.1.
>>
>>      https://github.com/antlr/antlr4/releases
>>
>> This update pulls in 5 years of changes.  That is a large leap.
>>
>> I recommend this be added to the commit message and for the reviewers
>> to review the change list to make sure there are not changes that
>> might impact edk2 repo use of this component.
>>
>> I am looking at the edk2 sources and I only see 2 python tools using
>> antlr.  These are ecc and eot.  I recommend the BaseTools maintainers
>> verify that the functionality of these tools are not impacted by
>> this update.
>>
>> Thanks,
>>
>> Mike
>>
>>
>>
>>> -----Original Message-----
>>> From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
>>> Sent: Tuesday, November 29, 2022 6:02 AM
>>> To: devel@edk2.groups.io
>>> Cc: Sean Brogan <sean.brogan@microsoft.com>; Kinney, Michael D 
>>> <michael.d.kinney@intel.com>; Gao, Liming
>>> <gaoliming@byosoft.com.cn>
>>> Subject: [PATCH v2 1/1] pip: bump antlr4-python3-runtime from 4.7.1 
>>> to 4.11.1
>>>
>>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>>
>>> Bumps [antlr4-python3-runtime](http://www.antlr.org)
>>> from 4.7.1 to 4.11.1.
>>>
>>> Original automated dependabot PR:
>>> https://github.com/tianocore/edk2/pull/3672
>>>
>>> Cc: Sean Brogan <sean.brogan@microsoft.com>
>>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>>> Co-authored-by: dependabot[bot] <support@github.com>
>>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>>> ---
>>>   pip-requirements.txt | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/pip-requirements.txt b/pip-requirements.txt
>>> index be8c7a1c37e6..597cb674c573 100644
>>> --- a/pip-requirements.txt
>>> +++ b/pip-requirements.txt
>>> @@ -15,4 +15,4 @@
>>>   edk2-pytool-library==0.12.1
>>>   edk2-pytool-extensions~=0.20.0
>>>   edk2-basetools==0.1.39
>>> -antlr4-python3-runtime==4.7.1
>>> +antlr4-python3-runtime==4.11.1
>>> -- 
>>> 2.28.0.windows.1
>>
>>
>>
>> 
>>
>>