[edk2-platforms/devel-MinPlatform][PATCH v1 1/1] MinPlatformPkg: Include Tcg2Smm ACPI table RAW section

[edk2-platforms/devel-MinPlatform][PATCH v1 1/1] MinPlatformPkg: Include Tcg2Smm ACPI table RAW section

[Kubacki, Michael A]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1684

Updates the INF statement for Tcg2Smm to include a RuleOverride so
the Tpm.asl ACPI table is included as a RAW section in the FFS for
Tcg2Smm.

This allows Tcg2Smm to find the section during boot and publish the
ACPI table.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
---
 Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf b/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf
index ccb083a0a6..2171fe12e5 100644
--- a/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf
+++ b/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf
@@ -1,7 +1,7 @@
 ## @file
 #  FDF file of Platform.
 #
-# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
 #
 # This program and the accompanying materials are licensed and made available under
 # the terms and conditions of the BSD License which accompanies this distribution.
@@ -20,6 +20,6 @@ INF  SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDxe.i
 !if gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable == TRUE
 INF  SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.inf
 INF  SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf
-INF  SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf
+INF  RuleOverride = DRIVER_ACPITABLE SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf
 INF  SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDxe.inf
 !endif
-- 
2.16.2.windows.1

Re: [edk2-platforms/devel-MinPlatform][PATCH v1 1/1] MinPlatformPkg: Include Tcg2Smm ACPI table RAW section

[Chiu, Chasel]

Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

> -----Original Message-----
> From: Kubacki, Michael A
> Sent: Friday, April 5, 2019 2:48 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>;
> Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Ni, Ray
> <ray.ni@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: [edk2-platforms/devel-MinPlatform][PATCH v1 1/1] MinPlatformPkg:
> Include Tcg2Smm ACPI table RAW section
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1684
> 
> Updates the INF statement for Tcg2Smm to include a RuleOverride so the Tpm.asl
> ACPI table is included as a RAW section in the FFS for Tcg2Smm.
> 
> This allows Tcg2Smm to find the section during boot and publish the ACPI table.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
> ---
>  Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf | 4
> ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git
> a/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf
> b/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf
> index ccb083a0a6..2171fe12e5 100644
> --- a/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf
> +++ b/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.
> +++ fdf
> @@ -1,7 +1,7 @@
>  ## @file
>  #  FDF file of Platform.
>  #
> -# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2017 - 2019, Intel Corporation. All rights
> +reserved.<BR>
>  #
>  # This program and the accompanying materials are licensed and made available
> under  # the terms and conditions of the BSD License which accompanies this
> distribution.
> @@ -20,6 +20,6 @@ INF
> SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigD
> xe.i
>  !if gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable == TRUE  INF
> SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.inf
>  INF  SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf
> -INF  SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf
> +INF  RuleOverride = DRIVER_ACPITABLE
> +SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf
>  INF  SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDxe.inf
>  !endif
> --
> 2.16.2.windows.1

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 1/1] MinPlatformPkg: Include Tcg2Smm ACPI table RAW section

[chasel.chiu]

[-- Attachment #1: Type: text/plain, Size: 52 bytes --]

Reviewed-by: Chasel Chiu < chasel.chiu@intel.com >

[-- Attachment #2: Type: text/html, Size: 218 bytes --]

Re: [edk2-platforms/devel-MinPlatform][PATCH v1 1/1] MinPlatformPkg: Include Tcg2Smm ACPI table RAW section

[Chiu, Chasel]

Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

> -----Original Message-----
> From: Kubacki, Michael A
> Sent: Friday, April 5, 2019 2:48 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>;
> Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Ni, Ray
> <ray.ni@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: [edk2-platforms/devel-MinPlatform][PATCH v1 1/1] MinPlatformPkg:
> Include Tcg2Smm ACPI table RAW section
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1684
> 
> Updates the INF statement for Tcg2Smm to include a RuleOverride so the Tpm.asl
> ACPI table is included as a RAW section in the FFS for Tcg2Smm.
> 
> This allows Tcg2Smm to find the section during boot and publish the ACPI table.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
> ---
>  Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf | 4
> ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git
> a/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf
> b/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf
> index ccb083a0a6..2171fe12e5 100644
> --- a/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf
> +++ b/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.
> +++ fdf
> @@ -1,7 +1,7 @@
>  ## @file
>  #  FDF file of Platform.
>  #
> -# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2017 - 2019, Intel Corporation. All rights
> +reserved.<BR>
>  #
>  # This program and the accompanying materials are licensed and made available
> under  # the terms and conditions of the BSD License which accompanies this
> distribution.
> @@ -20,6 +20,6 @@ INF
> SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigD
> xe.i
>  !if gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable == TRUE  INF
> SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.inf
>  INF  SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf
> -INF  SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf
> +INF  RuleOverride = DRIVER_ACPITABLE
> +SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf
>  INF  SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDxe.inf
>  !endif
> --
> 2.16.2.windows.1