public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, rebecca@nuviainc.com,
	Sean Brogan <spbrogan@outlook.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>,
	Bret Barkelew <Bret.Barkelew@microsoft.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [EXTERNAL] Re: [edk2-devel] Ecc style errors when running EDK2 CI locally without specifying a target (NO-TARGET)
Date: Thu, 1 Oct 2020 13:43:47 +0200	[thread overview]
Message-ID: <309c37cc-1f5e-4909-d9eb-19ea114282e3@redhat.com> (raw)
In-Reply-To: <2b285a3e-c665-e203-3ac3-c006dd017f2b@nuviainc.com>

On 10/01/20 04:25, Rebecca Cran wrote:
> Ah, thanks. I made a wrong assumption about how it works. So I can get
> it to fail faster by running "stuart_ci_build -c .pytool/CISettings.py
> TOOL_CHAIN_TAG=GCC5 -t NO-TARGET" - i.e. running NO-TARGET without also
> running DEBUG,RELEASE,NOOPT too.
> 
> 
> It turns out that because of the repo I'm running it against, where I
> haven't kept `master` up-to-date, it thinks almost all the files have
> changed - and so it runs Ecc against code that hasn't really changed for
> a long time.
> 
> "INFO - Cmd to run is: git diff --name-status HEAD origin/master"
> 
> 
> So, now I've updated my repo's `master`, it both runs much faster, and
> succeeds.

Right; a few days ago I also had to look up the "origin/master"
references in ".pytool/Plugin/EccCheck/EccCheck.py" to understand how it
restricts the warnings to "new" code. I have a dedicated VM for running
CI locally, so whenever I push a topic branch to that, I just have to
push my most recently fetched master branch reference to the VM as well.

Thanks!
Laszlo

> 
> A weekly build which runs Ecc over all the code and compiles a report of
> issues might be nice.
> 
> 


      reply	other threads:[~2020-10-01 11:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30 21:59 Ecc style errors when running EDK2 CI locally without specifying a target (NO-TARGET) Rebecca Cran
2020-10-01  0:59 ` [edk2-devel] " Sean
2020-10-01  2:25   ` [EXTERNAL] " Rebecca Cran
2020-10-01 11:43     ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=309c37cc-1f5e-4909-d9eb-19ea114282e3@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox