From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web10.10474.1601552638752545221 for ; Thu, 01 Oct 2020 04:43:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=hE82imGd; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601552637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EWmvN4yBOgmkLT4g6A8M2qihDump83NlT9Aoq51E6tk=; b=hE82imGdtVialF9ra1IVNX9pdWOh+GX8B7m6OD2MGCsbgsb/mRvNgPm4ISsB4sAHyrvmTL WyCQDK099Rwa5EwYvLvTBdl1tGwc1rwumoRipHgRZXhsom498IWFw3A5pGwQjj0xfQqCeg hvMdVXM3badOUPNC9tKuLp/EOjaHCLA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-289-mz1fF8i5NmSlWd3Yzmo5AQ-1; Thu, 01 Oct 2020 07:43:54 -0400 X-MC-Unique: mz1fF8i5NmSlWd3Yzmo5AQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CD0AA427C6; Thu, 1 Oct 2020 11:43:51 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-110.ams2.redhat.com [10.36.113.110]) by smtp.corp.redhat.com (Postfix) with ESMTP id E5E8155776; Thu, 1 Oct 2020 11:43:48 +0000 (UTC) Subject: Re: [EXTERNAL] Re: [edk2-devel] Ecc style errors when running EDK2 CI locally without specifying a target (NO-TARGET) To: devel@edk2.groups.io, rebecca@nuviainc.com, Sean Brogan Cc: Sean Brogan , Bret Barkelew , Liming Gao , Michael D Kinney References: <0b04d303-655f-7f4e-88b6-d63268fe234f@nuviainc.com> <2b285a3e-c665-e203-3ac3-c006dd017f2b@nuviainc.com> From: "Laszlo Ersek" Message-ID: <309c37cc-1f5e-4909-d9eb-19ea114282e3@redhat.com> Date: Thu, 1 Oct 2020 13:43:47 +0200 MIME-Version: 1.0 In-Reply-To: <2b285a3e-c665-e203-3ac3-c006dd017f2b@nuviainc.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/01/20 04:25, Rebecca Cran wrote: > Ah, thanks. I made a wrong assumption about how it works. So I can get > it to fail faster by running "stuart_ci_build -c .pytool/CISettings.py > TOOL_CHAIN_TAG=GCC5 -t NO-TARGET" - i.e. running NO-TARGET without also > running DEBUG,RELEASE,NOOPT too. > > > It turns out that because of the repo I'm running it against, where I > haven't kept `master` up-to-date, it thinks almost all the files have > changed - and so it runs Ecc against code that hasn't really changed for > a long time. > > "INFO - Cmd to run is: git diff --name-status HEAD origin/master" > > > So, now I've updated my repo's `master`, it both runs much faster, and > succeeds. Right; a few days ago I also had to look up the "origin/master" references in ".pytool/Plugin/EccCheck/EccCheck.py" to understand how it restricts the warnings to "new" code. I have a dedicated VM for running CI locally, so whenever I push a topic branch to that, I just have to push my most recently fetched master branch reference to the VM as well. Thanks! Laszlo > > A weekly build which runs Ecc over all the code and compiles a report of > issues might be nice. > >