From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 56F7B7803CF for ; Wed, 13 Dec 2023 16:52:51 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=D0nALxoofLPMwH0ti2rhqEBwMaTFiwVbG+k95neAnzA=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702486370; v=1; b=ko8FohF1IvfEJRyNYGW1pZ9fQyiwalMCwcb6TInOpu5mMnyZGVp7wLoZ5hbxI2ZwSKjIsaCv rhQtYo87GW2c1qazVCbJM6TQMIeo6Q/G22QOG3NOAwZPn756ScKggitDw30jhlgjEkN9cZTpFWb B1A1gmEyqsStSmyv5KzepU6s= X-Received: by 127.0.0.2 with SMTP id Pld9YY7687511xy8XrzdONNU; Wed, 13 Dec 2023 08:52:50 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.40929.1702486369353770026 for ; Wed, 13 Dec 2023 08:52:49 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-34--e5JmiaIOUqQh3rd5nQrfg-1; Wed, 13 Dec 2023 11:52:42 -0500 X-MC-Unique: -e5JmiaIOUqQh3rd5nQrfg-1 X-Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9E646101A52A; Wed, 13 Dec 2023 16:52:41 +0000 (UTC) X-Received: from [10.39.194.93] (unknown [10.39.194.93]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E966AC15968; Wed, 13 Dec 2023 16:52:39 +0000 (UTC) Message-ID: <309c37ed-bf89-b25a-fd59-2179f3fb415b@redhat.com> Date: Wed, 13 Dec 2023 17:52:38 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v3 4/6] OvmfPkg: Specifies SmmCpuSyncLib instance To: devel@edk2.groups.io, jiaxin.wu@intel.com Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen , Eric Dong , Ray Ni , Zeng Star , Rahul Kumar , Gerd Hoffmann References: <20231206100122.8028-1-jiaxin.wu@intel.com> <20231206100122.8028-5-jiaxin.wu@intel.com> From: "Laszlo Ersek" In-Reply-To: <20231206100122.8028-5-jiaxin.wu@intel.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: KA8pkioINdHPmhwOntrgbzRmx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ko8FohF1; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 12/6/23 11:01, Wu, Jiaxin wrote: > This patch is to specify SmmCpuSyncLib instance for OvmfPkg. >=20 > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Eric Dong > Cc: Ray Ni > Cc: Zeng Star > Cc: Rahul Kumar > Cc: Gerd Hoffmann > Signed-off-by: Jiaxin Wu > --- > OvmfPkg/CloudHv/CloudHvX64.dsc | 2 ++ > OvmfPkg/OvmfPkgIa32.dsc | 2 ++ > OvmfPkg/OvmfPkgIa32X64.dsc | 2 ++ > OvmfPkg/OvmfPkgX64.dsc | 1 + > 4 files changed, 7 insertions(+) >=20 > diff --git a/OvmfPkg/CloudHv/CloudHvX64.dsc b/OvmfPkg/CloudHv/CloudHvX64.= dsc > index 821ad1b9fa..f735b69a37 100644 > --- a/OvmfPkg/CloudHv/CloudHvX64.dsc > +++ b/OvmfPkg/CloudHv/CloudHvX64.dsc > @@ -183,10 +183,12 @@ > PeiHardwareInfoLib|OvmfPkg/Library/HardwareInfoLib/PeiHardwareInfoLib.= inf > DxeHardwareInfoLib|OvmfPkg/Library/HardwareInfoLib/DxeHardwareInfoLib.= inf > ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib= /ImagePropertiesRecordLib.inf > !if $(SMM_REQUIRE) =3D=3D FALSE > LockBoxLib|OvmfPkg/Library/LockBoxLib/LockBoxBaseLib.inf > +!else > + SmmCpuSyncLib|UefiCpuPkg/Library/SmmCpuSyncLib/SmmCpuSyncLib.inf > !endif > CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/Customi= zedDisplayLib.inf > FrameBufferBltLib|MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBl= tLib.inf > MemEncryptTdxLib|OvmfPkg/Library/BaseMemEncryptTdxLib/BaseMemEncryptTd= xLib.inf > =20 > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index bce2aedcd7..b05b13b18c 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -188,10 +188,12 @@ > PeiHardwareInfoLib|OvmfPkg/Library/HardwareInfoLib/PeiHardwareInfoLib.= inf > DxeHardwareInfoLib|OvmfPkg/Library/HardwareInfoLib/DxeHardwareInfoLib.= inf > ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib= /ImagePropertiesRecordLib.inf > !if $(SMM_REQUIRE) =3D=3D FALSE > LockBoxLib|OvmfPkg/Library/LockBoxLib/LockBoxBaseLib.inf > +!else > + SmmCpuSyncLib|UefiCpuPkg/Library/SmmCpuSyncLib/SmmCpuSyncLib.inf > !endif > CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/Customi= zedDisplayLib.inf > FrameBufferBltLib|MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBl= tLib.inf > =20 > !if $(SOURCE_DEBUG_ENABLE) =3D=3D TRUE > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index 631e909a54..5a16eb7abe 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -193,10 +193,12 @@ > PeiHardwareInfoLib|OvmfPkg/Library/HardwareInfoLib/PeiHardwareInfoLib.= inf > DxeHardwareInfoLib|OvmfPkg/Library/HardwareInfoLib/DxeHardwareInfoLib.= inf > ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib= /ImagePropertiesRecordLib.inf > !if $(SMM_REQUIRE) =3D=3D FALSE > LockBoxLib|OvmfPkg/Library/LockBoxLib/LockBoxBaseLib.inf > +!else > + SmmCpuSyncLib|UefiCpuPkg/Library/SmmCpuSyncLib/SmmCpuSyncLib.inf > !endif > CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/Customi= zedDisplayLib.inf > FrameBufferBltLib|MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBl= tLib.inf > =20 > !if $(SOURCE_DEBUG_ENABLE) =3D=3D TRUE > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index 4ea3008cc6..6bb4c777b9 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -209,10 +209,11 @@ > !if $(SMM_REQUIRE) =3D=3D FALSE > LockBoxLib|OvmfPkg/Library/LockBoxLib/LockBoxBaseLib.inf > CcProbeLib|OvmfPkg/Library/CcProbeLib/DxeCcProbeLib.inf > !else > CcProbeLib|MdePkg/Library/CcProbeLibNull/CcProbeLibNull.inf > + SmmCpuSyncLib|UefiCpuPkg/Library/SmmCpuSyncLib/SmmCpuSyncLib.inf > !endif > CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/Customi= zedDisplayLib.inf > FrameBufferBltLib|MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBl= tLib.inf > =20 > !if $(SOURCE_DEBUG_ENABLE) =3D=3D TRUE All four DSC files already include "PiSmmCpuDxeSmm.inf" like this: UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf { ... } Given that this new library class is again exclusively used by PiSmmCpuDxeSmm, can you please resolve this lib class too in module scope only? Thanks! Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112487): https://edk2.groups.io/g/devel/message/112487 Mute This Topic: https://groups.io/mt/103010166/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-