From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Thu, 08 Aug 2019 13:34:20 -0700
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 3840380F81;
	Thu,  8 Aug 2019 20:34:19 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-122.ams2.redhat.com [10.36.117.122])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 29D1619C69;
	Thu,  8 Aug 2019 20:34:16 +0000 (UTC)
Subject: Re: [edk2-devel] [Patch] MdeModulePkg RegularExpressionDxe: Update Oniguruma from v6.9.0 to v6.9.3
To: "Gao, Liming" <liming.gao@intel.com>,
 "devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Wang, Jian J" <jian.j.wang@intel.com>, "Wu, Hao A" <hao.a.wu@intel.com>,
 Cinnamon Shia <cinnamon.shia@hpe.com>,
 "leif.lindholm@linaro.org" <leif.lindholm@linaro.org>,
 "afish@apple.com" <afish@apple.com>,
 "Kinney, Michael D" <michael.d.kinney@intel.com>,
 "Cetola, Stephano" <stephano.cetola@intel.com>
References: <15B8F5E6C2C74026.10163@groups.io>
 <4A89E2EF3DFEDB4C8BFDE51014F606A14E4CCE86@SHSMSX104.ccr.corp.intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <30cc2689-ec3b-8f31-541a-221bf6e6167b@redhat.com>
Date: Thu, 8 Aug 2019 22:34:16 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4CCE86@SHSMSX104.ccr.corp.intel.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 08 Aug 2019 20:34:19 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 08/08/19 15:52, Gao, Liming wrote:
> Hi, all
>   This patch is big. I upload it into https://github.com/lgao4/edk2/tree/Oniguruma6.9.3 for your review. 
> 
> Hi, Stewards:
>    Oniguruma version v6.9.3 is released for security fix. So, I plan to include this update for 201908 stable tag. If you have any comments, please let me know. 

I would generally prefer large updates near the beginning of the
development cycle, but I can see that
<https://github.com/kkos/oniguruma/releases/tag/v6.9.3> was released
just three days ago. So, no objection from me.

I have a separate suggestion: can you please file a TianoCore feature
request BZ for the next development cycle, for investigating whether we
can consume Oniguruma through a git submodule?

Thanks,
Laszlo