From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.640.1675828183141158186 for ; Tue, 07 Feb 2023 19:49:43 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=iT5xe+f7; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.201.8.94]) by linux.microsoft.com (Postfix) with ESMTPSA id B880020C8AC0; Tue, 7 Feb 2023 19:49:41 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B880020C8AC0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1675828182; bh=usiH3Jad/2x5S9k3Vf5KBXgefG4KQOsue9An5/YTtpE=; h=Date:Subject:From:To:Cc:Reply-To:References:In-Reply-To:From; b=iT5xe+f7NQXwNHrIUZmB3i7CUdOcfKZmLD2uJbyAlrItnBeDhE96SnBUgSfepEO3F StEriFxVDULObJuVFHGrD72+Z67fHg/62oUNa0aQpDKog/2f+QOx/kZ/OK75kYzOp/ ykxKqqi64PEGWD1p8fCcVmoFuXITVKLZ+wxsr27o= Message-ID: <30f2404b-1cb5-7292-18a6-2cd10a4591b4@linux.microsoft.com> Date: Tue, 7 Feb 2023 22:49:40 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file From: "Michael Kubacki" To: devel@edk2.groups.io, "Gao, Liming" Cc: Chris Fernald , Oliver Steffen , Sean Brogan , Michael D Kinney , Leif Lindholm , Andrew Fish Reply-To: devel@edk2.groups.io, mikuback@linux.microsoft.com References: <173C1FA3C96CC3CD.14781@groups.io> <173DE310BC2140E3.21537@groups.io> <93c5b688-aa28-2d3c-7ee0-1c6916a2d327@linux.microsoft.com> In-Reply-To: <93c5b688-aa28-2d3c-7ee0-1c6916a2d327@linux.microsoft.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Liming, I put the patch with received review tags in the following PR: https://github.com/tianocore/edk2/pull/4015 Thanks, Michael On 2/5/2023 1:34 PM, Michael Kubacki wrote: > With the soft freeze starting soon, I wanted to bring attention to this= =20 > patch again. It has not received feedback in 2+ weeks on the list. >=20 > It is simple and intended to help users more easily use Tianocore=20 > containers. >=20 > Can you please review and include this in the stable tag? >=20 > Thanks, > Michael >=20 > On 1/26/2023 9:44 AM, Michael Kubacki wrote: >> I've seen interest on the patch but no R-b yet. I believe those in the= =20 >> TO line might be the best to provide that since this is a new directory. >> >> If anyone is interested in being a maintainer/reviewer, let me know=20 >> and I'll update the file. >> >> Thanks, >> Michael >> >> On 1/20/2023 3:51 PM, Michael Kubacki wrote: >>> From: Michael Kubacki >>> >>> Tianocore maintains container images in the tianocore/containers repo >>> and stores container images within the GitHub container registry. >>> >>> https://github.com/tianocore/containers >>> >>> This change adds a devcontainer.json file to the edk2 repo. This >>> file's metadata and settings to configurate a development container >>> for a given well-defined tool and runtime stack. >>> >>> More information about the devcontainer.json file is available here: >>> https://containers.dev/implementors/json_reference/ >>> >>> This file is recognized by popular tools such as GitHub Codespaces >>> and VS Code. In VS Code in particular, it makes it much easier for >>> a user to be aware a dev container exists (via UI notifications) >>> and to load the container. >>> >>> A minimal number of VS Code extensions are specified that are useful >>> for edk2 development or to assist in complying with CI checks in >>> place in edk2. >>> >>> Cc: Andrew Fish >>> Cc: Chris Fernald >>> Cc: Leif Lindholm >>> Cc: Michael D Kinney >>> Cc: Oliver Steffen >>> Signed-off-by: Michael Kubacki >>> --- >>> =C2=A0 .devcontainer/devcontainer.json | 16 ++++++++++++++++ >>> =C2=A0 Maintainers.txt=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 5 +++++ >>> =C2=A0 2 files changed, 21 insertions(+) >>> >>> diff --git a/.devcontainer/devcontainer.json=20 >>> b/.devcontainer/devcontainer.json >>> new file mode 100644 >>> index 000000000000..592bb8cf6626 >>> --- /dev/null >>> +++ b/.devcontainer/devcontainer.json >>> @@ -0,0 +1,16 @@ >>> +{ >>> +=C2=A0 "image": "ghcr.io/tianocore/containers/fedora-35-dev:latest", >>> +=C2=A0 "postCreateCommand": "git config --global --add safe.directory = *=20 >>> && pip install --upgrade -r pip-requirements.txt", >>> +=C2=A0 "customizations": { >>> +=C2=A0=C2=A0=C2=A0 "vscode": { >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "extensions": [ >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "DavidAnson.vscode-markdown= lint", >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "ms-azuretools.vscode-docke= r", >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "ms-vscode-remote.remote-co= ntainers", >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "ms-vscode.cpptools", >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "walonli.edk2-vscode", >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "zachflower.uncrustify" >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ] >>> +=C2=A0=C2=A0=C2=A0 } >>> +=C2=A0 } >>> +} >>> diff --git a/Maintainers.txt b/Maintainers.txt >>> index 68f603b48398..4aa7973d5156 100644 >>> --- a/Maintainers.txt >>> +++ b/Maintainers.txt >>> @@ -117,6 +117,11 @@ M: Michael Kubacki=20 >>> [makubacki] >>> =C2=A0 R: Michael D Kinney [mdkinney] >>> =C2=A0 R: Liming Gao [lgao4] >>> +.devcontainer/ >>> +F: .devcontainer/ >>> +M: Michael Kubacki [makubacki] >>> +R: Chris Fernald [cfernald] >>> + >>> =C2=A0 .github/ >>> =C2=A0 F: .github/ >>> =C2=A0 M: Sean Brogan [spbrogan] >> >> >>=20 >>