From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 72BD721CF1CF7 for ; Mon, 12 Feb 2018 18:44:53 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Feb 2018 18:50:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,505,1511856000"; d="scan'208";a="17258868" Received: from ray-dev.ccr.corp.intel.com (HELO [10.239.9.37]) ([10.239.9.37]) by fmsmga007.fm.intel.com with ESMTP; 12 Feb 2018 18:50:42 -0800 To: Laszlo Ersek , edk2-devel-01 Cc: Jaben Carsey References: <20180212134513.6882-1-lersek@redhat.com> <20180212134513.6882-5-lersek@redhat.com> From: "Ni, Ruiyu" Message-ID: <311b2ea7-e4d6-ff19-4d78-0749ccfa58e6@Intel.com> Date: Tue, 13 Feb 2018 10:50:42 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180212134513.6882-5-lersek@redhat.com> Subject: Re: [PATCH 4/4] ShellPkg: remove superfluous TimerLib resolution X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Feb 2018 02:44:53 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 2/12/2018 9:45 PM, Laszlo Ersek wrote: > TimerLib had to be resolved in commit 5ab97a64b51c ("ShellPkg/bcfg: Add > Shell Spec 2.2 modification functionality", 2017-03-01) because: > > - the BCFG command started making calls to UefiBootManagerLib > (EfiBootManagerVariableToLoadOption(), > EfiBootManagerLoadOptionToVariable(), EfiBootManagerFreeLoadOption()), > > - and "MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf" > depended on TimerLib. > > Because TimerLib is platform-specific, but "ShellPkg/ShellPkg.dsc" is > meant to produce a UEFI shell binary that is platform-independent (see > "ShellBinPkg/ReadMe.txt"), we resolved TimerLib to > "BaseTimerLibNullTemplate.inf". (TimerLib functionality was never actually > needed on UefiBootManagerLib code paths that were exercised by the shell / > BCFG.) > > Thanks to the last patch, UefiBootManagerLib no longer depends on > TimerLib, thus we can drop the TimerLib resolution entirely. > > Cc: Jaben Carsey > Cc: Ruiyu Ni > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Laszlo Ersek > --- > ShellPkg/ShellPkg.dsc | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/ShellPkg/ShellPkg.dsc b/ShellPkg/ShellPkg.dsc > index 29f537641285..1c923f585149 100644 > --- a/ShellPkg/ShellPkg.dsc > +++ b/ShellPkg/ShellPkg.dsc > @@ -58,7 +58,6 @@ [LibraryClasses.common] > > UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > - TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplate.inf > PerformanceLib|MdePkg/Library/BasePerformanceLibNull/BasePerformanceLibNull.inf > DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf > DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf > Very great clean up. Reviewed-by: Ruiyu Ni -- Thanks, Ray