From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8E6A7AC17E2 for ; Fri, 22 Sep 2023 14:11:02 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=/M2rWRtwMUom96vk9cVq4PYgZnC+NwJw4k9BMbAQLWU=; c=relaxed/simple; d=groups.io; h=Received-SPF:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Authentication-Results-Original:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:NoDisclaimer:Original-Authentication-Results:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1695391861; v=1; b=RW6XP9OKYd/bT1oBC2GMXBFfb4UoxKHJIrJMkb/3wK9l2dNpey0VsSXTc697Aqh07udXX6cy G+C3whco/jBoHmjhQ5BzQy3xCGm64WAPfv+GhWp+cxEGyKaEOoTgYasswU1UQZYzpLJW2+oVryV rKW6EJcUiGrIcsGNyi9myJME= X-Received: by 127.0.0.2 with SMTP id ppXYYY7687511xNnuD9DNUoS; Fri, 22 Sep 2023 07:11:01 -0700 X-Received: from EUR05-DB8-obe.outbound.protection.outlook.com (EUR05-DB8-obe.outbound.protection.outlook.com [40.107.20.73]) by mx.groups.io with SMTP id smtpd.web11.22563.1695391859848603408 for ; Fri, 22 Sep 2023 07:11:00 -0700 X-Received: from DUZPR01CA0039.eurprd01.prod.exchangelabs.com (2603:10a6:10:468::17) by DBAPR08MB5735.eurprd08.prod.outlook.com (2603:10a6:10:1a1::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.23; Fri, 22 Sep 2023 14:10:55 +0000 X-Received: from DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:468:cafe::89) by DUZPR01CA0039.outlook.office365.com (2603:10a6:10:468::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.30 via Frontend Transport; Fri, 22 Sep 2023 14:10:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT018.mail.protection.outlook.com (100.127.142.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.20 via Frontend Transport; Fri, 22 Sep 2023 14:10:55 +0000 X-Received: ("Tessian outbound 0b7d6027328f:v175"); Fri, 22 Sep 2023 14:10:55 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 7caf6945f05072e2 X-CR-MTA-TID: 64aa7808 X-Received: from 29414f9d6398.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D568E521-BA61-4314-8EB2-C956EBE00C9F.1; Fri, 22 Sep 2023 14:10:49 +0000 X-Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 29414f9d6398.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 22 Sep 2023 14:10:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=miMjSoZf9qM2KaeomNz2kuKCf4RjOGnI4CssUeDm8lCVYdRL9xRGxltIjI+55KEVPcH1u5xX0NIejH2sPtV9R6FtEL+dVvkK7OsHv2kRiMIJ2p3K7/j7O90ynLPQmsCAJDzmcBtfXy8uVtqa9XH+h6aB6L+0StfGPGH+3hJDWESXZO1H4AvEQD7LrAIJn24+dyXTWbPw3wi9VT6DsSoGocsJvn5ExVVIwra6M1qNXDbOSQbwgKYlSGcyddqitlCGk94b1Ge5i0BV6ENmpFiJ85YxPHPkQyP9wYsxCLXiX97MrAZSFIZpTZQScV2KBNAvvBRfRMG2ZOMjrYr1qXkNsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tLO/3piZjdqQ8DC9FBxQGnH1pTw0bWC1h2J62vrSqEg=; b=cC5iVNLqEDSN6YHjMX3nkTB3cA7TmfCsIlOOA2B8fvSHeUjCgNV0+zZO5+2/Dli81T9WVfI3DsO9XvsPF6pWdNpNOxKO0suPgxBfDjGdiVzNbmY43+dgZ+oVMdzma3eLBCq2xNIxtQf42ml3rIcVMjLSA+RP2/huhUhwoDTqgfGdncnhhHxTvf5BJHR7bdWnXLTfYFVjwYQi7Grb9vbPPdmSvkWSgI4skvd4+vFfGNQmppjX/xsBnhHDcJiROGpHiREC6gvlBB+egweQ5TvGAqMrV9l1GFR+YhJKnH0MgAs9ob070/vWWBiiZtuzOtTZTj3ZU40LFDy0Xd98w/+EKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM8PR08MB5746.eurprd08.prod.outlook.com (2603:10a6:20b:1d8::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.19; Fri, 22 Sep 2023 14:10:48 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::ac37:4594:ab86:59ce]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::ac37:4594:ab86:59ce%4]) with mapi id 15.20.6813.017; Fri, 22 Sep 2023 14:10:47 +0000 Message-ID: <311b419b-4332-1352-b39d-15552fe876c9@arm.com> Date: Fri, 22 Sep 2023 15:10:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [edk2-devel] [PATCH v2 0/2] Add support for PCI IO using Qword resources To: Jeff Brasen , devel@edk2.groups.io Cc: pierre.gondois@arm.com, quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, "nd@arm.com" References: From: "Sami Mujawar" In-Reply-To: X-ClientProxiedBy: LNXP123CA0001.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:d2::13) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|AM8PR08MB5746:EE_|DBAEUR03FT018:EE_|DBAPR08MB5735:EE_ X-MS-Office365-Filtering-Correlation-Id: 7d62bffd-0573-4793-e2e9-08dbbb75bcd9 X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: o2UvvSFBhueRuqDO4SdCT2uINC3oMekE/ljzfjMzE23z++jngvRVaNEwGj6eVwolbzz1ho9qQDZLq6qCqIhFD4n4o9tvCDnz/eUDbbk0vTAB13MUBoVcTelfVYdWezUXLdIOun0eN20v03D3+hmF3Hl1v4daryOg8mhaeb9aLy/Ow383JCTOXgfNSiDDNp4gyWjVOwmTPMMX6iwA5DHfG1qJH1nD/WBG7Crgos+zUmjKnSzN2KvrYHrsC3DkkLDql/KslNpYH077Mmc1QeX/6jvvbwsc7WvcF3oNTnchkh5AH8b6DtM3hF8AIhH52aamFoeCMukMztp32jd+AQoYOgZgJl26QSZeh3vdrZNpttTOfv40pyMMxHzKmG8O0kBUnLgzsaeeLP5Okwv1YEc0+8e09WVUwp0lQqkFbgqjzcfqLBpqglrdbJunMpjzQ0JA/OcjdU+r7Jnw0mxdS0aWx38sFM8wS2WNFvdzpT2L7KwkozoaWLpxIOFLErVmKES512b092hW2CxmnEzTWZdl/FGWFTmAqmXWruK0COsiaphMjycYbsNLpPyDKTOwcXNFWmK32L35sBM/LEYNJMmBt/1Lnsu/L4vVw1nbhp3LdwcY0rbG8PDnkXOqdZPfU4AGApJgByxq4FmVrZFksi1MPg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(396003)(376002)(39860400002)(346002)(136003)(1800799009)(186009)(451199024)(53546011)(6512007)(6486002)(478600001)(6506007)(8676002)(44832011)(8936002)(83380400001)(66556008)(66946007)(31686004)(316002)(66476007)(5660300002)(2616005)(38100700002)(31696002)(36756003)(4326008)(86362001)(2906002)(4744005)(41300700001)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5746 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ae52cd8e-1d71-41b0-bc7a-08dbbb75b7cd X-Microsoft-Antispam-Message-Info: nFDROn+7g1vp3oq/XpxdVX22WEwbKhFW1i5VtG6R0fQBdOKcUMRMdsTl9QhhnpsulIt/1fgj/Mw3ODnEFQyydMc4pbnp0UwRw9i/hNsvslvSOJjmogHz9bG8h8+vkTJuRoT0Jqk5DMHXM5PmqE2YvqJGGJ2exOcuVOAjTwdTQImzb4MeFJlKEgqSTFszuO78+MRnuYlwyruDovjsZHsNMGcts53qvdF5SaZovHjIvHtIqyEt0lHKFcMVD0W4O6PJcPa6rl8Hk5cFpT4tImblRTBXv19FggVRmn2doORtcIsi3TvqUtu5QS8vP9SHEEuctAaIrVdL3VPlrC5KoWDHxidixI4mOt4uqWv0gGTltxDlJnGeGqNzdYSN/q9F9QCECnIuUEKlOA7mIsiK3h9mPWsOUgaqlLva8jrxzfYLyEtwBCfxzH+rOe2cmOhsSXMmMZEErgc7Q1FRyQE27QIrQ8mnlCPQTm2khuQKValuCLQj9B31JF/sW4LHCEuyu5KA5cOWpgO9Mlfd4WovQtKWPMCarRgze0lAI/qGBnWDY8tP9lklNqAkGGzx+6ekFH6S/KbCYNnLpHLZfyIooeO5cqCAXISaX8hfXAgbjk1LqENmSqq7o8TM74+EP5tC//nYN7Hi1Zpfwyw5CrJk08uvgfkKgOPXlQee/OR39nXajn+jIj7iGhJ9ZngUfmuH/yKcTJNuM+6CGYkA05FvGzqJyRxjnjT9no200vaXijXMIBCwXXBuYXYxKrTKNJdiKX5YSLWqxh95bRLQMJWwgAodQw== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2023 14:10:55.7020 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7d62bffd-0573-4793-e2e9-08dbbb75bcd9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5735 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: bwhU35UsN5I9pNng01hOjm6ux7686176AA= Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=RW6XP9OK; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Jeff, Thank out for this patch series. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 21/09/2023 09:10 pm, Jeff Brasen wrote: > Use AmlCodeGenRdQWordIo() to generate the I/O range in _CRS instead of > AmlCodeGenRdDWordIo() to cater to the scenarios where 64-bit > addresses can be used to generate I/O packets over the PCIe bus. > > Changes: > v2 - Rebased and set transferEncoding =3D 8bit > > Vidya Sagar (2): > DynamicTablesPkg: AML Code generation for I/O ranges > DynamicTablesPkg: AcpiSsdtPcieLibArm: Use QWord todescribe I/O range > > .../Include/Library/AmlLib/AmlLib.h | 67 ++++++++++++++ > .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.c | 2 +- > .../AmlLib/CodeGen/AmlResourceDataCodeGen.c | 90 +++++++++++++++++++ > 3 files changed, 158 insertions(+), 1 deletion(-) > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108990): https://edk2.groups.io/g/devel/message/108990 Mute This Topic: https://groups.io/mt/101508452/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-