Hi Vijay, > > +#define HMAT_STRUCTURE_MEMORY_SIDE_CACHE_INFO_CACHE_ATTRIBUTES_INIT( \ > + TotalCacheLevels, CacheLevel, CacheAssociativity, WritePolicy, > CacheLineSize \ > + ) \ > +{ \ > + TotalCacheLevels, CacheLevel, CacheAssociativity, WritePolicy, > CacheLineSize \ > +} This macros is again repeated in patch 3/3. I think this could be moved to Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h. If you agree I can make this change locally before pushing this series. Regards, Sami Mujawar