From mboxrd@z Thu Jan  1 00:00:00 1970
Subject: Re: [edk2-devel] [edk2-platforms] [PATCH v3 2/3] Platform/ARM/SgiPkg: Add HMAT ACPI table for RdN1EdgeX2
To: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>,devel@edk2.groups.io
From: "Sami Mujawar" <sami.mujawar@arm.com>
X-Originating-Location: GB (217.140.106.53)
X-Originating-Platform: Windows Firefox 87
User-Agent: GROUPS.IO Web Poster
MIME-Version: 1.0
Date: Wed, 07 Apr 2021 11:37:12 -0700
References: <1613559717-30499-3-git-send-email-vijayenthiran.subramaniam@arm.com>
In-Reply-To: <1613559717-30499-3-git-send-email-vijayenthiran.subramaniam@arm.com>
Message-ID: <3142.1617820632237714937@groups.io>
Content-Type: multipart/alternative; boundary="zYDmkYsu1RMyfxKGwyCO"

--zYDmkYsu1RMyfxKGwyCO
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Vijay,

>=20
> +#define HMAT_STRUCTURE_MEMORY_SIDE_CACHE_INFO_CACHE_ATTRIBUTES_INIT( \
> + TotalCacheLevels, CacheLevel, CacheAssociativity, WritePolicy,
> CacheLineSize \
> + ) \
> +{ \
> + TotalCacheLevels, CacheLevel, CacheAssociativity, WritePolicy,
> CacheLineSize \
> +}

This macros is again repeated in patch 3/3. I think this could be moved to=
 Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h.
If you agree I can make this change locally before pushing this series.

Regards,

Sami Mujawar

--zYDmkYsu1RMyfxKGwyCO
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Vijay,<br /><br />
<blockquote>+#define HMAT_STRUCTURE_MEMORY_SIDE_CACHE_INFO_CACHE_ATTRIBUTE=
S_INIT( \<br />+ TotalCacheLevels, CacheLevel, CacheAssociativity, WritePol=
icy, CacheLineSize \<br />+ ) \<br />+{ \<br />+ TotalCacheLevels, CacheLev=
el, CacheAssociativity, WritePolicy, CacheLineSize \<br />+}</blockquote>
This macros is again repeated in patch 3/3. I think this could be moved to=
 Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h.<br />If you agree I can make =
this change locally before pushing this series.<br /><br />Regards,<br /><b=
r />Sami Mujawar

--zYDmkYsu1RMyfxKGwyCO--