Re: [edk2-devel] [PATCH v1 1/2] OvmfPkg: Add no hardcode version of FtdNorFlashQemuLib

["Marcin Juszkiewicz" <marcin.juszkiewicz@linaro.org>]

W dniu 17.05.2024 o 09:17, Chao Li via groups.io pisze:
> This library is copied from ArmVirtPkg, in the Arm version, the value of
> PcdFlashNvStorageVariableBase, PcdFlashNvStorageFtwWorkingBase and
> PcdFlashNvStorageFtwSpareBase are hardcoded in INC file.
> 
> This version will calculate them from FDT resource and using the set PCD
> to store when the NorFlashInitialise is called. By default, the first
> available flash(not used for storage UEFI code) as NV variable storage
> medium.
> 
> In this way, UEFI can better handle the change of flash base address,
> which is suitable for different cpu architecture board implementation.
> 
> BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=4770
> 
> Cc: Ard Biesheuvel<ardb+tianocore@kernel.org>
> Cc: Leif Lindholm<quic_llindhol@quicinc.com>
> Cc: Sami Mujawar<sami.mujawar@arm.com>
> Cc: Gerd Hoffmann<kraxel@redhat.com>
> Cc: Jiewen Yao<jiewen.yao@intel.com>
> Signed-off-by: Chao Li<lichao@loongson.cn>
> Signed-off-by: Xianglai Li<lixianglai@loongson.cn>

Can you split it into driver itself and part which uses DT data to setup 
parameters?

This way driver can be used on other platforms as well, despite do they 
hardcode flash data, read it via Firmware Handoff protocol, SMC calls to 
embedded controller or have other way to keep flash data.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119251): https://edk2.groups.io/g/devel/message/119251
Mute This Topic: https://groups.io/mt/106149595/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-