From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 527D094141D for ; Fri, 24 May 2024 09:11:48 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=zdslJn6QNagqAOJT76bqJ6JZbLeaipDpcDZTIWlPuAA=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:Organization:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1716541906; v=1; b=jwjfdEK1HnZd9yRu/8xAnjbgwsE1soohXly/TQ1VhplmPdzMsGXzvJU7jmk3brf/LDGdg3Bw 1KxaVcl+OPcQ6KJZ10tvDeU5cv7Lp/YGtu4n6Bn+7nd1KfMF4RP7uG91J0XYgGCIrA4Q/kJJgAE MTZtFPUKgkxQkG9odQjF9jx3fOD7DuD9ms4fgPLgcCr6gJdAU84ioJVuKZ7GiiAH+RSsvzdTY7u psw4cXnbAq+GqD05U5n+xrpILLOhV9dNoYCdfkIqwY4DSp4sEYFp4TRhgldYEvVmjkcnz3GButX kgciI+ViS/86ScCIi1/7mHm647o0ETWjXpbtJ61Veu1zg== X-Received: by 127.0.0.2 with SMTP id 3RucYY7687511xdI7K1PSVsB; Fri, 24 May 2024 02:11:46 -0700 X-Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by mx.groups.io with SMTP id smtpd.web10.11593.1716541906049033535 for ; Fri, 24 May 2024 02:11:46 -0700 X-Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-a6265d48ec3so71669066b.0 for ; Fri, 24 May 2024 02:11:45 -0700 (PDT) X-Gm-Message-State: gBNqJ10sDzFqObeSWBdZZgAsx7686176AA= X-Google-Smtp-Source: AGHT+IEz7ttz5G2q3XfGuTlnjV41tzodWV/r3RgpyDJ3bZNvUFp5uaXHXJi5AoKgj8LNfLC9nHkZaw== X-Received: by 2002:a17:906:57d9:b0:a5c:ec66:226d with SMTP id a640c23a62f3a-a62641b1bb4mr122815166b.17.1716541904152; Fri, 24 May 2024 02:11:44 -0700 (PDT) X-Received: from [192.168.200.106] (83.11.37.15.ipv4.supernova.orange.pl. [83.11.37.15]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a626cc8dca7sm98222866b.181.2024.05.24.02.11.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 May 2024 02:11:43 -0700 (PDT) Message-ID: <314a58cc-9add-493e-a3d7-fd77edf77999@linaro.org> Date: Fri, 24 May 2024 11:11:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v1 1/2] OvmfPkg: Add no hardcode version of FtdNorFlashQemuLib To: devel@edk2.groups.io, lichao@loongson.cn Cc: Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Gerd Hoffmann , Jiewen Yao , Xianglai Li References: <20240517071729.188409-1-lichao@loongson.cn> <20240517071754.188521-1-lichao@loongson.cn> From: "Marcin Juszkiewicz" Organization: Linaro In-Reply-To: <20240517071754.188521-1-lichao@loongson.cn> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 24 May 2024 02:11:46 -0700 Resent-From: marcin.juszkiewicz@linaro.org Reply-To: devel@edk2.groups.io,marcin.juszkiewicz@linaro.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Language: pl-PL, en-GB, en-HK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=jwjfdEK1; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linaro.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io W dniu 17.05.2024 o 09:17, Chao Li via groups.io pisze: > This library is copied from ArmVirtPkg, in the Arm version, the value of > PcdFlashNvStorageVariableBase, PcdFlashNvStorageFtwWorkingBase and > PcdFlashNvStorageFtwSpareBase are hardcoded in INC file. > > This version will calculate them from FDT resource and using the set PCD > to store when the NorFlashInitialise is called. By default, the first > available flash(not used for storage UEFI code) as NV variable storage > medium. > > In this way, UEFI can better handle the change of flash base address, > which is suitable for different cpu architecture board implementation. > > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=4770 > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Sami Mujawar > Cc: Gerd Hoffmann > Cc: Jiewen Yao > Signed-off-by: Chao Li > Signed-off-by: Xianglai Li Can you split it into driver itself and part which uses DT data to setup parameters? This way driver can be used on other platforms as well, despite do they hardcode flash data, read it via Firmware Handoff protocol, SMC calls to embedded controller or have other way to keep flash data. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119251): https://edk2.groups.io/g/devel/message/119251 Mute This Topic: https://groups.io/mt/106149595/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-