From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5CF3E211A3216 for ; Mon, 4 Feb 2019 11:12:30 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D572FC0467DF; Mon, 4 Feb 2019 19:12:29 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-118-250.phx2.redhat.com [10.3.118.250]) by smtp.corp.redhat.com (Postfix) with ESMTP id EFBF81000049; Mon, 4 Feb 2019 19:12:28 +0000 (UTC) To: "Feng, Bob C" , Dandan Bi References: <20190203055515.18336-1-bob.c.feng@intel.com> Cc: edk2-devel@lists.01.org From: Laszlo Ersek Message-ID: <31516193-5bd7-8c97-9a18-03e569f57d94@redhat.com> Date: Mon, 4 Feb 2019 20:12:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190203055515.18336-1-bob.c.feng@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 04 Feb 2019 19:12:29 +0000 (UTC) Subject: Re: [Patch 0/3] BaseTools: Implement splitquoted function X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Feb 2019 19:12:30 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 02/03/19 06:55, Feng, Bob C wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1509 > On some Linux environment, there may be no distutils.util > library for python3 that will cause build tool crash. > This patch implement distutils.util.split_quoted > in BaseTools so that the Basetools will be independent with > distutils.util library. > > Feng, Bob C (3): > BaseTools: Implement splitquoted function in Build tool > BaseTools: Implement splitquoted function in UPT > BaseTools: unit test for splitquoted function > > BaseTools/Source/Python/AutoGen/UniClassObject.py | 50 ++++++++++++++++++++++++++++++++++++++++++++++---- > BaseTools/Source/Python/UPT/Library/UniClassObject.py | 47 ++++++++++++++++++++++++++++++++++++++++++++--- > BaseTools/Tests/TestStringSplit.py | 38 ++++++++++++++++++++++++++++++++++++++ > 3 files changed, 128 insertions(+), 7 deletions(-) > create mode 100644 BaseTools/Tests/TestStringSplit.py > Is this really necessary? BZ#1509 references Ubuntu18; however it looks like the issue can be resolved by a simple package installation on Ubuntu 18: https://superuser.com/questions/1319047/cant-install-virtual-interpreter-in-pycharm-in-linux """ sudo apt-get install python3-distutils """ I'm not a Ubuntu user myself; so all I can do here (without installing a Ubuntu18 VM) is check the Ubuntu package directory: https://packages.ubuntu.com/search?keywords=python3-distutils&searchon=names&suite=all§ion=all python3-distutils appears available for both "bionic (18.04LTS)" and "cosmic (18.10)". Dandan, if you install python3-distutils, does that solve the issue for you? Thanks Laszlo