* [RFC][edk2-platform][Add new packages in Platform\Intel directory] @ 2019-05-15 13:28 Liming Gao 2019-05-20 5:29 ` [edk2-devel] " Kubacki, Michael A 0 siblings, 1 reply; 7+ messages in thread From: Liming Gao @ 2019-05-15 13:28 UTC (permalink / raw) To: Kubacki, Michael A, Chaganty, Rangasai V; +Cc: devel@edk2.groups.io [-- Attachment #1: Type: text/plain, Size: 528 bytes --] Michael and Sai: Now, we have AcpiDebug module in Platform\Intel\AdvancedFeaturePkg for debug feature, and I also see new patch to add Cmos related libraries for board feature. To make those features be enabled separately, I propose to create new packages for them. One is DebugAdvancedFeaturePkg for the debug related features, another is GenericBoardPkg for the common board features. If there is new code to be added in Platform\Intel directory in future, new feature package can be created for them. Thanks Liming [-- Attachment #2: Type: text/html, Size: 2699 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory] 2019-05-15 13:28 [RFC][edk2-platform][Add new packages in Platform\Intel directory] Liming Gao @ 2019-05-20 5:29 ` Kubacki, Michael A 2019-05-22 4:00 ` Liming Gao 0 siblings, 1 reply; 7+ messages in thread From: Kubacki, Michael A @ 2019-05-20 5:29 UTC (permalink / raw) To: Gao, Liming, devel [-- Attachment #1: Type: text/plain, Size: 620 bytes --] Hi Liming, I agree with the need for both packages. We should wait at least another day for any additional feedback on the package name GenericBoardPkg. That name may give the impression the package can generically be used on various boards whereas the intent here is a package containing common or supporting board functionality. An alternative name to consider is BoardSupportPkg. As a reminder, ensure the separation of content follows 8.1 (or update the document if necessary): https://edk2-docs.gitbooks.io/edk-ii-minimum-platform-specification/8_stage_6_advanced_feature_selection/ Thanks, Michael [-- Attachment #2: Type: text/html, Size: 959 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory] 2019-05-20 5:29 ` [edk2-devel] " Kubacki, Michael A @ 2019-05-22 4:00 ` Liming Gao 2019-05-22 4:16 ` Kubacki, Michael A 0 siblings, 1 reply; 7+ messages in thread From: Liming Gao @ 2019-05-22 4:00 UTC (permalink / raw) To: Kubacki, Michael A, devel@edk2.groups.io [-- Attachment #1: Type: text/plain, Size: 1077 bytes --] Michael: I am OK for both name. I think they have same meaning. To avoid the common word in Package name, such as Generic or Universal, BoardSupportPkg name may be better. Thanks Liming From: Kubacki, Michael A [mailto:michael.a.kubacki@intel.com] Sent: Monday, May 20, 2019 1:30 PM To: Gao; Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io Subject: Re: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory] Hi Liming, I agree with the need for both packages. We should wait at least another day for any additional feedback on the package name GenericBoardPkg. That name may give the impression the package can generically be used on various boards whereas the intent here is a package containing common or supporting board functionality. An alternative name to consider is BoardSupportPkg. As a reminder, ensure the separation of content follows 8.1 (or update the document if necessary): https://edk2-docs.gitbooks.io/edk-ii-minimum-platform-specification/8_stage_6_advanced_feature_selection/ Thanks, Michael [-- Attachment #2: Type: text/html, Size: 5111 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory] 2019-05-22 4:00 ` Liming Gao @ 2019-05-22 4:16 ` Kubacki, Michael A 2019-05-22 16:59 ` Oram, Isaac W 0 siblings, 1 reply; 7+ messages in thread From: Kubacki, Michael A @ 2019-05-22 4:16 UTC (permalink / raw) To: Gao, Liming, devel@edk2.groups.io [-- Attachment #1: Type: text/plain, Size: 1457 bytes --] In that case, I’d like to move the proposed name to BoardSupportPkg. Thanks, Michael From: Gao, Liming Sent: Tuesday, May 21, 2019 9:00 PM To: Kubacki, Michael A <michael.a.kubacki@intel.com>; devel@edk2.groups.io Subject: RE: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory] Michael: I am OK for both name. I think they have same meaning. To avoid the common word in Package name, such as Generic or Universal, BoardSupportPkg name may be better. Thanks Liming From: Kubacki, Michael A [mailto:michael.a.kubacki@intel.com] Sent: Monday, May 20, 2019 1:30 PM To: Gao; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> Subject: Re: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory] Hi Liming, I agree with the need for both packages. We should wait at least another day for any additional feedback on the package name GenericBoardPkg. That name may give the impression the package can generically be used on various boards whereas the intent here is a package containing common or supporting board functionality. An alternative name to consider is BoardSupportPkg. As a reminder, ensure the separation of content follows 8.1 (or update the document if necessary): https://edk2-docs.gitbooks.io/edk-ii-minimum-platform-specification/8_stage_6_advanced_feature_selection/ Thanks, Michael [-- Attachment #2: Type: text/html, Size: 7051 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory] 2019-05-22 4:16 ` Kubacki, Michael A @ 2019-05-22 16:59 ` Oram, Isaac W 2019-05-24 5:22 ` Liming Gao 0 siblings, 1 reply; 7+ messages in thread From: Oram, Isaac W @ 2019-05-22 16:59 UTC (permalink / raw) To: devel@edk2.groups.io, Kubacki, Michael A, Gao, Liming [-- Attachment #1: Type: text/plain, Size: 2629 bytes --] I am concerned that BoardSupportPkg is misleading. My understanding is that many people are familiar with board support files, board support packages, and similar concepts explicitly using the words board and support. And in my experience, they have always had the board specific details. Our package does not, it has code supporting board specific code. Basically, I think that this is likely to be misleading to a lot of people. And I don’t particularly understand that common, generic, and universal are common, but support is not. I don’t really have a better suggestion, not having more specific details on the content handy, all names are “common”. Maybe we need to think more about what goes in here longer term so we have more coherence and thus a more specific name is possible. Regards, Isaac From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Kubacki, Michael A Sent: Tuesday, May 21, 2019 9:17 PM To: Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io Subject: Re: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory] In that case, I’d like to move the proposed name to BoardSupportPkg. Thanks, Michael From: Gao, Liming Sent: Tuesday, May 21, 2019 9:00 PM To: Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> Subject: RE: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory] Michael: I am OK for both name. I think they have same meaning. To avoid the common word in Package name, such as Generic or Universal, BoardSupportPkg name may be better. Thanks Liming From: Kubacki, Michael A [mailto:michael.a.kubacki@intel.com] Sent: Monday, May 20, 2019 1:30 PM To: Gao; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> Subject: Re: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory] Hi Liming, I agree with the need for both packages. We should wait at least another day for any additional feedback on the package name GenericBoardPkg. That name may give the impression the package can generically be used on various boards whereas the intent here is a package containing common or supporting board functionality. An alternative name to consider is BoardSupportPkg. As a reminder, ensure the separation of content follows 8.1 (or update the document if necessary): https://edk2-docs.gitbooks.io/edk-ii-minimum-platform-specification/8_stage_6_advanced_feature_selection/ Thanks, Michael [-- Attachment #2: Type: text/html, Size: 10069 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory] 2019-05-22 16:59 ` Oram, Isaac W @ 2019-05-24 5:22 ` Liming Gao 2019-05-24 16:31 ` Oram, Isaac W 0 siblings, 1 reply; 7+ messages in thread From: Liming Gao @ 2019-05-24 5:22 UTC (permalink / raw) To: Oram, Isaac W, devel@edk2.groups.io, Kubacki, Michael A [-- Attachment #1: Type: text/plain, Size: 3080 bytes --] Isaac: So, how about BoardModulePkg for them? Thanks Liming From: Oram, Isaac W Sent: Thursday, May 23, 2019 1:00 AM To: devel@edk2.groups.io; Kubacki, Michael A <michael.a.kubacki@intel.com>; Gao, Liming <liming.gao@intel.com> Subject: RE: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory] I am concerned that BoardSupportPkg is misleading. My understanding is that many people are familiar with board support files, board support packages, and similar concepts explicitly using the words board and support. And in my experience, they have always had the board specific details. Our package does not, it has code supporting board specific code. Basically, I think that this is likely to be misleading to a lot of people. And I don’t particularly understand that common, generic, and universal are common, but support is not. I don’t really have a better suggestion, not having more specific details on the content handy, all names are “common”. Maybe we need to think more about what goes in here longer term so we have more coherence and thus a more specific name is possible. Regards, Isaac From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Kubacki, Michael A Sent: Tuesday, May 21, 2019 9:17 PM To: Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> Subject: Re: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory] In that case, I’d like to move the proposed name to BoardSupportPkg. Thanks, Michael From: Gao, Liming Sent: Tuesday, May 21, 2019 9:00 PM To: Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> Subject: RE: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory] Michael: I am OK for both name. I think they have same meaning. To avoid the common word in Package name, such as Generic or Universal, BoardSupportPkg name may be better. Thanks Liming From: Kubacki, Michael A [mailto:michael.a.kubacki@intel.com] Sent: Monday, May 20, 2019 1:30 PM To: Gao; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> Subject: Re: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory] Hi Liming, I agree with the need for both packages. We should wait at least another day for any additional feedback on the package name GenericBoardPkg. That name may give the impression the package can generically be used on various boards whereas the intent here is a package containing common or supporting board functionality. An alternative name to consider is BoardSupportPkg. As a reminder, ensure the separation of content follows 8.1 (or update the document if necessary): https://edk2-docs.gitbooks.io/edk-ii-minimum-platform-specification/8_stage_6_advanced_feature_selection/ Thanks, Michael [-- Attachment #2: Type: text/html, Size: 11491 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory] 2019-05-24 5:22 ` Liming Gao @ 2019-05-24 16:31 ` Oram, Isaac W 0 siblings, 0 replies; 7+ messages in thread From: Oram, Isaac W @ 2019-05-24 16:31 UTC (permalink / raw) To: devel@edk2.groups.io, Gao, Liming [-- Attachment #1: Type: text/plain, Size: 3578 bytes --] That works for me. My apologies for the bike shedding. Regards, Isaac From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Liming Gao Sent: Thursday, May 23, 2019 10:22 PM To: Oram, Isaac W <isaac.w.oram@intel.com>; devel@edk2.groups.io; Kubacki, Michael A <michael.a.kubacki@intel.com> Subject: Re: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory] Isaac: So, how about BoardModulePkg for them? Thanks Liming From: Oram, Isaac W Sent: Thursday, May 23, 2019 1:00 AM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>> Subject: RE: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory] I am concerned that BoardSupportPkg is misleading. My understanding is that many people are familiar with board support files, board support packages, and similar concepts explicitly using the words board and support. And in my experience, they have always had the board specific details. Our package does not, it has code supporting board specific code. Basically, I think that this is likely to be misleading to a lot of people. And I don’t particularly understand that common, generic, and universal are common, but support is not. I don’t really have a better suggestion, not having more specific details on the content handy, all names are “common”. Maybe we need to think more about what goes in here longer term so we have more coherence and thus a more specific name is possible. Regards, Isaac From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Kubacki, Michael A Sent: Tuesday, May 21, 2019 9:17 PM To: Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> Subject: Re: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory] In that case, I’d like to move the proposed name to BoardSupportPkg. Thanks, Michael From: Gao, Liming Sent: Tuesday, May 21, 2019 9:00 PM To: Kubacki, Michael A <michael.a.kubacki@intel.com<mailto:michael.a.kubacki@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> Subject: RE: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory] Michael: I am OK for both name. I think they have same meaning. To avoid the common word in Package name, such as Generic or Universal, BoardSupportPkg name may be better. Thanks Liming From: Kubacki, Michael A [mailto:michael.a.kubacki@intel.com] Sent: Monday, May 20, 2019 1:30 PM To: Gao; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> Subject: Re: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory] Hi Liming, I agree with the need for both packages. We should wait at least another day for any additional feedback on the package name GenericBoardPkg. That name may give the impression the package can generically be used on various boards whereas the intent here is a package containing common or supporting board functionality. An alternative name to consider is BoardSupportPkg. As a reminder, ensure the separation of content follows 8.1 (or update the document if necessary): https://edk2-docs.gitbooks.io/edk-ii-minimum-platform-specification/8_stage_6_advanced_feature_selection/ Thanks, Michael [-- Attachment #2: Type: text/html, Size: 12987 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-05-24 16:31 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-05-15 13:28 [RFC][edk2-platform][Add new packages in Platform\Intel directory] Liming Gao 2019-05-20 5:29 ` [edk2-devel] " Kubacki, Michael A 2019-05-22 4:00 ` Liming Gao 2019-05-22 4:16 ` Kubacki, Michael A 2019-05-22 16:59 ` Oram, Isaac W 2019-05-24 5:22 ` Liming Gao 2019-05-24 16:31 ` Oram, Isaac W
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox