From: "Mario Bălănică" <mariobalanica02@gmail.com>
To: Pete Batard <pete@akeo.ie>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RaspberryPi: Fix mini UART baud divisor calculation
Date: Sat, 03 Apr 2021 08:17:07 -0700 [thread overview]
Message-ID: <31669.1617463027621445802@groups.io> (raw)
In-Reply-To: <6ebf4605-b011-a430-968b-d0f85cf91769@akeo.ie>
[-- Attachment #1: Type: text/plain, Size: 807 bytes --]
Hi Pete,
I've submitted this patch because the mini UART serial console produces garbage since UEFI v1.25 (due to the wrong baud rate).
It has been tested on the firmware shipped with UEFI v1.24 and it works fine. I don't see any reason to test it on older versions than this.
The core clock is not fixed. I've made PcdSerialClockRate patchable here:
>
> @@ -465,6 +464,9 @@ [PcdsFixedAtBuild.common]
> gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor|L"EDK2"
> gEfiMdeModulePkgTokenSpaceGuid.PcdSetNxForStack|TRUE
>
> +[PcdsPatchableInModule]
> + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialClockRate|500000000
> +
>
500 MHz is the default clock rate (assuming it hasn't been changed in config.txt).
The PCD gets patched in both the PEI and DXE phases to the value read from mailbox.
[-- Attachment #2: Type: text/html, Size: 1331 bytes --]
next prev parent reply other threads:[~2021-04-03 15:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 17:51 [edk2-platforms][PATCH 1/1] Platform/RaspberryPi: Fix mini UART baud divisor calculation Mario Bălănică
2021-04-03 7:36 ` Ard Biesheuvel
2021-04-03 12:47 ` Mario Bălănică
2021-04-03 14:35 ` Pete Batard
2021-04-03 15:17 ` Mario Bălănică [this message]
2021-04-03 16:01 ` [edk2-devel] " Pete Batard
2021-04-03 16:15 ` Mario Bălănică
2021-04-03 16:48 ` Pete Batard
2021-04-03 16:55 ` Mario Bălănică
2021-04-03 17:32 ` Mario Bălănică
2021-04-03 18:11 ` Pete Batard
2021-04-03 22:45 ` Mario Bălănică
2021-04-06 11:48 ` Pete Batard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31669.1617463027621445802@groups.io \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox