From: "Mario Bălănică" <mariobalanica02@gmail.com>
To: Pete Batard <pete@akeo.ie>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RaspberryPi: Fix mini UART baud divisor calculation
Date: Sat, 03 Apr 2021 15:45:48 -0700 [thread overview]
Message-ID: <31669.1617489948158034796@groups.io> (raw)
In-Reply-To: <60eb0e3a-7c4b-a860-6e06-ac086c58b2dc@akeo.ie>
[-- Attachment #1: Type: text/plain, Size: 689 bytes --]
Okay, I've tested the patch with the firmware from the commit mentioned above and it doesn't work. The VPU clock divisor bit needs PcdSerialClockRate to be set to 1 GHz (so that the quotient becomes equal to the core clock).
The mailbox on the other hand always returns 200 MHz for the core clock. This is definitely a bug, which got fixed it in a later commit.
There isn't any reliable way to support the firmwares with a broken mailbox interface as well in this case, and I really doubt anyone would want to use them with the UEFI in the first place. Your build scripts always include the latest version.
I can resend the patch with a more detailed commit message if you wish.
[-- Attachment #2: Type: text/html, Size: 719 bytes --]
next prev parent reply other threads:[~2021-04-03 22:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 17:51 [edk2-platforms][PATCH 1/1] Platform/RaspberryPi: Fix mini UART baud divisor calculation Mario Bălănică
2021-04-03 7:36 ` Ard Biesheuvel
2021-04-03 12:47 ` Mario Bălănică
2021-04-03 14:35 ` Pete Batard
2021-04-03 15:17 ` [edk2-devel] " Mario Bălănică
2021-04-03 16:01 ` Pete Batard
2021-04-03 16:15 ` Mario Bălănică
2021-04-03 16:48 ` Pete Batard
2021-04-03 16:55 ` Mario Bălănică
2021-04-03 17:32 ` Mario Bălănică
2021-04-03 18:11 ` Pete Batard
2021-04-03 22:45 ` Mario Bălănică [this message]
2021-04-06 11:48 ` Pete Batard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31669.1617489948158034796@groups.io \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox