From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RaspberryPi: Fix mini UART baud divisor calculation To: Pete Batard ,devel@edk2.groups.io From: =?UTF-8?B?TWFyaW8gQsSDbMSDbmljxIM=?= X-Originating-Location: Constanța, Constanta, RO (5.14.158.154) X-Originating-Platform: Android Phone Samsung User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Sat, 03 Apr 2021 15:45:48 -0700 References: <60eb0e3a-7c4b-a860-6e06-ac086c58b2dc@akeo.ie> In-Reply-To: <60eb0e3a-7c4b-a860-6e06-ac086c58b2dc@akeo.ie> Message-ID: <31669.1617489948158034796@groups.io> Content-Type: multipart/alternative; boundary="TcrIZPTaKR75sH0PYYND" --TcrIZPTaKR75sH0PYYND Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Okay, I've tested the patch with the firmware from the commit mentioned abo= ve and it doesn't work. The VPU clock divisor bit needs PcdSerialClockRate = to be set to 1 GHz (so that the quotient becomes equal to the core clock). The mailbox on the other hand always returns 200 MHz for the core clock. T= his is definitely a bug, which got fixed it in a later commit. There isn't any reliable way to support the firmwares with a broken mailbo= x interface as well in this case, and I really doubt anyone would want to u= se them with the UEFI in the first place. Your build scripts always include= the latest version. I can resend the patch with a more detailed commit message if you wish. --TcrIZPTaKR75sH0PYYND Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Okay, I've tested the patch with the firmware from the commit mentioned abo= ve and it doesn't work. The VPU clock divisor bit needs PcdSerialClockRate = to be set to 1 GHz (so that the quotient becomes equal to the core clock).&= nbsp;

The mailbox on the other hand always returns 200 MHz for t= he core clock. This is definitely a bug, which got fixed it in a later comm= it.

There isn't any reliable way to support the firmwares with a= broken mailbox interface as well in this case, and I really doubt anyone w= ould want to use them with the UEFI in the first place. Your build scripts = always include the latest version.

I can resend the patch with a= more detailed commit message if you wish. --TcrIZPTaKR75sH0PYYND--