From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Vikas Singh <vikas.singh@puresoftware.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH v1 2/2] Platform/NXP: Add OEM specific DSDT generator
Date: Mon, 25 Jan 2021 13:41:13 -0800 [thread overview]
Message-ID: <317.1611610873694713323@groups.io> (raw)
In-Reply-To: <1610969261-24134-3-git-send-email-vikas.singh@puresoftware.com>
[-- Attachment #1: Type: text/plain, Size: 601 bytes --]
Hi Vikas,
On Mon, Jan 18, 2021 at 09:06 AM, Vikas Singh wrote:
>
> + // Add the dsdt aml code here, Currently NULL place holder.
> + *Table = (EFI_ACPI_DESCRIPTION_HEADER *)&dsdt_aml_code;
Do you intend to process the DSDT data in this generator? If that is not the case, and you want to just collate the DSDT information, then an OEM specific RAW generator is not needed.
You could try implementing a library that implements a function to return ' dsdt_aml_code '. The Configuration Manager can then invoke this function from InitializePlatformRepository().
Regards,
Sami Mujawar
[-- Attachment #2: Type: text/html, Size: 723 bytes --]
next prev parent reply other threads:[~2021-01-25 21:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 11:27 [PATCH v1 0/2] Dynamic ACPI framework for fsl layerscape platforms vikas.singh
2021-01-18 11:27 ` [PATCH v1 1/2] Platform/NXP: Add Dynamic Acpi for " Vikas Singh
2021-01-18 11:27 ` [PATCH v1 2/2] Platform/NXP: Add OEM specific DSDT generator Vikas Singh
2021-01-25 21:41 ` Sami Mujawar [this message]
2021-01-26 5:53 ` [edk2-devel] " Vikas Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=317.1611610873694713323@groups.io \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox