From mboxrd@z Thu Jan  1 00:00:00 1970
Subject: Re: [edk2-devel] [PATCH v1 2/2] Platform/NXP: Add OEM specific DSDT generator
To: Vikas Singh <vikas.singh@puresoftware.com>,devel@edk2.groups.io
From: "Sami Mujawar" <sami.mujawar@arm.com>
X-Originating-Location: GB (217.140.99.251)
X-Originating-Platform: Windows Firefox 84
User-Agent: GROUPS.IO Web Poster
MIME-Version: 1.0
Date: Mon, 25 Jan 2021 13:41:13 -0800
References: <1610969261-24134-3-git-send-email-vikas.singh@puresoftware.com>
In-Reply-To: <1610969261-24134-3-git-send-email-vikas.singh@puresoftware.com>
Message-ID: <317.1611610873694713323@groups.io>
Content-Type: multipart/alternative; boundary="e9aMQPNM4H007fNpsQOl"

--e9aMQPNM4H007fNpsQOl
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Vikas,

On Mon, Jan 18, 2021 at 09:06 AM, Vikas Singh wrote:

>=20
> + // Add the dsdt aml code here, Currently NULL place holder.
> + *Table =3D (EFI_ACPI_DESCRIPTION_HEADER *)&dsdt_aml_code;

Do you intend to process the DSDT data in this generator? If that is not t=
he case, and you want to just collate the DSDT information, then an OEM spe=
cific RAW generator is not needed.
You could try implementing a library that implements a function to return =
' dsdt_aml_code '. The Configuration Manager can then invoke this function =
from InitializePlatformRepository().

Regards,

Sami Mujawar

--e9aMQPNM4H007fNpsQOl
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Vikas,<br /><br />On Mon, Jan 18, 2021 at 09:06 AM, Vikas Singh wrote:<b=
r />
<blockquote>+ // Add the dsdt aml code here, Currently NULL place holder.<=
br />+ *Table =3D (EFI_ACPI_DESCRIPTION_HEADER *)&amp;dsdt_aml_code;</block=
quote>
Do you intend to process the DSDT data in this generator? If that is not t=
he case, and you want to just collate the DSDT information, then an OEM spe=
cific RAW generator is not needed.<br />You could try implementing a librar=
y that implements a function to return '<span id=3D"main">dsdt_aml_code</sp=
an>'. <span style=3D"mso-spacerun: yes;">&nbsp;</span>The Configuration Man=
ager can then invoke this function from InitializePlatformRepository().<br =
/><br />Regards,<br /><br />Sami Mujawar

--e9aMQPNM4H007fNpsQOl--