From: "Rebecca Cran" <rebecca@bsdio.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: devel@edk2.groups.io, Liming Gao <gaoliming@byosoft.com.cn>,
Bob Feng <bob.c.feng@intel.com>,
Yuwei Chen <yuwei.chen@intel.com>
Subject: Re: [edk2-stable202305 PATCH 1/1] BaseTools: Revert Set the CLANGDWARF OBJCOPY path in tools_def.template
Date: Wed, 10 May 2023 06:46:17 -0600 [thread overview]
Message-ID: <3173f4a8-5079-ac73-7ce2-1802152a14f1@bsdio.com> (raw)
In-Reply-To: <CAMj1kXGpWmpGd0mZTEU-OLcFCAmPE=KCo7Z6kyYnLKeffJwX7g@mail.gmail.com>
On 5/10/23 06:37, Ard Biesheuvel wrote:
> On Wed, 10 May 2023 at 14:31, Rebecca Cran <rebecca@bsdio.com> wrote:
>> This reverts commit 11f62f4cc09f16d265da1a737dabfd8ed65f8c00.
>>
>> While GCC uses objcopy for the OBJCOPY command, it's not needed for the
>> CLANGDWARF toolchain and can be left as echo.
>>
> Are you sure you want to change this for IA32 and X86 as well? I'm not
> sure what the significance is, I suppose it sets the debuglink on the
> copies of the dll files?
Looking back to the tools_def.template from edk2-stable202302, we set
OBJCOPY_PATH for CLANG38 IA32 and X64, but not for CLANGPDB or CLANGDWARF.
I was thinking it's safer to keep existing behavior for now.
--
Rebecca Cran
next prev parent reply other threads:[~2023-05-10 12:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 12:31 [edk2-stable202305 PATCH 1/1] BaseTools: Revert Set the CLANGDWARF OBJCOPY path in tools_def.template Rebecca Cran
2023-05-10 12:36 ` Rebecca Cran
2023-05-10 12:37 ` Ard Biesheuvel
2023-05-10 12:46 ` Rebecca Cran [this message]
2023-05-10 13:51 ` Ard Biesheuvel
2023-05-10 14:49 ` Rebecca Cran
2023-05-11 0:53 ` [edk2-devel] " Michael D Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3173f4a8-5079-ac73-7ce2-1802152a14f1@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox