From: "Sean" <sean.brogan@microsoft.com>
To: Laszlo Ersek <lersek@redhat.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH v1 2/6] ArmVirtPkg: Add Platform CI and configuration for Core CI
Date: Wed, 15 Apr 2020 13:38:03 -0700 [thread overview]
Message-ID: <31845.1586983083124497540@groups.io> (raw)
In-Reply-To: <3e0cfe33-c972-9bdd-5db5-25c52a720823@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1295 bytes --]
On Wed, Apr 15, 2020 at 10:18 AM, Laszlo Ersek wrote:
>
> ArmVirtPkg/ArmVirtPkg.ci.yaml
> ArmVirtPkg/PlatformCI/Ubuntu-GCC5.yml
> ArmVirtPkg/PlatformCI/PlatformBuild.py
> ArmVirtPkg/PlatformCI/README-pytools.md
> ArmVirtPkg/PlatformCI/iasl_ext_dep.yaml
I am ok with the above except one thought on the readme. One nice thing about the markdown readme files are the badge shows up in github when you view the package. This is a quick and easy way to see the current status.
* Ovmf has a pretty stale readme and does not take advantage of markdown. We could convert it to MD, clean up, and then merge in the content from the pytools.md. I would need help or a package maintainer to do the cleanup of the readme to make sure it contained the content you desired.
* ArmVirtPkg doesn't have a readme and this is definitely a barrier to entry for the package. I would suggest creating one and then merging in the content from the pytools.md.
* EmulatorPkg has one. I would just suggest a merge but i am yet to get any feedback from those maintainers.
If that isn't desirable i would at least suggest we change the title to just ReadMe.md so that GitHub shows it by default when the PaltformCI folder is viewed form the web or in editor like vscode.
Thanks
Sean
[-- Attachment #2: Type: text/html, Size: 1460 bytes --]
next prev parent reply other threads:[~2020-04-15 20:38 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200408181327.4324-1-michael.kubacki@outlook.com>
2020-04-08 18:13 ` [PATCH v1 1/6] .azurepipelines: Add Platform CI template Michael Kubacki
2020-04-08 18:13 ` [PATCH v1 2/6] ArmVirtPkg: Add Platform CI and configuration for Core CI Michael Kubacki
2020-04-09 6:47 ` Laszlo Ersek
2020-04-09 8:05 ` Ard Biesheuvel
2020-04-09 19:57 ` [edk2-devel] " Sean
2020-04-15 6:55 ` Sean
2020-04-15 16:57 ` Laszlo Ersek
2020-04-15 19:31 ` Sean
2020-04-16 15:12 ` Laszlo Ersek
2020-04-15 17:18 ` Laszlo Ersek
2020-04-15 17:26 ` Ard Biesheuvel
2020-04-15 20:38 ` Sean [this message]
2020-04-16 14:51 ` Laszlo Ersek
2020-04-09 9:17 ` Laszlo Ersek
2020-04-09 9:23 ` Leif Lindholm
2020-04-09 13:18 ` Laszlo Ersek
2020-04-09 14:38 ` Leif Lindholm
2020-04-09 17:09 ` Michael Kubacki
2020-04-08 18:13 ` [PATCH v1 3/6] EmulatorPkg: " Michael Kubacki
2020-04-15 19:36 ` [edk2-devel] " Sean
2020-04-08 18:13 ` [PATCH v1 4/6] OvmfPkg: " Michael Kubacki
2020-04-09 9:17 ` Laszlo Ersek
2020-04-08 18:13 ` [PATCH v1 5/6] .pytool: Update CI Settings to support Emulator, ArmVirt, and Ovmf packages Michael Kubacki
2020-04-08 18:13 ` [PATCH v1 6/6] .azurepipelines: Update Core CI build matrix to include platforms Michael Kubacki
2020-04-19 8:29 [edk2-devel] [PATCH v1 2/6] ArmVirtPkg: Add Platform CI and configuration for Core CI Sean
2020-04-19 9:35 ` Ard Biesheuvel
2020-04-20 10:30 ` Laszlo Ersek
2020-04-19 20:56 ` Rebecca Cran
2020-04-20 11:08 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31845.1586983083124497540@groups.io \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox