* [PATCH] DynamicTablesPkg: SSDT _LPI revision is incorrect
@ 2022-11-15 18:01 Jeff Brasen
2022-11-18 8:12 ` PierreGondois
2022-12-14 15:24 ` Sami Mujawar
0 siblings, 2 replies; 4+ messages in thread
From: Jeff Brasen @ 2022-11-15 18:01 UTC (permalink / raw)
To: devel
Cc: quic_llindhol, ardb+tianocore, Sami.Mujawar, Alexei.Fedorov,
pierre.gondois, Jeff Brasen
_LPI Revision should be 0 per the ACPI 6.5 specification.
"The revision number of the _LPI object. Current revision is 0."
Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
---
.../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
index d06c7615fb..91199c4af2 100644
--- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
+++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
@@ -482,7 +482,7 @@ GenerateLpiStates (
}
// We do not support the LevelId field for now, let it to 0.
- Status = AmlCreateLpiNode (AslName, 1, 0, ScopeNode, &LpiNode);
+ Status = AmlCreateLpiNode (AslName, 0, 0, ScopeNode, &LpiNode);
if (EFI_ERROR (Status)) {
ASSERT (0);
return Status;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] DynamicTablesPkg: SSDT _LPI revision is incorrect
2022-11-15 18:01 [PATCH] DynamicTablesPkg: SSDT _LPI revision is incorrect Jeff Brasen
@ 2022-11-18 8:12 ` PierreGondois
2022-12-14 15:24 ` Sami Mujawar
1 sibling, 0 replies; 4+ messages in thread
From: PierreGondois @ 2022-11-18 8:12 UTC (permalink / raw)
To: Jeff Brasen, devel
Cc: quic_llindhol, ardb+tianocore, Sami.Mujawar, Alexei.Fedorov
Hello Jeff,
The Lpi version should effectively be 0:
Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
Regards,
Pierre
On 11/15/22 19:01, Jeff Brasen wrote:
> _LPI Revision should be 0 per the ACPI 6.5 specification.
> "The revision number of the _LPI object. Current revision is 0."
>
> Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
> ---
> .../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
> index d06c7615fb..91199c4af2 100644
> --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
> +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
> @@ -482,7 +482,7 @@ GenerateLpiStates (
> }
>
> // We do not support the LevelId field for now, let it to 0.
> - Status = AmlCreateLpiNode (AslName, 1, 0, ScopeNode, &LpiNode);
> + Status = AmlCreateLpiNode (AslName, 0, 0, ScopeNode, &LpiNode);
> if (EFI_ERROR (Status)) {
> ASSERT (0);
> return Status;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] DynamicTablesPkg: SSDT _LPI revision is incorrect
2022-11-15 18:01 [PATCH] DynamicTablesPkg: SSDT _LPI revision is incorrect Jeff Brasen
2022-11-18 8:12 ` PierreGondois
@ 2022-12-14 15:24 ` Sami Mujawar
2022-12-14 15:55 ` [edk2-devel] " Sami Mujawar
1 sibling, 1 reply; 4+ messages in thread
From: Sami Mujawar @ 2022-12-14 15:24 UTC (permalink / raw)
To: Jeff Brasen, devel
Cc: quic_llindhol, ardb+tianocore, Alexei.Fedorov, pierre.gondois,
nd@arm.com
Hi Jeff,
Apologies for the delay and thank you for this fix.
This change looks good to me.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
On 15/11/2022 06:01 pm, Jeff Brasen wrote:
> _LPI Revision should be 0 per the ACPI 6.5 specification.
> "The revision number of the _LPI object. Current revision is 0."
>
> Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
> ---
> .../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
> index d06c7615fb..91199c4af2 100644
> --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
> +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
> @@ -482,7 +482,7 @@ GenerateLpiStates (
> }
>
> // We do not support the LevelId field for now, let it to 0.
> - Status = AmlCreateLpiNode (AslName, 1, 0, ScopeNode, &LpiNode);
> + Status = AmlCreateLpiNode (AslName, 0, 0, ScopeNode, &LpiNode);
> if (EFI_ERROR (Status)) {
> ASSERT (0);
> return Status;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH] DynamicTablesPkg: SSDT _LPI revision is incorrect
2022-12-14 15:24 ` Sami Mujawar
@ 2022-12-14 15:55 ` Sami Mujawar
0 siblings, 0 replies; 4+ messages in thread
From: Sami Mujawar @ 2022-12-14 15:55 UTC (permalink / raw)
To: Sami Mujawar, devel
[-- Attachment #1: Type: text/plain, Size: 77 bytes --]
Merged as d103840cfb55..916825b84f23
Thanks.
Regards,
Sami Mujawar
[-- Attachment #2: Type: text/html, Size: 101 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-12-14 15:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-15 18:01 [PATCH] DynamicTablesPkg: SSDT _LPI revision is incorrect Jeff Brasen
2022-11-18 8:12 ` PierreGondois
2022-12-14 15:24 ` Sami Mujawar
2022-12-14 15:55 ` [edk2-devel] " Sami Mujawar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox