public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: Eric Dong <eric.dong@intel.com>, devel@edk2.groups.io
Cc: Ray Ni <ray.ni@intel.com>,
	Chandana Kumar <chandana.c.kumar@intel.com>,
	Star Zeng <star.zeng@intel.com>
Subject: Re: [Patch 0/2] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls gBS service.
Date: Sat, 13 Jul 2019 00:16:29 +0200	[thread overview]
Message-ID: <319deb8d-30f9-57f8-9407-8c199bdd378d@redhat.com> (raw)
In-Reply-To: <20190712015308.26492-1-eric.dong@intel.com>

On 07/12/19 03:53, Eric Dong wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1972
> 
> AP calls CollectProcessorData() to collect processor info.
> CollectProcessorData function finally calls PcdGetSize function to
> get DynamicPCD PcdCpuFeaturesSetting value. PcdGetSize will use gBS
> which caused ASSERT. 
> This patch serial fixes the issue and enhances the related code to avoid
> later report this issue again.
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Chandana Kumar <chandana.c.kumar@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> 
> Eric Dong (2):
>   UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls gBS service.
>   UefiCpuPkg/Library/RegisterCpuFeaturesLib: avoid use dynamic PCD.
> 
>  .../CpuFeaturesInitialize.c                   |  77 ++++++-------
>  .../RegisterCpuFeatures.h                     |  10 +-
>  .../RegisterCpuFeaturesLib.c                  | 109 +++++++-----------
>  3 files changed, 85 insertions(+), 111 deletions(-)
> 

Will have to skip this one too.

Thanks
Laszlo

      parent reply	other threads:[~2019-07-12 22:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-12  1:53 [Patch 0/2] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls gBS service Dong, Eric
2019-07-12  1:53 ` [Patch 1/2] " Dong, Eric
2019-07-12 10:53   ` Zeng, Star
2019-07-15  4:59     ` Ni, Ray
2019-07-12  1:53 ` [Patch 2/2] UefiCpuPkg/Library/RegisterCpuFeaturesLib: avoid use dynamic PCD Dong, Eric
2019-07-12 11:10   ` [edk2-devel] " Zeng, Star
2019-07-15  4:57   ` Ni, Ray
2019-07-15  7:04     ` Dong, Eric
2019-07-12 22:16 ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=319deb8d-30f9-57f8-9407-8c199bdd378d@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox