From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Fri, 12 Jul 2019 15:16:32 -0700
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id AA5B730C34CD;
	Fri, 12 Jul 2019 22:16:31 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-65.ams2.redhat.com [10.36.116.65])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 5F9F160BFB;
	Fri, 12 Jul 2019 22:16:30 +0000 (UTC)
Subject: Re: [Patch 0/2] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls gBS service.
To: Eric Dong <eric.dong@intel.com>, devel@edk2.groups.io
Cc: Ray Ni <ray.ni@intel.com>, Chandana Kumar <chandana.c.kumar@intel.com>,
 Star Zeng <star.zeng@intel.com>
References: <20190712015308.26492-1-eric.dong@intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <319deb8d-30f9-57f8-9407-8c199bdd378d@redhat.com>
Date: Sat, 13 Jul 2019 00:16:29 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190712015308.26492-1-eric.dong@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Fri, 12 Jul 2019 22:16:31 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 07/12/19 03:53, Eric Dong wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1972
> 
> AP calls CollectProcessorData() to collect processor info.
> CollectProcessorData function finally calls PcdGetSize function to
> get DynamicPCD PcdCpuFeaturesSetting value. PcdGetSize will use gBS
> which caused ASSERT. 
> This patch serial fixes the issue and enhances the related code to avoid
> later report this issue again.
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Chandana Kumar <chandana.c.kumar@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> 
> Eric Dong (2):
>   UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls gBS service.
>   UefiCpuPkg/Library/RegisterCpuFeaturesLib: avoid use dynamic PCD.
> 
>  .../CpuFeaturesInitialize.c                   |  77 ++++++-------
>  .../RegisterCpuFeatures.h                     |  10 +-
>  .../RegisterCpuFeaturesLib.c                  | 109 +++++++-----------
>  3 files changed, 85 insertions(+), 111 deletions(-)
> 

Will have to skip this one too.

Thanks
Laszlo