From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id AF164D811F6 for ; Thu, 15 Feb 2024 16:07:43 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Aq3Rryz3kJgEu23nGfGbUHT/9XdpEut+wAJ7karPDKc=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:CC:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708013262; v=1; b=OWrko+ejKdW5Z3JNrK3Nbgqf/WFH3x9GOdc/GA3TWqf32/WyU9H2nmpoN10NWA2d4iIUSeuL DciG0azEPvOOsUpSsMgifwAllQpduU88PWoGGp8N4HBxyZIEkWWp1K13vFiu4UcVsJ+cxqLLgwx 9xvHERATClfpl+FIKyyUoFew= X-Received: by 127.0.0.2 with SMTP id 1lTYYY7687511xPz6KW5HC8h; Thu, 15 Feb 2024 08:07:42 -0800 X-Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web11.17842.1708013261519214809 for ; Thu, 15 Feb 2024 08:07:41 -0800 X-Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41F7P0BD004167; Thu, 15 Feb 2024 16:07:27 GMT X-Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3w9bfs1jaf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Feb 2024 16:07:27 +0000 (GMT) X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 41FG7QkT014546 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Feb 2024 16:07:26 GMT X-Received: from [10.111.132.103] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Thu, 15 Feb 2024 08:07:23 -0800 Message-ID: <31a69f92-5b20-4854-a8e5-df44aaec65bc@quicinc.com> Date: Thu, 15 Feb 2024 16:07:20 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: =?UTF-8?B?UmU6IFtlZGsyLWRldmVsXSDlm57lpI06IFtlZGsyLXN0YWJsZTIwMjQwMl0gW1BBVENIIHY1IDEvMV0gTWRlTW9kdWxlUGtnL0FjcGlUYWJsZUR4ZTogUHJlZmVyIHhEU0RUIG92ZXIgRFNEVCB3aGVuIGluc3RhbGxpbmcgdGFibGVz?= To: Dhaval Sharma CC: , , , , , , Laszlo Ersek , Andrew Fish , References: <20240128134816.236973-1-dhaval@rivosinc.com> <20240128134816.236973-2-dhaval@rivosinc.com> <17AEFB5BFEE74D09.16647@groups.io> <01d001da5fb0$1e84e680$5b8eb380$@byosoft.com.cn> <14daf675-5076-4e64-8a24-8f30f2c44dbf@quicinc.com> From: "Leif Lindholm" In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-ORIG-GUID: wZOvJ7eVFlWmqFiYBzr0jd9g0EF2kn3B X-Proofpoint-GUID: wZOvJ7eVFlWmqFiYBzr0jd9g0EF2kn3B X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-0031df01.pphosted.com id 41F7P0BD004167 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: PbWj5tGIoResgfMeZF6vLjrRx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=OWrko+ej; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none) Excellent, thank you. And it will still go in within the next few weeks, just not before we=20 make the stable tag. / Leif On 2024-02-15 10:40, Dhaval Sharma wrote: > For me it is not impacting a production system so I can wait a cycle=20 > more. @Liming Gao =C2=A0I will send out = the=20 > PR with your rb tag. >=20 > On Thu, Feb 15, 2024 at 3:26=E2=80=AFPM Leif Lindholm > wrote: >=20 > Hi Liming, >=20 > On 2024-02-15 01:41, gaoliming via groups.io wrote= : > > Hi, all > >=C2=A0 =C2=A0This patch was reviewed before soft feature freeze. I = would > like to merge > > it for this stable tag. If you have any comments, please reply > this mail. >=20 > I agree this is a bugfix, but the criterion for hard freeze is suppos= ed > to be *critical* bugfix. By definition this is a very invasive change > for systems where it has any effect. So I would feel more > comfortable if > it had more time before going into a stable tag. >=20 > Dhaval, how critical is this fix for you? Are you OK for it to go in > after stable tag? >=20 > Regards, >=20 > Leif >=20 >=20 > > Thanks > > Liming > >> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > >> =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > > =E4=BB=A3=E8=A1= =A8 gaoliming via > >> groups.io > >> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B41=E6=9C=8830= =E6=97=A5 9:21 > >> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io ; > dhaval@rivosinc.com > >> =E6=8A=84=E9=80=81: zhiguang.liu@intel.com ; > dandan.bi@intel.com ; > >> pedro.falcato@gmail.com ; > chasel.chiu@intel.com > >> =E4=B8=BB=E9=A2=98: =E5=9B=9E=E5=A4=8D: [edk2-devel] [PATCH v5 1/= 1] MdeModulePkg/AcpiTableDxe: > >> Prefer xDSDT over DSDT when installing tables > >> > >> This version is good to me. Reviewed-by: Liming Gao > >> > > >> > >>> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > >>> =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > > =E4=BB=A3=E8=A1= =A8 Dhaval > >>> Sharma > >>> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B41=E6=9C=8828= =E6=97=A5 21:39 > >>> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > >>> =E6=8A=84=E9=80=81: gaoliming@byosoft.com.cn > ; zhiguang.liu@intel.com > ; > >>> dandan.bi@intel.com ; > pedro.falcato@gmail.com ; > chasel.chiu@intel.com > >>> =E4=B8=BB=E9=A2=98: [edk2-devel] [PATCH v5 1/1] MdeModulePkg/Acp= iTableDxe: Prefer > >>> xDSDT over DSDT when installing tables > >>> > >>> As per ACPI Spec 6.5+ Table 5-9 if xDSDT is available, > >>> it should be used first. Handle required flow when xDSDT > >>> is absent or present. > >>> > >>> Test: Tested on RISCV64 Qemu platform with xDSDT and booted to > >>> linux kernel. > >>> > >>> Cc: Liming Gao > >>> Cc: Zhiguang Liu > >>> Cc: Dandan Bi > >>> Cc: Pedro Falcato > >>> Cc: devel@edk2.groups.io > >>> Signed-off-by: Dhaval Sharma > >>> Acked-by: Chasel Chiu > >>> --- > >>> > >>> Notes: > >>>=C2=A0 =C2=A0 =C2=A0 v5: > >>>=C2=A0 =C2=A0 =C2=A0 - If DSDT is not found, throw error and cont= inue to build > other > > tables > >>>=C2=A0 =C2=A0 =C2=A0 v4: > >>>=C2=A0 =C2=A0 =C2=A0 - Fix typos and commit message adding more c= larity to > patch subject > >>>=C2=A0 =C2=A0 =C2=A0 v3: > >>>=C2=A0 =C2=A0 =C2=A0 - Added description of ACPI spec clarificati= on based on > which this > >> patch is > >>> created > >>>=C2=A0 =C2=A0 =C2=A0 - Optimizing if-else flow > >>>=C2=A0 =C2=A0 =C2=A0 v2: > >>>=C2=A0 =C2=A0 =C2=A0 - Added proper indentation for else if > >>> > >>>=C2=A0 =C2=A0MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTablePr= otocol.c | 24 > >>> ++++++++++++++------ > >>>=C2=A0 =C2=A01 file changed, 17 insertions(+), 7 deletions(-) > >>> > >>> diff --git > >> a/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c > >>> b/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c > >>> index e09bc9b704f5..3879e10b3349 100644 > >>> --- a/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol= .c > >>> +++ b/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol= .c > >>> @@ -1892,14 +1892,24 @@ InstallAcpiTableFromHob ( > >>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0} > >>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0} > >>> > >>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (((EFI_ACPI_3_0_FIXED_ACPI_DESCR= IPTION_TABLE > >>> *)ChildTable)->Dsdt !=3D 0) { > >>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 // > >>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 // First check if xDSDT is availabl= e, as that is > preferred as > > per > >>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 // ACPI Spec 6.5+ Table 5-9 X_DSDT = definition > >>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 // > >>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (((EFI_ACPI_3_0_FIXED_ACPI_DESCR= IPTION_TABLE > >>> *)ChildTable)->XDsdt !=3D 0) { > >>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 TableToInstall =3D (VOID > >>> *)(UINTN)((EFI_ACPI_3_0_FIXED_ACPI_DESCRIPTION_TABLE > >>> *)ChildTable)->XDsdt; > >>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 } else if (((EFI_ACPI_3_0_FIXED_ACP= I_DESCRIPTION_TABLE > >>> *)ChildTable)->Dsdt !=3D 0) { > >>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0TableToInstall = =3D (VOID > >>> *)(UINTN)((EFI_ACPI_3_0_FIXED_ACPI_DESCRIPTION_TABLE > >>> *)ChildTable)->Dsdt; > >>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Status=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0=3D AddTableToList (AcpiTableInstance, > >>> TableToInstall, TRUE, Version, TRUE, &TableKey); > >>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (EFI_ERROR (Status)) { > >>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 DEBUG ((DEBUG_ERROR, = "InstallAcpiTableFromHob: Fail to > >>> add ACPI table DSDT\n")); > >>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ASSERT_EFI_ERROR (Sta= tus); > >>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 break; > >>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 } > >>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 } else { > >>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 DEBUG ((DEBUG_ERROR, "DSDT t= able not found\n")); > >>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 continue; > >>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 } > >>> + > >>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 Status =3D AddTableToList (AcpiTabl= eInstance, > TableToInstall, > > TRUE, > >>> Version, TRUE, &TableKey); > >>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (EFI_ERROR (Status)) { > >>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 DEBUG ((DEBUG_ERROR, "Instal= lAcpiTableFromHob: Fail to > >> add > >>> ACPI table DSDT\n")); > >>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ASSERT_EFI_ERROR (Status); > >>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 break; > >>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0} > >>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0} > >>>=C2=A0 =C2=A0 =C2=A0 =C2=A0} > >>> -- > >>> 2.39.2 > >>> > >>> > >>> > >>> > >>> > >> > >> > >> > >> > >> > >> > >> > > > > > > > > > > > >=20 > > > > >=20 >=20 >=20 > --=20 > Thanks! > =3DD -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115525): https://edk2.groups.io/g/devel/message/115525 Mute This Topic: https://groups.io/mt/104365766/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-