From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.85.128.67; helo=mail-wm1-f67.google.com; envelope-from=philmd@redhat.com; receiver=edk2-devel@lists.01.org Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8F10B209831C1 for ; Tue, 6 Nov 2018 11:37:44 -0800 (PST) Received: by mail-wm1-f67.google.com with SMTP id 124-v6so7142900wmw.0 for ; Tue, 06 Nov 2018 11:37:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4Fo5k9/SCD3FMeQ85QpiRF9p+4G1d5nv0PdtnE0UmYE=; b=Jqd7VZz1wnsD0we2MEt2cFQfKC1vmA79IpPd1ANzHXg8zo6OmVs7Dnk3LbY+dggrTl X0IKpcFJk6z10zpp8TVIJLH1wc8ff81eKkrBxlOnffoRjwnp/SQEnEkJIa9v65TVe2dI 0XJY5mYZnUnQRd40Bj6LvJfI9Jxbz4WsLiET2r6XPuj9Xp0HmqJaA+Gkdkj++w1q9T0Y uSjM/p6wNwAE6KDFulX9JbsFj6aa2BF7QR1H1WggPMo4ssMlYkDXzQ3UeaDI4AR2/3sA zg3VAuyI4Nok/Cxo3ZEKPfXr3p2dnde1jClH/fuY7zSadIMurNm0Ghce1X+AL/QQkpl+ NYVA== X-Gm-Message-State: AGRZ1gK11Vqijq0PuNxbx2IZ0Fs6K/YQ+8NeAOtRgpoHaIksTqKWtgSO yBLszVW14w+aosq2AQRtX8RoGjvGTqg= X-Google-Smtp-Source: AJdET5euiK3lTxdh0g5hhf2Lah39/buCs8cnftneRJsxp9uJZdTqaifkH74Bll8tE0u8F4K5S8X/Vg== X-Received: by 2002:a1c:f60f:: with SMTP id w15-v6mr3301891wmc.101.1541533063073; Tue, 06 Nov 2018 11:37:43 -0800 (PST) Received: from [192.168.1.74] (67.23.27.109.rev.sfr.net. [109.27.23.67]) by smtp.gmail.com with ESMTPSA id h18-v6sm30482608wro.0.2018.11.06.11.37.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 11:37:42 -0800 (PST) To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: michael.d.kinney@intel.com, eric.jin@intel.com References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> <20181106175833.26964-5-ard.biesheuvel@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <31c829f0-bdc1-0963-1ab1-9069783c8bd2@redhat.com> Date: Tue, 6 Nov 2018 20:37:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181106175833.26964-5-ard.biesheuvel@linaro.org> Subject: Re: [PATCH edk2-staging 04/19] IntelUndiPkg/GigUndiDxe: consistently use forward slashes as path separators X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2018 19:37:44 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 6/11/18 18:58, Ard Biesheuvel wrote: > Replace backslashes in paths with forward slashes to be compatible with > non-Windows OSes. I thought the Windows format expected escaped backslashes... > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Philippe Mathieu-Daudé > --- > IntelUndiPkg/GigUndiDxe/Decode.c | 2 +- > IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 14 +++++++------- > IntelUndiPkg/GigUndiDxe/e1000_osdep.h | 4 ++-- > 3 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/IntelUndiPkg/GigUndiDxe/Decode.c b/IntelUndiPkg/GigUndiDxe/Decode.c > index 14060db0d050..9f8a5a8c1c81 100644 > --- a/IntelUndiPkg/GigUndiDxe/Decode.c > +++ b/IntelUndiPkg/GigUndiDxe/Decode.c > @@ -27,7 +27,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > ***************************************************************************/ > #include "e1000.h" > -#include > +#include > > /** This routine determines the operational state of the UNDI. It updates the state flags in the > Command Descriptor Block based on information derived from the GigAdapter instance data. > diff --git a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf > index 0e4462733df6..6c195872c00f 100644 > --- a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf > +++ b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf > @@ -115,13 +115,13 @@ AdapterInformation.c > AdapterInformation.h > Version.h > > -wol\wol.h > -wol\wol.c > -wol\wolimpl.h > -wol\wolimpl.c > -wol\wolfamily.c > -wol\wolinfo.c > -wol\wol_1G.c > +wol/wol.h > +wol/wol.c > +wol/wolimpl.h > +wol/wolimpl.c > +wol/wolfamily.c > +wol/wolinfo.c > +wol/wol_1G.c > > [sources.X64] > > diff --git a/IntelUndiPkg/GigUndiDxe/e1000_osdep.h b/IntelUndiPkg/GigUndiDxe/e1000_osdep.h > index 01c0843a2c9a..4408b409a445 100644 > --- a/IntelUndiPkg/GigUndiDxe/e1000_osdep.h > +++ b/IntelUndiPkg/GigUndiDxe/e1000_osdep.h > @@ -31,8 +31,8 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > #include > #include > -#include > -#include > +#include > +#include > > #pragma warning(disable : 4244) > #pragma warning(disable : 4206) >