From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Wed, 07 Aug 2019 05:39:38 -0700 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3F8418E59B; Wed, 7 Aug 2019 12:39:38 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (unknown [10.36.118.2]) by smtp.corp.redhat.com (Postfix) with ESMTP id A510610016E9; Wed, 7 Aug 2019 12:39:36 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 0/3] Enhance ESRT to support multiple controllers To: "Wu, Hao A" , "devel@edk2.groups.io" , "Jin, Eric" Cc: "Gao, Liming" , "Kinney, Michael D" , "afish@apple.com" , "leif.lindholm@linaro.org" References: <20190731145903.13820-1-eric.jin@intel.com> From: "Laszlo Ersek" Message-ID: <31d7426f-b10a-5ffd-cccd-960c32043b6e@redhat.com> Date: Wed, 7 Aug 2019 14:39:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 07 Aug 2019 12:39:38 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/05/19 08:19, Wu, Hao A wrote: >> -----Original Message----- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> Eric Jin >> Sent: Wednesday, July 31, 2019 10:59 PM >> To: devel@edk2.groups.io >> Subject: [edk2-devel] [PATCH 0/3] Enhance ESRT to support multiple >> controllers >> >> Multiple Controllers Support solution >> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1525 >> >> The patch set is to makes enhancement to the ESRT when multiple >> same controllers exist in one system. >> >> Eric Jin (3): >> MdeModulePkg/EsrtFmpDxe: Merge multiple FMP into ESRT >> MdeModulePkg/EsrtFmpDxe: Correct LastAttemptVersion algorithm in ESRT >> MdeModulePkg/EsrtFmpDxe: Detect duplicate GUID/HardwareInstance > > > Hello Eric, > > After looking into the series, I found that patches 2/3 & 3/3 are actually > addressing issues introduced by the 1/3 patch. It looks to me that these > 3 patches should be squashed into 1 commit, since they all focus on adding > a feature for ESRT to support multiple controllers. > > However, originally, the 3 separate commits come from the edk2-staging > repository, so I am not very sure what approach should be adopted when > merging them back to the edk2 repo master branch. > > (Includes the stewards here for suggestions.) > > My personal preference is to merge them together as one patch. Sorry about the late response. I certainly agree that a single patch series should avoid introducing a bug or esp. regression, just for another patch in the same series to fix it up. In that case, both halves indeed belong to a single patch. However, speaking generally (not knowing any specifics here), that doesn't mean that everything should be squashed into a single patch. The series (speaking generally) should still have a fine-grained structure; each patch should do as little, and as well isolated, as reasonably possible. Thanks Laszlo