From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@dell.com header.s=smtpout1 header.b=trVxDShY; spf=pass (domain: dell.com, ip: 148.163.137.20, mailfrom: jayanth.raghuram@dell.com) Received: from mx0b-00154904.pphosted.com (mx0b-00154904.pphosted.com [148.163.137.20]) by groups.io with SMTP; Mon, 26 Aug 2019 12:55:04 -0700 Received: from pps.filterd (m0170398.ppops.net [127.0.0.1]) by mx0b-00154904.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x7QJj24Z016713 for ; Mon, 26 Aug 2019 15:55:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dell.com; h=from : to : cc : subject : date : message-id : content-type : mime-version; s=smtpout1; bh=4ByteA/ysrmsQenr1iOwGbChnOoQ+LG/2uN29ZxAKfU=; b=trVxDShYyVYEQ53Mj3hTi+6Q0m9u83DVnnt1H0kLAlC8/WrtGdgRtuQzU/44fcha4WBl UDOG2XmsfSF+5XWeiBPlOt0HOFna4adrvyWsD/UaJ7ogJQULrewaGPeCg8NG+mj/9hhn SECO3zS2zvcPuQaVeQ6XBgGUpahgeTF4zL+xIgOmu+oXFlPMCEjyeoX2Lm2UDLMbbobW ucUYG7kVk3NbI8h2LFr4qOrJJ1QwmUJ6ig8EBJAgiq4cwnQklKbBF/BtRA8WksLos2s5 tjR43hHwOQztoHOrOQKTqGNAMIA4uJSk75CnPxDdnMiv+XIIDZXp9TfNoNzLH+Zkd3hs gw== Received: from mx0a-00154901.pphosted.com (mx0a-00154901.pphosted.com [67.231.149.39]) by mx0b-00154904.pphosted.com with ESMTP id 2uk2peg2ps-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 26 Aug 2019 15:55:01 -0400 Received: from pps.filterd (m0133268.ppops.net [127.0.0.1]) by mx0a-00154901.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x7QJsLJR018565 for ; Mon, 26 Aug 2019 15:55:01 -0400 Received: from ausc60pc101.us.dell.com (ausc60pc101.us.dell.com [143.166.85.206]) by mx0a-00154901.pphosted.com with ESMTP id 2ukjajgvcf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 26 Aug 2019 15:55:00 -0400 X-LoopCount0: from 10.166.132.133 X-PREM-Routing: D-Outbound X-IronPort-AV: E=Sophos;i="5.60,349,1549951200"; d="scan'208,217,223";a="1458166512" From: To: CC: Subject: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling. Thread-Topic: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling. Thread-Index: AdVcR+OPrxJmOcouRhWzA1r7t1m4TQ== Date: Mon, 26 Aug 2019 19:54:58 +0000 Message-ID: <31e5cee5c49d4381bfb26a0968c11749@ausx13mps324.AMER.DELL.COM> Accept-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: msip_labels: MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Enabled=True; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_SiteId=945c199a-83a2-4e80-9f8c-5a91be5752dd; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Owner=Jayanth_Raghuram@Dell.com; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_SetDate=2019-08-26T19:54:57.9112889Z; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Name=External Public; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Application=Microsoft Azure Information Protection; MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Extended_MSFT_Method=Manual; aiplabel=External Public x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.242.75] MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-08-26_08:2019-08-26,2019-08-26 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 clxscore=1011 mlxscore=0 suspectscore=0 priorityscore=1501 phishscore=0 bulkscore=0 impostorscore=0 adultscore=0 spamscore=0 mlxlogscore=241 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1906280000 definitions=main-1908260187 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 clxscore=1011 suspectscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 lowpriorityscore=0 mlxscore=0 mlxlogscore=378 spamscore=0 adultscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1906280000 definitions=main-1908260187 X-Groupsio-MsgNum: 46389 Content-Language: en-US Content-Type: multipart/mixed; boundary="_004_31e5cee5c49d4381bfb26a0968c11749ausx13mps324AMERDELLCOM_" --_004_31e5cee5c49d4381bfb26a0968c11749ausx13mps324AMERDELLCOM_ Content-Type: multipart/alternative; boundary="_000_31e5cee5c49d4381bfb26a0968c11749ausx13mps324AMERDELLCOM_" --_000_31e5cee5c49d4381bfb26a0968c11749ausx13mps324AMERDELLCOM_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Subject: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling. Added checks for return parameters of LocateHandleBuffer & GetSupportedType= s function calls in InternalHstiFindAip to improve error handling. An issue w= as observed on Dell Poweredge R740, where the Dell PERC H740P controller UEFI driver returned InfoTypesBuffer =3D NULL, InfoTypesBufferCount =3D 0 and ca= used an FreePool assert. Signed-off-by: Jayanth Raghuram Cc: Wei G Liu Attached: 0001-MdePkg-DxeHstiLib-Added-checks-to-improve-error-hand.patch Regards Jayanth Raghuram DellEMC | Server Platform BIOS office + 1 512 723 1470 --_000_31e5cee5c49d4381bfb26a0968c11749ausx13mps324AMERDELLCOM_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Subject: [PATCH] MdePkg/DxeHstiLib: Added checks to = improve error handling.

Added checks for return parameters of LocateHandleBu= ffer & GetSupportedTypes

function calls in InternalHstiFindAip to improve err= or handling. An issue was

observed on Dell Poweredge R740, where the Dell PERC= H740P controller UEFI

driver returned InfoTypesBuffer =3D NULL, InfoTypesB= ufferCount =3D 0 and caused

an FreePool assert.

 

Signed-off-by: Jayanth Raghuram <Jayanth.Raghuram= @Dell.com>

Cc: Wei G Liu <Wei_G_Liu@Dell.com><= /p>

 

Attached: 0001-MdePkg-DxeHstiLib-Added-checks-to-imp= rove-error-hand.patch

 

Regards

Jayanth Raghuram<= /o:p>

DellEMC | Server Platform BIOS

office + 1 512 723 1470

 

--_000_31e5cee5c49d4381bfb26a0968c11749ausx13mps324AMERDELLCOM_-- --_004_31e5cee5c49d4381bfb26a0968c11749ausx13mps324AMERDELLCOM_ Content-Type: application/octet-stream; name="0001-MdePkg-DxeHstiLib-Added-checks-to-improve-error-hand.patch" Content-Description: 0001-MdePkg-DxeHstiLib-Added-checks-to-improve-error-hand.patch Content-Disposition: attachment; filename="0001-MdePkg-DxeHstiLib-Added-checks-to-improve-error-hand.patch"; size=1643; creation-date="Mon, 26 Aug 2019 19:53:16 GMT"; modification-date="Mon, 26 Aug 2019 19:53:17 GMT" Content-Transfer-Encoding: base64 RnJvbSAzMDA2ZDA2ZmU0NjJmYzJhMThlODcyYjhiNjkwMDFkOGE3NGJiYjkzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpNZXNzYWdlLUlkOiA8MzAwNmQwNmZlNDYyZmMyYTE4ZTg3MmI4YjY5MDAx ZDhhNzRiYmI5My4xNTY2ODQ4NzMwLmdpdC5KYXlhbnRoX1JhZ2h1cmFtQERlbGwuY29tPgpGcm9t OiBKYXlhbnRoIFJhZ2h1cmFtIDxKYXlhbnRoX1JhZ2h1cmFtQERlbGwuY29tPgpEYXRlOiBNb24s IDI2IEF1ZyAyMDE5IDEzOjMzOjUyIC0wNTAwClN1YmplY3Q6IFtQQVRDSF0gTWRlUGtnL0R4ZUhz dGlMaWI6IEFkZGVkIGNoZWNrcyB0byBpbXByb3ZlIGVycm9yIGhhbmRsaW5nLgogQWRkZWQgY2hl Y2tzIGZvciByZXR1cm4gcGFyYW1ldGVycyBvZiBMb2NhdGVIYW5kbGVCdWZmZXIgJiBHZXRTdXBw b3J0ZWRUeXBlcwogZnVuY3Rpb24gY2FsbHMgaW4gSW50ZXJuYWxIc3RpRmluZEFpcCB0byBpbXBy b3ZlIGVycm9yIGhhbmRsaW5nLiBBbiBpc3N1ZSB3YXMKIG9ic2VydmVkIG9uIERlbGwgUG93ZXJl ZGdlIFI3NDAsIHdoZXJlIHRoZSBEZWxsIFBFUkMgSDc0MFAgY29udHJvbGxlciBVRUZJCiBkcml2 ZXIgcmV0dXJuZWQgSW5mb1R5cGVzQnVmZmVyID0gTlVMTCwgSW5mb1R5cGVzQnVmZmVyQ291bnQg PSAwIGFuZCBjYXVzZWQKIGFuIEZyZWVQb29sIGFzc2VydC4KClNpZ25lZC1vZmYtYnk6IEpheWFu dGggUmFnaHVyYW0gPEpheWFudGguUmFnaHVyYW1ARGVsbC5jb20+CkNjOiBXZWkgRyBMaXUgPFdl aV9HX0xpdUBEZWxsLmNvbT4KLS0tCiBNZGVQa2cvTGlicmFyeS9EeGVIc3RpTGliL0hzdGlEeGUu YyB8IDQgKystLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9NZGVQa2cvTGlicmFyeS9EeGVIc3RpTGliL0hzdGlEeGUuYyBiL01k ZVBrZy9MaWJyYXJ5L0R4ZUhzdGlMaWIvSHN0aUR4ZS5jCmluZGV4IDk0NjZlM2RjYjMuLjEwNGU5 ZDRhYWIgMTAwNjQ0Ci0tLSBhL01kZVBrZy9MaWJyYXJ5L0R4ZUhzdGlMaWIvSHN0aUR4ZS5jCisr KyBiL01kZVBrZy9MaWJyYXJ5L0R4ZUhzdGlMaWIvSHN0aUR4ZS5jCkBAIC01MSw3ICs1MSw3IEBA IEludGVybmFsSHN0aUZpbmRBaXAgKAogICAgICAgICAgICAgICAgICAgJk5vSGFuZGxlcywNCiAg ICAgICAgICAgICAgICAgICAmSGFuZGxlcw0KICAgICAgICAgICAgICAgICAgICk7DQotICBpZiAo RUZJX0VSUk9SIChTdGF0dXMpKSB7DQorICBpZiAoRUZJX0VSUk9SIChTdGF0dXMpIHx8IChIYW5k bGVzID09IE5VTEwpIHx8IChOb0hhbmRsZXMgPT0gMCkpIHsNCiAgICAgcmV0dXJuIE5VTEw7DQog ICB9DQogDQpAQCAtNzcsNyArNzcsNyBAQCBJbnRlcm5hbEhzdGlGaW5kQWlwICgKICAgICAgICAg ICAgICAgICAgICAgJkluZm9UeXBlc0J1ZmZlciwNCiAgICAgICAgICAgICAgICAgICAgICZJbmZv VHlwZXNCdWZmZXJDb3VudA0KICAgICAgICAgICAgICAgICAgICAgKTsNCi0gICAgaWYgKEVGSV9F UlJPUiAoU3RhdHVzKSkgew0KKyAgICBpZiAoRUZJX0VSUk9SIChTdGF0dXMpIHx8IChJbmZvVHlw ZXNCdWZmZXIgPT0gTlVMTCkgfHwgKEluZm9UeXBlc0J1ZmZlckNvdW50ID09IDApKSB7DQogICAg ICAgY29udGludWU7DQogICAgIH0NCiANCi0tIAoyLjE5LjEud2luZG93cy4xCgo= --_004_31e5cee5c49d4381bfb26a0968c11749ausx13mps324AMERDELLCOM_--