From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 532E4223C176A for ; Wed, 21 Feb 2018 02:54:50 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1C3AA8182D15; Wed, 21 Feb 2018 11:00:49 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-45.rdu2.redhat.com [10.10.120.45]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3C17821411B6; Wed, 21 Feb 2018 11:00:46 +0000 (UTC) To: "Kinney, Michael D" , edk2-devel-01 Cc: "Gao, Liming" , Ard Biesheuvel References: <20180215183638.18578-1-lersek@redhat.com> From: Laszlo Ersek Message-ID: <31f1c1e9-2de7-c1e7-f961-06c467d9a106@redhat.com> Date: Wed, 21 Feb 2018 12:00:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Wed, 21 Feb 2018 11:00:49 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Wed, 21 Feb 2018 11:00:49 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH 0/4] MdePkg/BaseSafeIntLib: fix undefined behavior in INT64 Sub/Add/Mult X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Feb 2018 10:54:50 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 02/17/18 04:07, Kinney, Michael D wrote: > Laszlo, > > The tests for the SafeIntLib are in an edk2-staging > branch. > > https://github.com/tianocore/edk2-staging/tree/edk2-test > > > In this directory > > https://github.com/tianocore/edk2-staging/tree/edk2-test/MdePkgUnitTest/SafeIntLib > > Thanks for the very detailed analysis/comments in the patch. > > Let's wait till Tuesday next week for any additional feedback. Thanks everyone; series pushed as 44e6186eeadf..75505d161133. Cheers Laszlo >> -----Original Message----- >> From: Laszlo Ersek [mailto:lersek@redhat.com] >> Sent: Friday, February 16, 2018 12:50 PM >> To: Kinney, Michael D ; >> edk2-devel-01 >> Cc: Bret Barkelew ; Gao, >> Liming ; Sean Brogan >> >> Subject: Re: [PATCH 0/4] MdePkg/BaseSafeIntLib: fix >> undefined behavior in INT64 Sub/Add/Mult >> >> On 02/16/18 19:11, Kinney, Michael D wrote: >>> Hi Laszlo, >>> >>> This patch series passed the SafeIntLib unit >>> tests for the following builds: >>> >>> * VS2015x86 IA32 >>> * VS2015x86 X64 >>> * VS2015x86 EBC >>> * GCC IA32 >>> * GCC X64 >>> >>> Tested-by: Michael D Kinney >> >> >> Awesome, thank you! I've been secretly hoping that >> there's a test suite >> for this library :) >> >> Given Ard's R-b and your maintainer T-b, should I wait >> for more feedback >> from Bret, Liming and Sean, before I push the series? >> (I'm fine waiting >> a few more days if they intend to provide feedback; I >> just wouldn't like >> to wait in vain.) >> >> Thank you! >> Laszlo >> >>> >>>> -----Original Message----- >>>> From: Laszlo Ersek [mailto:lersek@redhat.com] >>>> Sent: Thursday, February 15, 2018 10:37 AM >>>> To: edk2-devel-01 >>>> Cc: Bret Barkelew ; Gao, >>>> Liming ; Kinney, Michael D >>>> ; Sean Brogan >>>> >>>> Subject: [PATCH 0/4] MdePkg/BaseSafeIntLib: fix >>>> undefined behavior in INT64 Sub/Add/Mult >>>> >>>> Repo: https://github.com/lersek/edk2.git >>>> Branch: signed_range_checks >>>> >>>> Based on the discussion starting at >>>> >>> February/021178.html>. >>>> >>>> Cc: Bret Barkelew >>>> Cc: Liming Gao >>>> Cc: Michael D Kinney >>>> Cc: Sean Brogan >>>> >>>> Laszlo Ersek (4): >>>> MdePkg/BaseSafeIntLib: fix undefined behavior in >>>> SafeInt64Sub() >>>> MdePkg/BaseSafeIntLib: fix undefined behavior in >>>> SafeInt64Add() >>>> MdePkg/BaseSafeIntLib: clean up parentheses in >>>> MIN_INT64_MAGNITUDE >>>> MdePkg/BaseSafeIntLib: fix undefined behavior in >>>> SafeInt64Mult() >>>> >>>> MdePkg/Library/BaseSafeIntLib/SafeIntLib.c | 110 >>>> ++++++++++++++++---- >>>> 1 file changed, 88 insertions(+), 22 deletions(-) >>>> >>>> -- >>>> 2.14.1.3.gb7cf6e02401b >>> > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >