From: "Rebecca Cran" <rebecca@bsdio.com>
To: devel@edk2.groups.io
Cc: Jian J Wang <jian.j.wang@intel.com>, Xiaoyu Lu <xiaoyux.lu@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/1] CryptoPkg: Fix VS2017 build problem for ARM/AARCH64
Date: Wed, 20 May 2020 14:30:08 -0600 [thread overview]
Message-ID: <31feb807-05a0-0ada-da32-fe7b317036fe@bsdio.com> (raw)
In-Reply-To: <1610D6629CC44D8C.10495@groups.io>
On 5/20/2020 2:26 PM, Rebecca Cran wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2029
>
> 1. CryptPkcs7VerifyEku.c contains internal/x509_int.h header file, this
> file contains internal/refcount.h file, if _M_ARM or _M_ARM64
> defined, it will contains (intrin.h).
> So we undef these flags for MSVC. It will fix include header
> dependence problem(intrin.h).
>
> 2. ARM with MSFT toolchain was not enabled in BuildOptions, So
> add CC_FLAGS for ARM/AARCH64 into OpensslLib[Crypto].inf BuildOptions
> section to fix build problem.
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Signed-off-by: Xiaoyu Lu <xiaoyux.lu@intel.com>
I fixed a couple of trailing whitespace errors in the BZ patch, and
build-tested for AARCH64 and ARM.
This patch fixes the ARM build, but it looks like the AARCH64 build
needs more work because it still fails.
--
Rebecca Cran
next parent reply other threads:[~2020-05-20 20:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1610D6629CC44D8C.10495@groups.io>
2020-05-20 20:30 ` Rebecca Cran [this message]
2020-05-20 20:26 [PATCH 1/1] CryptoPkg: Fix VS2017 build problem for ARM/AARCH64 Rebecca Cran
2020-05-25 0:57 ` [edk2-devel] " Guomin Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31feb807-05a0-0ada-da32-fe7b317036fe@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox