From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web11.31426.1676940302813217942 for ; Mon, 20 Feb 2023 16:45:02 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=Pv5zw8p8; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.168.131, mailfrom: quic_rcran@quicinc.com) Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31KNFLe3030156; Tue, 21 Feb 2023 00:45:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=7eafzbzDotEm6jpcFg8I18ftanZx+MHKoGASqh1V6wY=; b=Pv5zw8p8lf6bCzccfjxMZDeTPErHWdTuSD2PLlCvSZYxI1Ne1ZiChUypYDnQb2YvH4X7 qIgEDf89Q7pxpqY7najtzYd1pM+m//usnVqxZ4opIyJ/hE3zjPNi+jSVlrCpNzrk9rFt 3auNngdRVFWBdV4CyYEeknQPRTQUyexgGs1uaYFY3v/Ae3xnouFby8vAMatImRCOBFKy 8qv6FaiwpIsqMEQUCgf/HH6SRhZHSzToLFFFqEE70Gjpvlm9V+zN5b4l2pEQq0rVuvNT vpJCic5JTeVJoaocDJQvPJ08D4/iI3LTr2cMkwwcF0CWD8jnwTi3BB6134yYOKm6dlkg 5A== Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3ntnn0676j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Feb 2023 00:45:02 +0000 Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 31L0j13U030002 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Feb 2023 00:45:01 GMT Received: from [10.110.69.180] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 20 Feb 2023 16:45:01 -0800 Message-ID: <32038087-00af-8b73-57c3-0778d59b417c@quicinc.com> Date: Mon, 20 Feb 2023 17:45:00 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [edk2-devel] [PATCH 1/1] ShellPkg: Improve "ping" output by adding equals sign after time To: "Gao, Zhichao" , "devel@edk2.groups.io" , "Ni, Ray" References: <20221201214935.67205-1-rebecca@quicinc.com> From: "Rebecca Cran" In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: Otflbge8zCwuAnQVVIissRQvVxW4tWh0 X-Proofpoint-GUID: Otflbge8zCwuAnQVVIissRQvVxW4tWh0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-20_19,2023-02-20_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 spamscore=0 priorityscore=1501 malwarescore=0 phishscore=0 clxscore=1011 adultscore=0 mlxscore=0 bulkscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302210005 Content-Language: en-US Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Could someone commit this please? On 12/5/22 19:17, Gao, Zhichao wrote: > Reviewed-by: Zhichao Gao > > Thanks, > Zhichao > >> -----Original Message----- >> From: devel@edk2.groups.io On Behalf Of Rebecca >> Cran >> Sent: Friday, December 2, 2022 5:50 AM >> To: devel@edk2.groups.io; Ni, Ray ; Gao, Zhichao >> >> Cc: Rebecca Cran >> Subject: [edk2-devel] [PATCH 1/1] ShellPkg: Improve "ping" output by adding >> equals sign after time >> >> The output of the "ping" command shows the time without a space between >> the label and the value. e.g.: >> >> 20 bytes from 192.168.0.1 : icmp_seq=1 ttl=1 time1~2ms >> >> Improve the readability and consistency by adding an equals sign for the time >> value: >> >> 20 bytes from 192.168.0.1 : icmp_seq=1 ttl=1 time=1~2ms >> >> Signed-off-by: Rebecca Cran >> --- >> >> ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Comm >> andsLib.uni | 2 +- >> ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Comm >> andsLib.uni | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git >> a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com >> mandsLib.uni >> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com >> mandsLib.uni >> index 73cf96d9e614..37fd4a11929c 100644 >> --- >> a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com >> mandsLib.uni >> +++ >> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com >> +++ mandsLib.uni >> @@ -52,7 +52,7 @@ >> #string STR_PING_NOROUTE_FOUND #language en-US "There is no >> route to the destination '%B%s%N' from the source '%B%s%N' was >> found.\r\n" >> #string STR_PING_START #language en-US "Ping %s %d data >> bytes.\r\n" >> #string STR_PING_TIMEOUT #language en-US "Echo request >> sequence %d timeout.\r\n" >> -#string STR_PING_REPLY_INFO #language en-US "%d bytes from %s : >> icmp_seq=%d ttl=%d time%d~%dms\r\n" >> +#string STR_PING_REPLY_INFO #language en-US "%d bytes from %s : >> icmp_seq=%d ttl=%d time=%d~%dms\r\n" >> #string STR_PING_STAT #language en-US "\n%d packets >> transmitted, %d received, %d%% packet loss, time %dms\r\n" >> #string STR_PING_RTT #language en-US "\nRtt(round trip time) >> min=%d~%dms max=%d~%dms avg=%d~%dms\r\n" >> >> diff --git >> a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com >> mandsLib.uni >> b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com >> mandsLib.uni >> index 30913ae5b583..cb9d39a33fbe 100644 >> --- >> a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com >> mandsLib.uni >> +++ >> b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com >> +++ mandsLib.uni >> @@ -33,7 +33,7 @@ >> #string STR_PING6_NOSOURCE_INDOMAIN #language en-US "No >> sources in %s's multicast domain.\r\n" >> #string STR_PING6_START #language en-US "Ping %s %d data >> bytes\r\n" >> #string STR_PING6_TIMEOUT #language en-US "Echo request >> sequence %d timeout.\r\n" >> -#string STR_PING6_REPLY_INFO #language en-US "%d bytes >> from %s : icmp_seq=%d ttl=%d time%d~%dms\r\n" >> +#string STR_PING6_REPLY_INFO #language en-US "%d bytes >> from %s : icmp_seq=%d ttl=%d time=%d~%dms\r\n" >> #string STR_PING6_STAT #language en-US "\n%d packets >> transmitted, %d received, %d%% packet loss, time %dms\r\n" >> #string STR_PING6_RTT #language en-US "\nRtt(round trip time) >> min=%d~%dms max=%d~%dms avg=%d~%dms\r\n" >> >> -- >> 2.30.2 >> >> >> >> >> >