From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [edk2-devel] [PATCH v4 1/7] Silicon/ARM/NeoverseN1Soc: Fix missing function documentation To: PierreGondois ,devel@edk2.groups.io From: "Khasim Mohammed" X-Originating-Location: Bengaluru, Karnataka, IN (217.140.105.55) X-Originating-Platform: Linux Chrome 95 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Mon, 08 Nov 2021 02:54:12 -0800 References: In-Reply-To: Message-ID: <32044.1636368852121866303@groups.io> Content-Type: multipart/alternative; boundary="LwFwG1KZxBVZ3FEmdnQX" --LwFwG1KZxBVZ3FEmdnQX Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Wed, Oct 27, 2021 at 08:28 AM, PierreGondois wrote: >=20 > Hi Khasim, >=20 > + Sami >=20 > Thanks for the new patch-set, everything looks good to me: >=20 > Reviewed-by: Pierre Gondois Hi all, As we have entered the soft freeze phase, I would like to provide additiona= l info to the edk2 community about the following series (7 Patches version = 5) of the patches for N1SDP. These patches were already reviewed a few week= s ago, with reviewed-by as shown above, these patches are important for N1S= DP platform as they provide all the functionality required to get the N1SDP= platform booting various OS distributions like busybox, poky and ubuntu wi= th ACPI tables. These patches are independent of any other platform and specific to only N1= SDP hardware thereby it would not break any other platform or existing feat= ures in the edk2 software. I request you to consider these patches and the merge request and merge the= patches to appropriate repository. Thanks. Regards, Khasim >=20 > Just a reminder for Sami about the _OSC method: > https://edk2.groups.io/g/devel/message/82724 >=20 > Regards, >=20 > Pierre >=20 >=20 > On 10/26/21 18:39, Khasim Mohammed via groups.io wrote: >=20 >> This patch adds missing documentation for few of the functions >> and fixes few formatting changes. >>=20 >> Signed-off-by: Khasim Syed Mohammed >> --- >> .../Library/PlatformLib/PlatformLib.c | 46 +++++++++++++++++-- >> 1 file changed, 41 insertions(+), 5 deletions(-) >>=20 >> diff --git a/Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLib.c >> b/Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLib.c >> index f722080e56..c0effd37f3 100644 >> --- a/Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLib.c >> +++ b/Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLib.c >> @@ -1,9 +1,9 @@ >> /** @file >> -* >> -* Copyright (c) 2018-2020, ARM Limited. All rights reserved. >> -* >> -* SPDX-License-Identifier: BSD-2-Clause-Patent >> -* >> + >> + Copyright (c) 2018-2021, ARM Limited. All rights reserved.
>> + >> + SPDX-License-Identifier: BSD-2-Clause-Patent >> + >> **/ >>=20 >> #include >> @@ -17,6 +17,12 @@ STATIC ARM_CORE_INFO mCoreInfoTable[] =3D { >> { 0x1, 0x1 } // Cluster 1, Core 1 >> }; >>=20 >> +/** >> + Return the current Boot Mode. >> + >> + @return The boot reason on the platform. >> + >> +**/ >> EFI_BOOT_MODE >> ArmPlatformGetBootMode ( >> VOID >> @@ -25,6 +31,16 @@ ArmPlatformGetBootMode ( >> return BOOT_WITH_FULL_CONFIGURATION; >> } >>=20 >> +/** >> + Initialize controllers that must be setup in the normal world. >> + >> + This function is called by the ArmPlatformPkg/Pei or >> + ArmPlatformPkg/Pei/PlatformPeim in the PEI phase. >> + >> + @param[in] MpId Processor ID >> + @retval RETURN_SUCCESS >> + >> +**/ >> RETURN_STATUS >> ArmPlatformInitialize ( >> IN UINTN MpId >> @@ -33,6 +49,17 @@ ArmPlatformInitialize ( >> return RETURN_SUCCESS; >> } >>=20 >> +/** >> + Populate the Platform core information. >> + >> + This function populates the ARM_MP_CORE_INFO_PPI with information >> + about the cores. >> + >> + @param[out] CoreCount Number of cores >> + @param[out] ArmCoreTable Table containing information about the cores >> + @retval EFI_SUCCESS >> + >> +**/ >> EFI_STATUS >> PrePeiCoreGetMpCoreInfo ( >> OUT UINTN *CoreCount, >> @@ -56,6 +83,15 @@ EFI_PEI_PPI_DESCRIPTOR gPlatformPpiTable[] =3D { >> } >> }; >>=20 >> +/** >> + Return the Platform specific PPIs >> + >> + This function exposes the N1Sdp Specific PPIs. >> + >> + @param[out] PpiListSize Size in Bytes of the Platform PPI List >> + @param[out] PpiList Platform PPI List >> + >> +**/ >> VOID >> ArmPlatformGetPlatformPpiList ( >> OUT UINTN *PpiListSize, >=20 > --LwFwG1KZxBVZ3FEmdnQX Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Wed, Oct 27, 2021 at 08:28 AM, PierreGondois wrote:
Hi Khasim,

+ Sami

Thanks for the new patc= h-set, everything looks good to me:

Reviewed-by: Pierre Gondois = <pierre.gondois@arm.com>
Hi all,

As we have entered the soft freeze phase, I would like t= o provide additional info to the edk2 community about the following series = (7 Patches version 5) of the patches for N1SDP. These patches were already = reviewed a few weeks ago, with reviewed-by as shown above, these patches ar= e important for N1SDP platform as they provide all the functionality requir= ed to get the N1SDP platform booting various OS distributions like busybox,= poky and ubuntu with ACPI tables.

These patches are independent= of any other platform and specific to only N1SDP hardware thereby it would= not break any other platform or existing features in the edk2 software.&nb= sp;

I request you to consider these patches and the merge reques= t and merge the patches to appropriate repository.

Thanks.
=
Regards,
Khasim

Just a reminder for Sami about the _OSC method:
https://edk2.groups.io/g/devel/message/82724

Regards,=

Pierre


On 10/26/21 18:39, Khasim Mohammed via = groups.io wrote:
This patch adds missing documentation for few of the functions<= br />and fixes few formatting changes.

Signed-off-by: Khasim Sye= d Mohammed <khasim.mohammed@arm.com>
---
.../Library/Platfo= rmLib/PlatformLib.c | 46 +++++++++++++++++--
1 file changed, 41 insert= ions(+), 5 deletions(-)

diff --git a/Silicon/ARM/NeoverseN1Soc/L= ibrary/PlatformLib/PlatformLib.c b/Silicon/ARM/NeoverseN1Soc/Library/Platfo= rmLib/PlatformLib.c
index f722080e56..c0effd37f3 100644
--- a/Sil= icon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLib.c
+++ b/Silicon= /ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLib.c
@@ -1,9 +1,9 @@/** @file
-*
-* Copyright (c) 2018-2020, ARM Limited. All rig= hts reserved.
-*
-* SPDX-License-Identifier: BSD-2-Clause-Patent<= br />-*
+
+ Copyright (c) 2018-2021, ARM Limited. All rights rese= rved.<BR>
+
+ SPDX-License-Identifier: BSD-2-Clause-Patent<= br />+
**/

#include <Library/ArmPlatformLib.h>
@= @ -17,6 +17,12 @@ STATIC ARM_CORE_INFO mCoreInfoTable[] =3D {
{ 0x1, 0= x1 } // Cluster 1, Core 1
};

+/**
+ Return the current= Boot Mode.
+
+ @return The boot reason on the platform.
++**/
EFI_BOOT_MODE
ArmPlatformGetBootMode (
VOID
@@= -25,6 +31,16 @@ ArmPlatformGetBootMode (
return BOOT_WITH_FULL_CONFIG= URATION;
}

+/**
+ Initialize controllers that must be = setup in the normal world.
+
+ This function is called by the Arm= PlatformPkg/Pei or
+ ArmPlatformPkg/Pei/PlatformPeim in the PEI phase.=
+
+ @param[in] MpId Processor ID
+ @retval RETURN_SUCCESS+
+**/
RETURN_STATUS
ArmPlatformInitialize (
IN UIN= TN MpId
@@ -33,6 +49,17 @@ ArmPlatformInitialize (
return RETURN_= SUCCESS;
}

+/**
+ Populate the Platform core informati= on.
+
+ This function populates the ARM_MP_CORE_INFO_PPI with inf= ormation
+ about the cores.
+
+ @param[out] CoreCount Number= of cores
+ @param[out] ArmCoreTable Table containing information abou= t the cores
+ @retval EFI_SUCCESS
+
+**/
EFI_STATUS
PrePeiCoreGetMpCoreInfo (
OUT UINTN *CoreCount,
@@ -56,6 +83,15= @@ EFI_PEI_PPI_DESCRIPTOR gPlatformPpiTable[] =3D {
}
};
+/**
+ Return the Platform specific PPIs
+
+ This functi= on exposes the N1Sdp Specific PPIs.
+
+ @param[out] PpiListSize S= ize in Bytes of the Platform PPI List
+ @param[out] PpiList Platform P= PI List
+
+**/
VOID
ArmPlatformGetPlatformPpiList (
OUT UINTN *PpiListSize,
--LwFwG1KZxBVZ3FEmdnQX--