From: "Ni, Ruiyu" <ruiyu.ni@Intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"Zimmer, Vincent" <vincent.zimmer@intel.com>,
"Richardson, Brian" <brian.richardson@intel.com>,
Andrew Fish <afish@apple.com>,
Leif Lindholm <leif.lindholm@linaro.org>,
"Dong, Eric" <eric.dong@intel.com>,
"Gao, Liming" <liming.gao@intel.com>,
"Carsey, Jaben" <jaben.carsey@intel.com>,
"Shi, Steven" <steven.shi@intel.com>
Subject: Re: [PATCH v3 1/7] MdeModulePkg: introduce PE/COFF image emulator protocol
Date: Fri, 28 Sep 2018 14:34:20 +0800 [thread overview]
Message-ID: <321f6890-e216-24b6-e82b-5d0d1c320ec0@Intel.com> (raw)
In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103BBF4791@shsmsx102.ccr.corp.intel.com>
On 9/28/2018 11:08 AM, Zeng, Star wrote:
> Good idea.
> You prefer to introduce a new feature PCD for this with default value = TRUE?
>
> Could we group the emulator APIs to one structure like below? And add a Version field for potential further extension?
>
> typedef struct {
> UINTN Version;
> EDKII_PECOFF_IMAGE_EMULATOR_IS_IMAGE_SUPPORTED IsImageSupported;
> EDKII_PECOFF_IMAGE_EMULATOR_REGISTER_IMAGE RegisterImage;
> EDKII_PECOFF_IMAGE_EMULATOR_UNREGISTER_IMAGE UnregisterImage;
> } PECOFF_IMAGE_EMULATOR;
Star,
What's the reason for the "Version" field? Can you explain the usage case?
And why do we need the PCD to control?
--
Thanks,
Ray
next prev parent reply other threads:[~2018-09-28 6:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 23:01 [PATCH v3 0/7] MdeModulePkg: add support for dispatching foreign arch PE/COFF images Ard Biesheuvel
2018-09-20 23:01 ` [PATCH v3 1/7] MdeModulePkg: introduce PE/COFF image emulator protocol Ard Biesheuvel
2018-09-26 9:58 ` Zeng, Star
2018-09-26 10:13 ` Ard Biesheuvel
2018-09-26 17:32 ` Kinney, Michael D
2018-09-27 0:48 ` Zeng, Star
2018-09-27 10:58 ` Ard Biesheuvel
2018-09-27 15:36 ` Kinney, Michael D
2018-09-28 3:05 ` Zeng, Star
2018-09-28 3:08 ` Zeng, Star
2018-09-28 6:34 ` Ni, Ruiyu [this message]
2018-09-28 7:02 ` Zeng, Star
2018-09-20 23:01 ` [PATCH v3 2/7] MdeModulePkg/DxeCore: invoke the emulator protocol for foreign images Ard Biesheuvel
2018-09-20 23:01 ` [PATCH v3 3/7] MdeModulePkg/PciBusDxe: invoke PE/COFF emulator for foreign option ROMs Ard Biesheuvel
2018-09-26 18:26 ` Kinney, Michael D
2018-12-27 10:13 ` Ard Biesheuvel
2018-09-20 23:01 ` [PATCH v3 4/7] MdeModulePkg/UefiBootManagerLib: allow foreign Driver#### images Ard Biesheuvel
2018-09-26 23:34 ` Kinney, Michael D
2018-12-27 10:16 ` Ard Biesheuvel
2018-09-20 23:01 ` [PATCH v3 5/7] MdeModulePkg/EbcDxe: implement the PE/COFF emulator protocol Ard Biesheuvel
2018-09-20 23:01 ` [PATCH v3 6/7] MdePkg/UefiBaseType.h: treat EBC as a non-native machine type Ard Biesheuvel
2018-09-20 23:01 ` [PATCH v3 7/7] MdeModulePkg/DxeCore: remove explicit EBC handling Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=321f6890-e216-24b6-e82b-5d0d1c320ec0@Intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox