* [PATCH v1 0/3] Prepare ArmPlatformPkg enablement
@ 2021-02-25 16:37 PierreGondois
2021-02-25 16:37 ` [PATCH v1 1/3] ArmPlatformPkg: Fix Ecc error 8001 PierreGondois
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: PierreGondois @ 2021-02-25 16:37 UTC (permalink / raw)
To: devel, ardb+tianocore, leif, sami.mujawar
From: Pierre Gondois <Pierre.Gondois@arm.com>
To prepare for the enablement of the ArmPlatformPkg CI,
fix some errors reported by running the CI locally.
The changes can be seen at: https://github.com/PierreARM/edk2/tree/1641_CI_fixes_for_ArmPlatformPkg_v1
Pierre Gondois (3):
ArmPlatformPkg: Fix Ecc error 8001
ArmPlatformPkg: Fix Ecc error 9001
ArmPlatformPkg: Remove package dependency in NorFlashStandaloneMm
.../Drivers/NorFlashDxe/NorFlashStandaloneMm.inf | 1 -
ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c | 12 ++++++------
ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.h | 10 +++++-----
.../Drivers/PL061GpioDxe/PL061GpioDxe.inf | 14 +++++++-------
.../Drivers/SP805WatchdogDxe/SP805Watchdog.c | 12 ++++++------
.../Drivers/SP805WatchdogDxe/SP805Watchdog.h | 10 +++++-----
.../SP805WatchdogDxe/SP805WatchdogDxe.inf | 16 ++++++++--------
ArmPlatformPkg/Include/Library/ArmPlatformLib.h | 10 +++++-----
.../Include/Library/PL011UartClockLib.h | 10 +++++-----
ArmPlatformPkg/Include/Library/PL011UartLib.h | 10 +++++-----
.../ArmPlatformLibNull/ArmPlatformLibNull.c | 10 +++++-----
.../ArmPlatformLibNull/ArmPlatformLibNullMem.c | 10 +++++-----
.../PL011UartClockLib/PL011UartClockLib.c | 10 +++++-----
ArmPlatformPkg/Library/PL011UartLib/PL011Uart.h | 10 +++++-----
.../PL031RealTimeClockLib/PL031RealTimeClock.h | 10 +++++-----
.../PrePiHobListPointerLib/PrePiHobListPointer.c | 10 +++++-----
ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.c | 10 +++++-----
ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.c | 10 +++++-----
ArmPlatformPkg/PlatformPei/PlatformPeiLib.c | 10 +++++-----
ArmPlatformPkg/PlatformPei/PlatformPeim.c | 10 +++++-----
.../PrePeiCore/AArch64/ArchPrePeiCore.c | 12 ++++++------
ArmPlatformPkg/PrePeiCore/Arm/ArchPrePeiCore.c | 12 ++++++------
ArmPlatformPkg/PrePeiCore/MainMPCore.c | 10 +++++-----
ArmPlatformPkg/PrePeiCore/MainUniCore.c | 10 +++++-----
ArmPlatformPkg/PrePeiCore/PrePeiCore.c | 12 ++++++------
ArmPlatformPkg/PrePeiCore/PrePeiCore.h | 12 ++++++------
ArmPlatformPkg/PrePi/AArch64/ArchPrePi.c | 10 +++++-----
ArmPlatformPkg/PrePi/Arm/ArchPrePi.c | 10 +++++-----
ArmPlatformPkg/PrePi/MainMPCore.c | 10 +++++-----
ArmPlatformPkg/PrePi/MainUniCore.c | 10 +++++-----
ArmPlatformPkg/PrePi/PrePi.c | 10 +++++-----
ArmPlatformPkg/PrePi/PrePi.h | 10 +++++-----
32 files changed, 166 insertions(+), 167 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v1 1/3] ArmPlatformPkg: Fix Ecc error 8001
2021-02-25 16:37 [PATCH v1 0/3] Prepare ArmPlatformPkg enablement PierreGondois
@ 2021-02-25 16:37 ` PierreGondois
2021-03-01 15:21 ` [edk2-devel] " Sami Mujawar
2021-02-25 16:37 ` [PATCH v1 2/3] ArmPlatformPkg: Fix Ecc error 9001 PierreGondois
2021-02-25 16:37 ` [PATCH v1 3/3] ArmPlatformPkg: Remove package dependency in NorFlashStandaloneMm PierreGondois
2 siblings, 1 reply; 7+ messages in thread
From: PierreGondois @ 2021-02-25 16:37 UTC (permalink / raw)
To: devel, ardb+tianocore, leif, sami.mujawar
From: Pierre Gondois <Pierre.Gondois@arm.com>
This patch fixes the following Ecc reported error:
File header doesn't exist File header comment missing
the ""Copyright""
Even though a copyright is present in the header file,
the leading '*' char prevents the Ecc tool from detecting it.
According to the edk2 coding specifcation, section 5.2.3
"File Heading", there should not be leading '*' char.
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
The changes can be seen at: https://github.com/PierreARM/edk2/tree/1641_CI_fixes_for_ArmPlatformPkg_v1
ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c | 12 ++++++------
ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.h | 10 +++++-----
.../Drivers/SP805WatchdogDxe/SP805Watchdog.c | 12 ++++++------
.../Drivers/SP805WatchdogDxe/SP805Watchdog.h | 10 +++++-----
ArmPlatformPkg/Include/Library/ArmPlatformLib.h | 10 +++++-----
ArmPlatformPkg/Include/Library/PL011UartClockLib.h | 10 +++++-----
ArmPlatformPkg/Include/Library/PL011UartLib.h | 10 +++++-----
.../Library/ArmPlatformLibNull/ArmPlatformLibNull.c | 10 +++++-----
.../ArmPlatformLibNull/ArmPlatformLibNullMem.c | 10 +++++-----
.../Library/PL011UartClockLib/PL011UartClockLib.c | 10 +++++-----
ArmPlatformPkg/Library/PL011UartLib/PL011Uart.h | 10 +++++-----
.../PL031RealTimeClockLib/PL031RealTimeClock.h | 10 +++++-----
.../PrePiHobListPointerLib/PrePiHobListPointer.c | 10 +++++-----
ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.c | 10 +++++-----
ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.c | 10 +++++-----
ArmPlatformPkg/PlatformPei/PlatformPeiLib.c | 10 +++++-----
ArmPlatformPkg/PlatformPei/PlatformPeim.c | 10 +++++-----
ArmPlatformPkg/PrePeiCore/AArch64/ArchPrePeiCore.c | 12 ++++++------
ArmPlatformPkg/PrePeiCore/Arm/ArchPrePeiCore.c | 12 ++++++------
ArmPlatformPkg/PrePeiCore/MainMPCore.c | 10 +++++-----
ArmPlatformPkg/PrePeiCore/MainUniCore.c | 10 +++++-----
ArmPlatformPkg/PrePeiCore/PrePeiCore.c | 12 ++++++------
ArmPlatformPkg/PrePeiCore/PrePeiCore.h | 12 ++++++------
ArmPlatformPkg/PrePi/AArch64/ArchPrePi.c | 10 +++++-----
ArmPlatformPkg/PrePi/Arm/ArchPrePi.c | 10 +++++-----
ArmPlatformPkg/PrePi/MainMPCore.c | 10 +++++-----
ArmPlatformPkg/PrePi/MainUniCore.c | 10 +++++-----
ArmPlatformPkg/PrePi/PrePi.c | 10 +++++-----
ArmPlatformPkg/PrePi/PrePi.h | 10 +++++-----
29 files changed, 151 insertions(+), 151 deletions(-)
diff --git a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c b/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c
index be0e1c096360..3ecce233440d 100644
--- a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c
+++ b/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c
@@ -1,10 +1,10 @@
/** @file
-*
-* Copyright (c) 2011 - 2020, Arm Limited. All rights reserved.<BR>
-* Copyright (c) 2016, Linaro Limited. All rights reserved.
-*
-* SPDX-License-Identifier: BSD-2-Clause-Patent
-*
+
+ Copyright (c) 2011 - 2020, Arm Limited. All rights reserved.<BR>
+ Copyright (c) 2016, Linaro Limited. All rights reserved.
+
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
**/
diff --git a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.h b/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.h
index 92ddf64b9b6e..57f56f7d370c 100644
--- a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.h
+++ b/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.h
@@ -1,9 +1,9 @@
/** @file
-*
-* Copyright (c) 2011-2012, ARM Limited. All rights reserved.
-*
-* SPDX-License-Identifier: BSD-2-Clause-Patent
-*
+
+ Copyright (c) 2011-2012, ARM Limited. All rights reserved.
+
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
**/
diff --git a/ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805Watchdog.c b/ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805Watchdog.c
index 5029d21e0f92..00238ee65943 100644
--- a/ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805Watchdog.c
+++ b/ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805Watchdog.c
@@ -1,10 +1,10 @@
/** @file
-*
-* Copyright (c) 2011-2013, ARM Limited. All rights reserved.
-* Copyright (c) 2018, Linaro Limited. All rights reserved.
-*
-* SPDX-License-Identifier: BSD-2-Clause-Patent
-*
+
+ Copyright (c) 2011-2013, ARM Limited. All rights reserved.
+ Copyright (c) 2018, Linaro Limited. All rights reserved.
+
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
**/
diff --git a/ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805Watchdog.h b/ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805Watchdog.h
index df711400e892..548c69637803 100644
--- a/ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805Watchdog.h
+++ b/ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805Watchdog.h
@@ -1,9 +1,9 @@
/** @file
-*
-* Copyright (c) 2011-2012, ARM Limited. All rights reserved.
-*
-* SPDX-License-Identifier: BSD-2-Clause-Patent
-*
+
+ Copyright (c) 2011-2012, ARM Limited. All rights reserved.
+
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
**/
diff --git a/ArmPlatformPkg/Include/Library/ArmPlatformLib.h b/ArmPlatformPkg/Include/Library/ArmPlatformLib.h
index 225183af2c78..81cc90db55cf 100644
--- a/ArmPlatformPkg/Include/Library/ArmPlatformLib.h
+++ b/ArmPlatformPkg/Include/Library/ArmPlatformLib.h
@@ -1,9 +1,9 @@
/** @file
-*
-* Copyright (c) 2011-2013, ARM Limited. All rights reserved.
-*
-* SPDX-License-Identifier: BSD-2-Clause-Patent
-*
+
+ Copyright (c) 2011-2013, ARM Limited. All rights reserved.
+
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
**/
#ifndef _ARMPLATFORMLIB_H_
diff --git a/ArmPlatformPkg/Include/Library/PL011UartClockLib.h b/ArmPlatformPkg/Include/Library/PL011UartClockLib.h
index 2770688fb735..5814d960a663 100644
--- a/ArmPlatformPkg/Include/Library/PL011UartClockLib.h
+++ b/ArmPlatformPkg/Include/Library/PL011UartClockLib.h
@@ -1,9 +1,9 @@
/** @file
-*
-* Copyright 2018 NXP
-*
-* SPDX-License-Identifier: BSD-2-Clause-Patent
-*
+
+ Copyright 2018 NXP
+
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
**/
#ifndef __PL011UARTCLOCKLIB_H__
diff --git a/ArmPlatformPkg/Include/Library/PL011UartLib.h b/ArmPlatformPkg/Include/Library/PL011UartLib.h
index 3bd2e294b097..5446aabc5ee7 100644
--- a/ArmPlatformPkg/Include/Library/PL011UartLib.h
+++ b/ArmPlatformPkg/Include/Library/PL011UartLib.h
@@ -1,9 +1,9 @@
/** @file
-*
-* Copyright (c) 2011-2016, ARM Limited. All rights reserved.
-*
-* SPDX-License-Identifier: BSD-2-Clause-Patent
-*
+
+ Copyright (c) 2011-2016, ARM Limited. All rights reserved.
+
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
**/
#ifndef __PL011_UART_LIB_H__
diff --git a/ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.c b/ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.c
index 6c21792cf607..1cd9ec30a977 100644
--- a/ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.c
+++ b/ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.c
@@ -1,9 +1,9 @@
/** @file
-*
-* Copyright (c) 2011-2012, ARM Limited. All rights reserved.
-*
-* SPDX-License-Identifier: BSD-2-Clause-Patent
-*
+
+ Copyright (c) 2011-2012, ARM Limited. All rights reserved.
+
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
**/
#include <Library/ArmLib.h>
diff --git a/ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNullMem.c b/ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNullMem.c
index 5109ff6937c7..686e083e2ec6 100644
--- a/ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNullMem.c
+++ b/ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNullMem.c
@@ -1,9 +1,9 @@
/** @file
-*
-* Copyright (c) 2011, ARM Limited. All rights reserved.
-*
-* SPDX-License-Identifier: BSD-2-Clause-Patent
-*
+
+ Copyright (c) 2011, ARM Limited. All rights reserved.
+
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
**/
#include <Library/ArmPlatformLib.h>
diff --git a/ArmPlatformPkg/Library/PL011UartClockLib/PL011UartClockLib.c b/ArmPlatformPkg/Library/PL011UartClockLib/PL011UartClockLib.c
index 669be9dafcfd..3cfdd19fe867 100644
--- a/ArmPlatformPkg/Library/PL011UartClockLib/PL011UartClockLib.c
+++ b/ArmPlatformPkg/Library/PL011UartClockLib/PL011UartClockLib.c
@@ -1,9 +1,9 @@
/** @file
-*
-* Copyright 2018 NXP
-*
-* SPDX-License-Identifier: BSD-2-Clause-Patent
-*
+
+ Copyright 2018 NXP
+
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
**/
#include <Base.h>
diff --git a/ArmPlatformPkg/Library/PL011UartLib/PL011Uart.h b/ArmPlatformPkg/Library/PL011UartLib/PL011Uart.h
index 21b2acf9d522..000fd6578f41 100644
--- a/ArmPlatformPkg/Library/PL011UartLib/PL011Uart.h
+++ b/ArmPlatformPkg/Library/PL011UartLib/PL011Uart.h
@@ -1,9 +1,9 @@
/** @file
-*
-* Copyright (c) 2011-2016, ARM Limited. All rights reserved.
-*
-* SPDX-License-Identifier: BSD-2-Clause-Patent
-*
+
+ Copyright (c) 2011-2016, ARM Limited. All rights reserved.
+
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
**/
#ifndef __PL011_UART_H__
diff --git a/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClock.h b/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClock.h
index 9f28ed7a2347..6112a42638cb 100644
--- a/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClock.h
+++ b/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClock.h
@@ -1,9 +1,9 @@
/** @file
-*
-* Copyright (c) 2011 - 2014, ARM Limited. All rights reserved.
-*
-* SPDX-License-Identifier: BSD-2-Clause-Patent
-*
+
+ Copyright (c) 2011 - 2014, ARM Limited. All rights reserved.
+
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
**/
diff --git a/ArmPlatformPkg/Library/PrePiHobListPointerLib/PrePiHobListPointer.c b/ArmPlatformPkg/Library/PrePiHobListPointerLib/PrePiHobListPointer.c
index 64850c7de453..fe70be56d5c6 100644
--- a/ArmPlatformPkg/Library/PrePiHobListPointerLib/PrePiHobListPointer.c
+++ b/ArmPlatformPkg/Library/PrePiHobListPointerLib/PrePiHobListPointer.c
@@ -1,9 +1,9 @@
/** @file
-*
-* Copyright (c) 2011, ARM Limited. All rights reserved.
-*
-* SPDX-License-Identifier: BSD-2-Clause-Patent
-*
+
+ Copyright (c) 2011, ARM Limited. All rights reserved.
+
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
**/
#include <PiPei.h>
diff --git a/ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.c b/ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.c
index 89a40d4f32cf..e58b4bed1c50 100644
--- a/ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.c
+++ b/ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.c
@@ -1,9 +1,9 @@
/** @file
-*
-* Copyright (c) 2011-2015, ARM Limited. All rights reserved.
-*
-* SPDX-License-Identifier: BSD-2-Clause-Patent
-*
+
+ Copyright (c) 2011-2015, ARM Limited. All rights reserved.
+
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
**/
#include <PiPei.h>
diff --git a/ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.c b/ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.c
index 027fa11a89c3..45bdf94970da 100644
--- a/ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.c
+++ b/ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.c
@@ -1,9 +1,9 @@
/** @file
-*
-* Copyright (c) 2011, ARM Limited. All rights reserved.
-*
-* SPDX-License-Identifier: BSD-2-Clause-Patent
-*
+
+ Copyright (c) 2011, ARM Limited. All rights reserved.
+
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
**/
#include <PiPei.h>
diff --git a/ArmPlatformPkg/PlatformPei/PlatformPeiLib.c b/ArmPlatformPkg/PlatformPei/PlatformPeiLib.c
index 84b45f414ac0..db39cd4f2c43 100644
--- a/ArmPlatformPkg/PlatformPei/PlatformPeiLib.c
+++ b/ArmPlatformPkg/PlatformPei/PlatformPeiLib.c
@@ -1,9 +1,9 @@
/** @file
-*
-* Copyright (c) 2011-2014, ARM Limited. All rights reserved.
-*
-* SPDX-License-Identifier: BSD-2-Clause-Patent
-*
+
+ Copyright (c) 2011-2014, ARM Limited. All rights reserved.
+
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
**/
#include <PiPei.h>
diff --git a/ArmPlatformPkg/PlatformPei/PlatformPeim.c b/ArmPlatformPkg/PlatformPei/PlatformPeim.c
index ca5a31116abf..8fcdc99c0ee7 100644
--- a/ArmPlatformPkg/PlatformPei/PlatformPeim.c
+++ b/ArmPlatformPkg/PlatformPei/PlatformPeim.c
@@ -1,9 +1,9 @@
/** @file
-*
-* Copyright (c) 2011, ARM Limited. All rights reserved.
-*
-* SPDX-License-Identifier: BSD-2-Clause-Patent
-*
+
+ Copyright (c) 2011, ARM Limited. All rights reserved.
+
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
**/
#include <PiPei.h>
diff --git a/ArmPlatformPkg/PrePeiCore/AArch64/ArchPrePeiCore.c b/ArmPlatformPkg/PrePeiCore/AArch64/ArchPrePeiCore.c
index fe659a24440c..5d3d1911a0b7 100644
--- a/ArmPlatformPkg/PrePeiCore/AArch64/ArchPrePeiCore.c
+++ b/ArmPlatformPkg/PrePeiCore/AArch64/ArchPrePeiCore.c
@@ -1,10 +1,10 @@
/** @file
-* Main file supporting the transition to PEI Core in Normal World for Versatile Express
-*
-* Copyright (c) 2012-2013, ARM Limited. All rights reserved.
-*
-* SPDX-License-Identifier: BSD-2-Clause-Patent
-*
+ Main file supporting the transition to PEI Core in Normal World for Versatile Express
+
+ Copyright (c) 2012-2013, ARM Limited. All rights reserved.
+
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
**/
#include <Library/PrintLib.h>
diff --git a/ArmPlatformPkg/PrePeiCore/Arm/ArchPrePeiCore.c b/ArmPlatformPkg/PrePeiCore/Arm/ArchPrePeiCore.c
index 9a838621880a..433f2de96105 100644
--- a/ArmPlatformPkg/PrePeiCore/Arm/ArchPrePeiCore.c
+++ b/ArmPlatformPkg/PrePeiCore/Arm/ArchPrePeiCore.c
@@ -1,10 +1,10 @@
/** @file
-* Main file supporting the transition to PEI Core in Normal World for Versatile Express
-*
-* Copyright (c) 2012, ARM Limited. All rights reserved.
-*
-* SPDX-License-Identifier: BSD-2-Clause-Patent
-*
+ Main file supporting the transition to PEI Core in Normal World for Versatile Express
+
+ Copyright (c) 2012, ARM Limited. All rights reserved.
+
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
**/
#include <Library/PrintLib.h>
diff --git a/ArmPlatformPkg/PrePeiCore/MainMPCore.c b/ArmPlatformPkg/PrePeiCore/MainMPCore.c
index d379ad8b7a73..859f1adf2078 100644
--- a/ArmPlatformPkg/PrePeiCore/MainMPCore.c
+++ b/ArmPlatformPkg/PrePeiCore/MainMPCore.c
@@ -1,9 +1,9 @@
/** @file
-*
-* Copyright (c) 2011-2014, ARM Limited. All rights reserved.
-*
-* SPDX-License-Identifier: BSD-2-Clause-Patent
-*
+
+ Copyright (c) 2011-2014, ARM Limited. All rights reserved.
+
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
**/
#include <Library/ArmGicLib.h>
diff --git a/ArmPlatformPkg/PrePeiCore/MainUniCore.c b/ArmPlatformPkg/PrePeiCore/MainUniCore.c
index 1500d2bd5185..220f9b568080 100644
--- a/ArmPlatformPkg/PrePeiCore/MainUniCore.c
+++ b/ArmPlatformPkg/PrePeiCore/MainUniCore.c
@@ -1,9 +1,9 @@
/** @file
-*
-* Copyright (c) 2011-2012, ARM Limited. All rights reserved.
-*
-* SPDX-License-Identifier: BSD-2-Clause-Patent
-*
+
+ Copyright (c) 2011-2012, ARM Limited. All rights reserved.
+
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
**/
#include "PrePeiCore.h"
diff --git a/ArmPlatformPkg/PrePeiCore/PrePeiCore.c b/ArmPlatformPkg/PrePeiCore/PrePeiCore.c
index 5202aa641ecd..69dbb77dee54 100644
--- a/ArmPlatformPkg/PrePeiCore/PrePeiCore.c
+++ b/ArmPlatformPkg/PrePeiCore/PrePeiCore.c
@@ -1,10 +1,10 @@
/** @file
-* Main file supporting the transition to PEI Core in Normal World for Versatile Express
-*
-* Copyright (c) 2011-2014, ARM Limited. All rights reserved.
-*
-* SPDX-License-Identifier: BSD-2-Clause-Patent
-*
+ Main file supporting the transition to PEI Core in Normal World for Versatile Express
+
+ Copyright (c) 2011-2014, ARM Limited. All rights reserved.
+
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
**/
#include <Library/BaseLib.h>
diff --git a/ArmPlatformPkg/PrePeiCore/PrePeiCore.h b/ArmPlatformPkg/PrePeiCore/PrePeiCore.h
index 7140c7f5b592..7b155a8a61ea 100644
--- a/ArmPlatformPkg/PrePeiCore/PrePeiCore.h
+++ b/ArmPlatformPkg/PrePeiCore/PrePeiCore.h
@@ -1,10 +1,10 @@
/** @file
-* Main file supporting the transition to PEI Core in Normal World for Versatile Express
-*
-* Copyright (c) 2011, ARM Limited. All rights reserved.
-*
-* SPDX-License-Identifier: BSD-2-Clause-Patent
-*
+ Main file supporting the transition to PEI Core in Normal World for Versatile Express
+
+ Copyright (c) 2011, ARM Limited. All rights reserved.
+
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
**/
#ifndef __PREPEICORE_H_
#define __PREPEICORE_H_
diff --git a/ArmPlatformPkg/PrePi/AArch64/ArchPrePi.c b/ArmPlatformPkg/PrePi/AArch64/ArchPrePi.c
index 9a172212a36a..296b029e08bf 100644
--- a/ArmPlatformPkg/PrePi/AArch64/ArchPrePi.c
+++ b/ArmPlatformPkg/PrePi/AArch64/ArchPrePi.c
@@ -1,9 +1,9 @@
/** @file
-*
-* Copyright (c) 2011-2017, ARM Limited. All rights reserved.
-*
-* SPDX-License-Identifier: BSD-2-Clause-Patent
-*
+
+ Copyright (c) 2011-2017, ARM Limited. All rights reserved.
+
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
**/
#include "PrePi.h"
diff --git a/ArmPlatformPkg/PrePi/Arm/ArchPrePi.c b/ArmPlatformPkg/PrePi/Arm/ArchPrePi.c
index 250b622f457f..8d021931e28d 100644
--- a/ArmPlatformPkg/PrePi/Arm/ArchPrePi.c
+++ b/ArmPlatformPkg/PrePi/Arm/ArchPrePi.c
@@ -1,9 +1,9 @@
/** @file
-*
-* Copyright (c) 2011 - 2013, ARM Limited. All rights reserved.
-*
-* SPDX-License-Identifier: BSD-2-Clause-Patent
-*
+
+ Copyright (c) 2011 - 2013, ARM Limited. All rights reserved.
+
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
**/
#include "PrePi.h"
diff --git a/ArmPlatformPkg/PrePi/MainMPCore.c b/ArmPlatformPkg/PrePi/MainMPCore.c
index 31cf085b6da9..091464df2aa9 100644
--- a/ArmPlatformPkg/PrePi/MainMPCore.c
+++ b/ArmPlatformPkg/PrePi/MainMPCore.c
@@ -1,9 +1,9 @@
/** @file
-*
-* Copyright (c) 2011-2014, ARM Limited. All rights reserved.
-*
-* SPDX-License-Identifier: BSD-2-Clause-Patent
-*
+
+ Copyright (c) 2011-2014, ARM Limited. All rights reserved.
+
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
**/
#include "PrePi.h"
diff --git a/ArmPlatformPkg/PrePi/MainUniCore.c b/ArmPlatformPkg/PrePi/MainUniCore.c
index fb2f7efd9bae..aebbd8ccb94f 100644
--- a/ArmPlatformPkg/PrePi/MainUniCore.c
+++ b/ArmPlatformPkg/PrePi/MainUniCore.c
@@ -1,9 +1,9 @@
/** @file
-*
-* Copyright (c) 2011, ARM Limited. All rights reserved.
-*
-* SPDX-License-Identifier: BSD-2-Clause-Patent
-*
+
+ Copyright (c) 2011, ARM Limited. All rights reserved.
+
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
**/
#include "PrePi.h"
diff --git a/ArmPlatformPkg/PrePi/PrePi.c b/ArmPlatformPkg/PrePi/PrePi.c
index 5129dd09a85e..60fb1cf3894c 100644
--- a/ArmPlatformPkg/PrePi/PrePi.c
+++ b/ArmPlatformPkg/PrePi/PrePi.c
@@ -1,9 +1,9 @@
/** @file
-*
-* Copyright (c) 2011-2017, ARM Limited. All rights reserved.
-*
-* SPDX-License-Identifier: BSD-2-Clause-Patent
-*
+
+ Copyright (c) 2011-2017, ARM Limited. All rights reserved.
+
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
**/
#include <PiPei.h>
diff --git a/ArmPlatformPkg/PrePi/PrePi.h b/ArmPlatformPkg/PrePi/PrePi.h
index 2dce8c83024e..8e6a7833bcf0 100644
--- a/ArmPlatformPkg/PrePi/PrePi.h
+++ b/ArmPlatformPkg/PrePi/PrePi.h
@@ -1,9 +1,9 @@
/** @file
-*
-* Copyright (c) 2011 - 2020, Arm Limited. All rights reserved.<BR>
-*
-* SPDX-License-Identifier: BSD-2-Clause-Patent
-*
+
+ Copyright (c) 2011 - 2020, Arm Limited. All rights reserved.<BR>
+
+ SPDX-License-Identifier: BSD-2-Clause-Patent
+
**/
#ifndef _PREPI_H_
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v1 2/3] ArmPlatformPkg: Fix Ecc error 9001
2021-02-25 16:37 [PATCH v1 0/3] Prepare ArmPlatformPkg enablement PierreGondois
2021-02-25 16:37 ` [PATCH v1 1/3] ArmPlatformPkg: Fix Ecc error 8001 PierreGondois
@ 2021-02-25 16:37 ` PierreGondois
2021-03-01 15:25 ` [edk2-devel] " Sami Mujawar
2021-02-25 16:37 ` [PATCH v1 3/3] ArmPlatformPkg: Remove package dependency in NorFlashStandaloneMm PierreGondois
2 siblings, 1 reply; 7+ messages in thread
From: PierreGondois @ 2021-02-25 16:37 UTC (permalink / raw)
To: devel, ardb+tianocore, leif, sami.mujawar
From: Pierre Gondois <Pierre.Gondois@arm.com>
This patch fixes the following Ecc reported error:
INF/DEC/DSC/FDF file header comment should begin
with "## @file" or "# @file" at the very top file
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
The changes can be seen at: https://github.com/PierreARM/edk2/tree/1641_CI_fixes_for_ArmPlatformPkg_v1
.../Drivers/PL061GpioDxe/PL061GpioDxe.inf | 14 +++++++-------
.../SP805WatchdogDxe/SP805WatchdogDxe.inf | 16 ++++++++--------
2 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061GpioDxe.inf b/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061GpioDxe.inf
index 9c598bb66c76..3a71be4db4fd 100644
--- a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061GpioDxe.inf
+++ b/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061GpioDxe.inf
@@ -1,10 +1,10 @@
-/** @file
-*
-* Copyright (c) 2011 - 2020, Arm Limited. All rights reserved.<BR>
-*
-* SPDX-License-Identifier: BSD-2-Clause-Patent
-*
-**/
+## @file
+#
+# Copyright (c) 2011 - 2020, Arm Limited. All rights reserved.<BR>
+#
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+##
[Defines]
INF_VERSION = 0x00010005
diff --git a/ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805WatchdogDxe.inf b/ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805WatchdogDxe.inf
index fa87d92359ac..f8c370ff2888 100644
--- a/ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805WatchdogDxe.inf
+++ b/ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805WatchdogDxe.inf
@@ -1,11 +1,11 @@
-/** @file
-*
-* Copyright (c) 2011 - 2020, Arm Limited. All rights reserved.<BR>
-* Copyright (c) 2018, Linaro Limited. All rights reserved.
-*
-* SPDX-License-Identifier: BSD-2-Clause-Patent
-*
-**/
+## @file
+#
+# Copyright (c) 2011 - 2020, Arm Limited. All rights reserved.<BR>
+# Copyright (c) 2018, Linaro Limited. All rights reserved.
+#
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+##
[Defines]
INF_VERSION = 0x00010005
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v1 3/3] ArmPlatformPkg: Remove package dependency in NorFlashStandaloneMm
2021-02-25 16:37 [PATCH v1 0/3] Prepare ArmPlatformPkg enablement PierreGondois
2021-02-25 16:37 ` [PATCH v1 1/3] ArmPlatformPkg: Fix Ecc error 8001 PierreGondois
2021-02-25 16:37 ` [PATCH v1 2/3] ArmPlatformPkg: Fix Ecc error 9001 PierreGondois
@ 2021-02-25 16:37 ` PierreGondois
2021-03-15 12:32 ` [edk2-devel] " Vijayenthiran Subramaniam
2 siblings, 1 reply; 7+ messages in thread
From: PierreGondois @ 2021-02-25 16:37 UTC (permalink / raw)
To: devel, ardb+tianocore, leif, sami.mujawar
From: Pierre Gondois <Pierre.Gondois@arm.com>
The DependencyCheck available in .pytool detects an unnecessary
dependency of the NorFlashStandaloneMm.inf module over the
EmbeddedPkg package.
This patch removes this dependency.
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
The changes can be seen at: https://github.com/PierreARM/edk2/tree/1641_CI_fixes_for_ArmPlatformPkg_v1
ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashStandaloneMm.inf | 1 -
1 file changed, 1 deletion(-)
diff --git a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashStandaloneMm.inf b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashStandaloneMm.inf
index 56347a8bc7c1..b8dddd5cbec3 100644
--- a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashStandaloneMm.inf
+++ b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashStandaloneMm.inf
@@ -29,7 +29,6 @@ [Packages]
MdeModulePkg/MdeModulePkg.dec
ArmPlatformPkg/ArmPlatformPkg.dec
EmbeddedPkg/EmbeddedPkg.dec
- StandaloneMmPkg/StandaloneMmPkg.dec
[LibraryClasses]
BaseLib
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/3] ArmPlatformPkg: Fix Ecc error 8001
2021-02-25 16:37 ` [PATCH v1 1/3] ArmPlatformPkg: Fix Ecc error 8001 PierreGondois
@ 2021-03-01 15:21 ` Sami Mujawar
0 siblings, 0 replies; 7+ messages in thread
From: Sami Mujawar @ 2021-03-01 15:21 UTC (permalink / raw)
To: PierreGondois, devel
[-- Attachment #1: Type: text/plain, Size: 78 bytes --]
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
[-- Attachment #2: Type: text/html, Size: 101 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH v1 2/3] ArmPlatformPkg: Fix Ecc error 9001
2021-02-25 16:37 ` [PATCH v1 2/3] ArmPlatformPkg: Fix Ecc error 9001 PierreGondois
@ 2021-03-01 15:25 ` Sami Mujawar
0 siblings, 0 replies; 7+ messages in thread
From: Sami Mujawar @ 2021-03-01 15:25 UTC (permalink / raw)
To: PierreGondois, devel
[-- Attachment #1: Type: text/plain, Size: 78 bytes --]
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
[-- Attachment #2: Type: text/html, Size: 101 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH v1 3/3] ArmPlatformPkg: Remove package dependency in NorFlashStandaloneMm
2021-02-25 16:37 ` [PATCH v1 3/3] ArmPlatformPkg: Remove package dependency in NorFlashStandaloneMm PierreGondois
@ 2021-03-15 12:32 ` Vijayenthiran Subramaniam
0 siblings, 0 replies; 7+ messages in thread
From: Vijayenthiran Subramaniam @ 2021-03-15 12:32 UTC (permalink / raw)
To: devel, pierre.gondois
Cc: ardb+tianocore, leif, Sami Mujawar, Thomas Abraham,
sayanta.pattanayak, Vijayenthiran Subramaniam
Hi,
On Thu, Feb 25, 2021 at 4:38 PM PierreGondois <pierre.gondois@arm.com> wrote:
>
> From: Pierre Gondois <Pierre.Gondois@arm.com>
>
> The DependencyCheck available in .pytool detects an unnecessary
> dependency of the NorFlashStandaloneMm.inf module over the
> EmbeddedPkg package.
> This patch removes this dependency.
>
> Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
Tested this patch on Arm's reference design platform.
Tested-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
> ---
> The changes can be seen at: https://github.com/PierreARM/edk2/tree/1641_CI_fixes_for_ArmPlatformPkg_v1
>
> ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashStandaloneMm.inf | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashStandaloneMm.inf b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashStandaloneMm.inf
> index 56347a8bc7c1..b8dddd5cbec3 100644
> --- a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashStandaloneMm.inf
> +++ b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashStandaloneMm.inf
> @@ -29,7 +29,6 @@ [Packages]
> MdeModulePkg/MdeModulePkg.dec
> ArmPlatformPkg/ArmPlatformPkg.dec
> EmbeddedPkg/EmbeddedPkg.dec
> - StandaloneMmPkg/StandaloneMmPkg.dec
>
> [LibraryClasses]
> BaseLib
> --
> 2.17.1
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-03-15 12:33 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-25 16:37 [PATCH v1 0/3] Prepare ArmPlatformPkg enablement PierreGondois
2021-02-25 16:37 ` [PATCH v1 1/3] ArmPlatformPkg: Fix Ecc error 8001 PierreGondois
2021-03-01 15:21 ` [edk2-devel] " Sami Mujawar
2021-02-25 16:37 ` [PATCH v1 2/3] ArmPlatformPkg: Fix Ecc error 9001 PierreGondois
2021-03-01 15:25 ` [edk2-devel] " Sami Mujawar
2021-02-25 16:37 ` [PATCH v1 3/3] ArmPlatformPkg: Remove package dependency in NorFlashStandaloneMm PierreGondois
2021-03-15 12:32 ` [edk2-devel] " Vijayenthiran Subramaniam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox