public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: "Gao, Liming" <liming.gao@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Ni, Ray" <ray.ni@intel.com>,
	"Chiu, Chasel" <chasel.chiu@intel.com>,
	"Dong, Eric" <eric.dong@intel.com>
Subject: Re: [Patch] MinPlatformPkg PciSegmentInfoLibSimple: Update GetPciSegmentInfo() API
Date: Thu, 25 Jun 2020 15:23:14 +0000	[thread overview]
Message-ID: <323E481A-7F31-4749-A21A-F68E4C79D4A3@intel.com> (raw)
In-Reply-To: <20200624142131.2035-1-liming.gao@intel.com>

Hey Liming,

Any chance we could push this? All MinPlatform builds are currently broken.

Thanks,
Nate

On 6/24/20, 7:21 AM, "Gao, Liming" <liming.gao@intel.com> wrote:

    Update GetPciSegmentInfo() API to match its library class definition

    Signed-off-by: Liming Gao <liming.gao@intel.com>
    Cc: Ray Ni <ray.ni@intel.com>
    Cc: Chasel Chiu <chasel.chiu@intel.com>
    Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
    Cc: Eric Dong <eric.dong@intel.com>
    ---
     .../Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c        | 1 +
     1 file changed, 1 insertion(+)

    diff --git a/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c b/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c
    index 6a6218d906..398f4d4b78 100644
    --- a/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c
    +++ b/Platform/Intel/MinPlatformPkg/Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c
    @@ -31,6 +31,7 @@ volatile PCI_SEGMENT_INFO  mPciSegmentInfo;
       @retval A callee owned array holding the segment information.
     **/
     PCI_SEGMENT_INFO *
    +EFIAPI
     GetPciSegmentInfo (
       OUT UINTN  *Count
       )
    -- 
    2.13.0.windows.1



  parent reply	other threads:[~2020-06-25 15:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-24 14:21 [Patch] MinPlatformPkg PciSegmentInfoLibSimple: Update GetPciSegmentInfo() API Liming Gao
2020-06-24 14:33 ` Chiu, Chasel
2020-06-24 16:17 ` Nate DeSimone
2020-06-25  0:28 ` Ni, Ray
2020-06-25 15:23 ` Nate DeSimone [this message]
2020-06-26  3:27   ` Liming Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=323E481A-7F31-4749-A21A-F68E4C79D4A3@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox