From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Tue, 30 Jul 2019 06:05:05 -0700
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 9BB575AFE9;
	Tue, 30 Jul 2019 13:05:04 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (unknown [10.36.118.39])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 456205D9E2;
	Tue, 30 Jul 2019 13:05:03 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH v4 34/35] OvmfPkg: Move XenRealTimeClockLib from ArmVirtPkg
To: devel@edk2.groups.io, anthony.perard@citrix.com
Cc: Julien Grall <julien.grall@arm.com>, xen-devel@lists.xenproject.org,
 Jordan Justen <jordan.l.justen@intel.com>,
 Ard Biesheuvel <ard.biesheuvel@linaro.org>
References: <20190729153944.24239-1-anthony.perard@citrix.com>
 <20190729153944.24239-35-anthony.perard@citrix.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <323cf9e5-32e8-3ad4-eb42-d0ace75d9fad@redhat.com>
Date: Tue, 30 Jul 2019 15:05:02 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190729153944.24239-35-anthony.perard@citrix.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 30 Jul 2019 13:05:04 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 07/29/19 17:39, Anthony PERARD wrote:
> Move XenRealTimeClockLib from ArmVirtPkg to OvmfPkg so it can be used
> from the OvmfPkg by the following patch, "OvmfPkg/OvmfXen: use
> RealTimeClockRuntimeDxe from EmbeddedPkg"
> 
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> ---
> 
> Notes:
>     v4:
>     - Update Maintainers.txt
>     
>     v3:
>     - fix the commit message body
> 
>  ArmVirtPkg/ArmVirtXen.dsc                                       | 2 +-
>  .../Library/XenRealTimeClockLib/XenRealTimeClockLib.inf         | 0
>  .../Library/XenRealTimeClockLib/XenRealTimeClockLib.c           | 0
>  Maintainers.txt                                                 | 2 +-
>  4 files changed, 2 insertions(+), 2 deletions(-)
>  rename {ArmVirtPkg => OvmfPkg}/Library/XenRealTimeClockLib/XenRealTimeClockLib.inf (100%)
>  rename {ArmVirtPkg => OvmfPkg}/Library/XenRealTimeClockLib/XenRealTimeClockLib.c (100%)

[...]

> diff --git a/Maintainers.txt b/Maintainers.txt
> index 79defd13bf..919baccc56 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -114,7 +114,6 @@ R: Leif Lindholm <leif.lindholm@linaro.org>
>  ArmVirtPkg: modules used on Xen
>  F: ArmVirtPkg/ArmVirtXen.*
>  F: ArmVirtPkg/Library/XenArmGenericTimerVirtCounterLib/
> -F: ArmVirtPkg/Library/XenRealTimeClockLib/
>  F: ArmVirtPkg/Library/XenVirtMemInfoLib/
>  F: ArmVirtPkg/PrePi/
>  F: ArmVirtPkg/XenAcpiPlatformDxe/
> @@ -374,6 +373,7 @@ F: OvmfPkg/Library/XenConsoleSerialPortLib/
>  F: OvmfPkg/Library/XenHypercallLib/
>  F: OvmfPkg/Library/XenIoMmioLib/
>  F: OvmfPkg/Library/XenPlatformLib/
> +F: OvmfPkg/Library/XenRealTimeClockLib/
>  F: OvmfPkg/OvmfXen.*
>  F: OvmfPkg/OvmfXenElfHeaderGenerator.c
>  F: OvmfPkg/PlatformPei/MemDetect.c
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>