Hi Pierre,<br /><br />On Thu, Jan 21, 2021 at 01:51 AM, PierreGondois wrote:<br />
<blockquote>-#ifndef __ARM_CORTEX_A5x_H__<br />-#define __ARM_CORTEX_A5x_H__<br />+#ifndef ARM_CORTEX_A5X_H__<br />+#define ARM_CORTEX_A5X_H__</blockquote>
There should be a single trailing underscore for #include guards. See <a href="https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/5_source_files/53_include_files#5-3-5-all-include-file-contents-must-be-protected-by-a-include-guard" target="_blank" rel="noopener">https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/5_source_files/53_include_files#5-3-5-all-include-file-contents-must-be-protected-by-a-include-guard</a><br /><br />With that changed:<br /><br />Reviewed-by: Sami Mujawar &lt;sami.mujawar@arm.com&gt;<br /><br />Regards,<br /><br />Sami Mujawar