From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [edk2-devel] [PATCH v1 01/27] ArmPkg: Fix Ecc error 8001 in Chipset To: PierreGondois ,devel@edk2.groups.io From: "Sami Mujawar" X-Originating-Location: Cambridge, England, GB (217.140.99.251) X-Originating-Platform: Windows Firefox 85 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Fri, 05 Feb 2021 06:38:00 -0800 References: <20210121095119.22143-2-Pierre.Gondois@arm.com> In-Reply-To: <20210121095119.22143-2-Pierre.Gondois@arm.com> Message-ID: <32563.1612535880993264447@groups.io> Content-Type: multipart/alternative; boundary="kkGlB4X3cUdSZu9W7J9p" --kkGlB4X3cUdSZu9W7J9p Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Pierre, On Thu, Jan 21, 2021 at 01:51 AM, PierreGondois wrote: >=20 > -#ifndef __ARM_CORTEX_A5x_H__ > -#define __ARM_CORTEX_A5x_H__ > +#ifndef ARM_CORTEX_A5X_H__ > +#define ARM_CORTEX_A5X_H__ There should be a single trailing underscore for #include guards. See http= s://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/5_source_f= iles/53_include_files#5-3-5-all-include-file-contents-must-be-protected-by-= a-include-guard With that changed: Reviewed-by: Sami Mujawar Regards, Sami Mujawar --kkGlB4X3cUdSZu9W7J9p Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Pierre,

On Thu, Jan 21, 2021 at 01:51 AM, PierreGondois wrote= :
-#ifndef __ARM_CORTEX_A5x_H__
-#define __ARM_CORTEX_A5x_H= __
+#ifndef ARM_CORTEX_A5X_H__
+#define ARM_CORTEX_A5X_H__ There should be a single trailing underscore for #include guards. See https://edk2= -docs.gitbook.io/edk-ii-c-coding-standards-specification/5_source_files/53_= include_files#5-3-5-all-include-file-contents-must-be-protected-by-a-includ= e-guard

With that changed:

Reviewed-by: Sami Muja= war <sami.mujawar@arm.com>

Regards,

Sami Mujawa= r --kkGlB4X3cUdSZu9W7J9p--