public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Thomas Palmer <thomas.palmer@hpe.com>, edk2-devel@lists.01.org
Cc: jordan.l.justen@intel.com, brijesh.singh@amd.com,
	joseph.shifflett@hpe.com
Subject: Re: [PATCH 1/1] OvmfPkg/IoMmuDxe: Fix header guard macro
Date: Fri, 4 Aug 2017 22:00:18 +0200	[thread overview]
Message-ID: <3268d2de-2e98-cfa0-5956-9e7f7984d3af@redhat.com> (raw)
In-Reply-To: <1501874321-38880-1-git-send-email-thomas.palmer@hpe.com>

On 08/04/17 21:18, Thomas Palmer wrote:
> Correct the header guard macro
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Thomas Palmer <thomas.palmer@hpe.com>
> ---
>  OvmfPkg/IoMmuDxe/AmdSevIoMmu.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/OvmfPkg/IoMmuDxe/AmdSevIoMmu.h b/OvmfPkg/IoMmuDxe/AmdSevIoMmu.h
> index 8b3962a8c395..47428c235090 100644
> --- a/OvmfPkg/IoMmuDxe/AmdSevIoMmu.h
> +++ b/OvmfPkg/IoMmuDxe/AmdSevIoMmu.h
> @@ -7,6 +7,7 @@
>  
>    Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
>    Copyright (c) 2017, AMD Inc. All rights reserved.<BR>
> +  (C) Copyright 2017 Hewlett Packard Enterprise Development LP<BR>
>    This program and the accompanying materials are licensed and made available
>    under the terms and conditions of the BSD License which accompanies this
>    distribution.  The full text of the license may be found at
> @@ -18,7 +19,7 @@
>  **/
>  
>  #ifndef __AMD_SEV_IOMMU_H_
> -#define __AMD_SEV_IOMMU_H
> +#define __AMD_SEV_IOMMU_H_
>  
>  #include <Protocol/IoMmu.h>
>  
> 

Thank you, Thomas. Could you please submit a version that changes all
instances of the macro to:

  __AMD_SEV_IOMMU_H__

or

  _AMD_SEV_IOMMU_H_

?

Both are conventional in edk2. The number of underscores on the two
sides should match.

Thank you,
Laszlo



  reply	other threads:[~2017-08-04 19:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-04 19:18 [PATCH 1/1] OvmfPkg/IoMmuDxe: Fix header guard macro Thomas Palmer
2017-08-04 20:00 ` Laszlo Ersek [this message]
2017-08-04 20:02   ` Palmer, Thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3268d2de-2e98-cfa0-5956-9e7f7984d3af@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox