[PATCH 1/1] OvmfPkg/IoMmuDxe: Fix header guard macro

[PATCH 1/1] OvmfPkg/IoMmuDxe: Fix header guard macro

[Thomas Palmer]

Correct the header guard macro

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Thomas Palmer <thomas.palmer@hpe.com>
---
 OvmfPkg/IoMmuDxe/AmdSevIoMmu.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/OvmfPkg/IoMmuDxe/AmdSevIoMmu.h b/OvmfPkg/IoMmuDxe/AmdSevIoMmu.h
index 8b3962a8c395..47428c235090 100644
--- a/OvmfPkg/IoMmuDxe/AmdSevIoMmu.h
+++ b/OvmfPkg/IoMmuDxe/AmdSevIoMmu.h
@@ -7,6 +7,7 @@
 
   Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
   Copyright (c) 2017, AMD Inc. All rights reserved.<BR>
+  (C) Copyright 2017 Hewlett Packard Enterprise Development LP<BR>
   This program and the accompanying materials are licensed and made available
   under the terms and conditions of the BSD License which accompanies this
   distribution.  The full text of the license may be found at
@@ -18,7 +19,7 @@
 **/
 
 #ifndef __AMD_SEV_IOMMU_H_
-#define __AMD_SEV_IOMMU_H
+#define __AMD_SEV_IOMMU_H_
 
 #include <Protocol/IoMmu.h>
 
-- 
2.7.4

Re: [PATCH 1/1] OvmfPkg/IoMmuDxe: Fix header guard macro

[Laszlo Ersek]

On 08/04/17 21:18, Thomas Palmer wrote:
> Correct the header guard macro
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Thomas Palmer <thomas.palmer@hpe.com>
> ---
>  OvmfPkg/IoMmuDxe/AmdSevIoMmu.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/OvmfPkg/IoMmuDxe/AmdSevIoMmu.h b/OvmfPkg/IoMmuDxe/AmdSevIoMmu.h
> index 8b3962a8c395..47428c235090 100644
> --- a/OvmfPkg/IoMmuDxe/AmdSevIoMmu.h
> +++ b/OvmfPkg/IoMmuDxe/AmdSevIoMmu.h
> @@ -7,6 +7,7 @@
>  
>    Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
>    Copyright (c) 2017, AMD Inc. All rights reserved.<BR>
> +  (C) Copyright 2017 Hewlett Packard Enterprise Development LP<BR>
>    This program and the accompanying materials are licensed and made available
>    under the terms and conditions of the BSD License which accompanies this
>    distribution.  The full text of the license may be found at
> @@ -18,7 +19,7 @@
>  **/
>  
>  #ifndef __AMD_SEV_IOMMU_H_
> -#define __AMD_SEV_IOMMU_H
> +#define __AMD_SEV_IOMMU_H_
>  
>  #include <Protocol/IoMmu.h>
>  
> 

Thank you, Thomas. Could you please submit a version that changes all
instances of the macro to:

  __AMD_SEV_IOMMU_H__

or

  _AMD_SEV_IOMMU_H_

?

Both are conventional in edk2. The number of underscores on the two
sides should match.

Thank you,
Laszlo

Re: [PATCH 1/1] OvmfPkg/IoMmuDxe: Fix header guard macro

[Palmer, Thomas]

roger


Regards,

Thomas Palmer

“I have only made this letter longer because I have not had the time to make it shorter” - Blaise Pascal

-----Original Message-----
From: Laszlo Ersek [mailto:lersek@redhat.com] 
Sent: Friday, August 4, 2017 3:00 PM
To: Palmer, Thomas <thomas.palmer@hpe.com>; edk2-devel@lists.01.org
Cc: jordan.l.justen@intel.com; brijesh.singh@amd.com; Shifflett, Joseph <joseph.shifflett@hpe.com>
Subject: Re: [PATCH 1/1] OvmfPkg/IoMmuDxe: Fix header guard macro

On 08/04/17 21:18, Thomas Palmer wrote:
> Correct the header guard macro
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Thomas Palmer <thomas.palmer@hpe.com>
> ---
>  OvmfPkg/IoMmuDxe/AmdSevIoMmu.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/OvmfPkg/IoMmuDxe/AmdSevIoMmu.h 
> b/OvmfPkg/IoMmuDxe/AmdSevIoMmu.h index 8b3962a8c395..47428c235090 
> 100644
> --- a/OvmfPkg/IoMmuDxe/AmdSevIoMmu.h
> +++ b/OvmfPkg/IoMmuDxe/AmdSevIoMmu.h
> @@ -7,6 +7,7 @@
>  
>    Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
>    Copyright (c) 2017, AMD Inc. All rights reserved.<BR>
> +  (C) Copyright 2017 Hewlett Packard Enterprise Development LP<BR>
>    This program and the accompanying materials are licensed and made available
>    under the terms and conditions of the BSD License which accompanies this
>    distribution.  The full text of the license may be found at @@ 
> -18,7 +19,7 @@  **/
>  
>  #ifndef __AMD_SEV_IOMMU_H_
> -#define __AMD_SEV_IOMMU_H
> +#define __AMD_SEV_IOMMU_H_
>  
>  #include <Protocol/IoMmu.h>
>  
> 

Thank you, Thomas. Could you please submit a version that changes all instances of the macro to:

  __AMD_SEV_IOMMU_H__

or

  _AMD_SEV_IOMMU_H_

?

Both are conventional in edk2. The number of underscores on the two sides should match.

Thank you,
Laszlo