From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3C21021E1DAF4 for ; Fri, 4 Aug 2017 12:58:10 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6C4AF4A6FD; Fri, 4 Aug 2017 20:00:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6C4AF4A6FD Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-151.phx2.redhat.com [10.3.116.151]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8230161F21; Fri, 4 Aug 2017 20:00:20 +0000 (UTC) To: Thomas Palmer , edk2-devel@lists.01.org Cc: jordan.l.justen@intel.com, brijesh.singh@amd.com, joseph.shifflett@hpe.com References: <1501874321-38880-1-git-send-email-thomas.palmer@hpe.com> From: Laszlo Ersek Message-ID: <3268d2de-2e98-cfa0-5956-9e7f7984d3af@redhat.com> Date: Fri, 4 Aug 2017 22:00:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1501874321-38880-1-git-send-email-thomas.palmer@hpe.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 04 Aug 2017 20:00:22 +0000 (UTC) Subject: Re: [PATCH 1/1] OvmfPkg/IoMmuDxe: Fix header guard macro X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2017 19:58:10 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/04/17 21:18, Thomas Palmer wrote: > Correct the header guard macro > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Thomas Palmer > --- > OvmfPkg/IoMmuDxe/AmdSevIoMmu.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/OvmfPkg/IoMmuDxe/AmdSevIoMmu.h b/OvmfPkg/IoMmuDxe/AmdSevIoMmu.h > index 8b3962a8c395..47428c235090 100644 > --- a/OvmfPkg/IoMmuDxe/AmdSevIoMmu.h > +++ b/OvmfPkg/IoMmuDxe/AmdSevIoMmu.h > @@ -7,6 +7,7 @@ > > Copyright (c) 2017, Intel Corporation. All rights reserved.
> Copyright (c) 2017, AMD Inc. All rights reserved.
> + (C) Copyright 2017 Hewlett Packard Enterprise Development LP
> This program and the accompanying materials are licensed and made available > under the terms and conditions of the BSD License which accompanies this > distribution. The full text of the license may be found at > @@ -18,7 +19,7 @@ > **/ > > #ifndef __AMD_SEV_IOMMU_H_ > -#define __AMD_SEV_IOMMU_H > +#define __AMD_SEV_IOMMU_H_ > > #include > > Thank you, Thomas. Could you please submit a version that changes all instances of the macro to: __AMD_SEV_IOMMU_H__ or _AMD_SEV_IOMMU_H_ ? Both are conventional in edk2. The number of underscores on the two sides should match. Thank you, Laszlo