From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id F21DE740039 for ; Fri, 19 Jan 2024 11:24:15 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=MbBRXE10u91LV2ompzUEniqjO8gRj6Ku6CtHZ6dz1Gc=; c=relaxed/simple; d=groups.io; h=Subject:To:From:User-Agent:MIME-Version:Date:References:In-Reply-To:Message-ID:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1705663454; v=1; b=DFSawlut6ahy4cj4FZsL+8tzuH7Lr0O2zx9dwQtv7a/JDWdi7nBgdfSJbja+S1RuI0N+XHFb iI/iTqrDgBhroKAmwcnoX7B5iYJmAk/GSXX6Oo/kiCgRQeeO4/dL7/8LgRtUqJbKXJ/KWKAGBXV bo4Ee/yfDBAG46wjY6/9B2yM= X-Received: by 127.0.0.2 with SMTP id IzoaYY7687511xAmBV3pe2eu; Fri, 19 Jan 2024 03:24:14 -0800 Subject: Re: [edk2-devel] [edk2-platforms][PATCH V4 0/4] Add support to parse NT_FW_CONFIG To: sahil ,devel@edk2.groups.io From: "Sami Mujawar" X-Originating-Location: Cambridge, England, GB (217.140.106.49) X-Originating-Platform: Mac Safari 17.1 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Fri, 19 Jan 2024 03:24:13 -0800 References: <20240104131616.474492-1-sahil@arm.com> In-Reply-To: <20240104131616.474492-1-sahil@arm.com> Message-ID: <32760.1705663453560462049@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 97ZnY1UjbTlx5UXgJeuczVKQx7686176AA= Content-Type: multipart/alternative; boundary="FGZGFyjTWF4IfbdCXx8N" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=DFSawlut; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --FGZGFyjTWF4IfbdCXx8N Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Sahil, On Thu, Jan 4, 2024 at 05:16 AM, sahil wrote: >=20 > v4: > - Fixed code review comments > - Split the patch into four patches Can you add git notes for the patches in the future, please? See https://gi= thub.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-fo= r-edk2-contributors-and-maintainers#contrib-30 Also, it would be of great help if you can add a link to the edk2 mailing l= ist discussion that has taken place. I normally do that as it helps the mai= ntainer locate the previous discussion easily. For now, can you reply to the individual patches with the links to the prev= ious discussion, please? Regards, Sami Mujawar -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114042): https://edk2.groups.io/g/devel/message/114042 Mute This Topic: https://groups.io/mt/103521642/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --FGZGFyjTWF4IfbdCXx8N Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Sahil,
On Thu, Jan 4, 2024 at 05:16 AM, sahil wrote:
v4:
- Fixed code review comments
- Split the patch in= to four patches
Can you add git notes for the patches in the future, please? See https://git= hub.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for= -edk2-contributors-and-maintainers#contrib-30
Also, it would be of= great help if you can add a link to the edk2 mailing list discussion that = has taken place. I normally do that as it helps the maintainer locate the p= revious discussion easily.

For now, can you reply to the individ= ual patches with the links to the previous discussion, please?

R= egards,

Sami Mujawar
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#114042) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--FGZGFyjTWF4IfbdCXx8N--