From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.194.1624557245802496035 for ; Thu, 24 Jun 2021 10:54:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QrtHg5Zg; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624557245; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kp47n0jr7ZmoJS/UIE+Vegj7irsH+j24KfNmiF0mhMw=; b=QrtHg5Zge+NGuZJ/2k2DlzpmS5FYHKZ4Whcmllq2Riy1/r3Qa94FQWugHc4hsUY0xSDz3R LcCD0QsHfVbznl9KmvMKX16MUe0QHZoc6MyzBAoM3gWsjVhUe30QIUULj6iB66R17FPVE6 V1B2auGV+Si9rAsl6Joa3vXJX6ypQ1s= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-568-0aWxNhgpOAqqebr7ZVI9kQ-1; Thu, 24 Jun 2021 13:54:01 -0400 X-MC-Unique: 0aWxNhgpOAqqebr7ZVI9kQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 22746100CF72; Thu, 24 Jun 2021 17:54:00 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-106.ams2.redhat.com [10.36.114.106]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AEDB110023B5; Thu, 24 Jun 2021 17:53:58 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2 3/3] OvmfPkg/X86QemuLoadImageLib: State fw_cfg dependency in file header To: devel@edk2.groups.io, dovmurik@linux.ibm.com Cc: Ard Biesheuvel , Jordan Justen , James Bottomley , Tobin Feldman-Fitzthum References: <20210617121700.2883073-1-dovmurik@linux.ibm.com> <20210617121700.2883073-4-dovmurik@linux.ibm.com> From: "Laszlo Ersek" Message-ID: <327b534a-380c-44ce-ce4a-620a8d4463a2@redhat.com> Date: Thu, 24 Jun 2021 19:53:57 +0200 MIME-Version: 1.0 In-Reply-To: <20210617121700.2883073-4-dovmurik@linux.ibm.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 06/17/21 14:17, Dov Murik wrote: > Make it clear that X86QemuLoadImageLib relies on fw_cfg; prepare the > ground to add a warning about the incompatibility with boot verification > process. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: James Bottomley > Cc: Tobin Feldman-Fitzthum > Signed-off-by: Dov Murik > --- > OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.inf | 3 +++ > OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c | 3 +++ > 2 files changed, 6 insertions(+) (1) The bugzilla ticket should be referenced in the commit message, above your signoff: Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3457 With that update: Reviewed-by: Laszlo Ersek Thanks, Laszlo > > diff --git a/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.inf b/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.inf > index e1615badd2ba..c7ec041cb706 100644 > --- a/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.inf > +++ b/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.inf > @@ -2,6 +2,9 @@ > # X86 specific implementation of QemuLoadImageLib library class interface > # with support for loading mixed mode images and non-EFI stub images > # > +# Note that this implementation reads the cmdline (and possibly kernel, setup > +# data, and initrd in the legacy boot mode) from fw_cfg directly. > +# > # Copyright (c) 2020, ARM Ltd. All rights reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent > diff --git a/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c b/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c > index 1177582ab051..dc9018f4333b 100644 > --- a/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c > +++ b/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c > @@ -2,6 +2,9 @@ > X86 specific implementation of QemuLoadImageLib library class interface > with support for loading mixed mode images and non-EFI stub images > > + Note that this implementation reads the cmdline (and possibly kernel, setup > + data, and initrd in the legacy boot mode) from fw_cfg directly. > + > Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.
> Copyright (c) 2020, ARM Ltd. All rights reserved.
> >