Re: [PATCH v2] OvmfPkg: Fix VS toolchain build failure

[Laszlo Ersek <lersek@redhat.com>]

On 09/22/16 03:38, Laszlo Ersek wrote:
> On 09/22/16 03:37, Laszlo Ersek wrote:
>> On 09/22/16 03:21, Dandan Bi wrote:
>>> V2: add the assert codes.
>>>
>>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>>> Cc: Laszlo Ersek <lersek@redhat.com>
>>> Cc: Liming Gao <liming.gao@intel.com>
>>> Contributed-under: TianoCore Contribution Agreement 1.0
>>> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
>>> ---
>>>  OvmfPkg/VirtioGpuDxe/Commands.c | 3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/OvmfPkg/VirtioGpuDxe/Commands.c b/OvmfPkg/VirtioGpuDxe/Commands.c
>>> index b369dc3..962087c 100644
>>> --- a/OvmfPkg/VirtioGpuDxe/Commands.c
>>> +++ b/OvmfPkg/VirtioGpuDxe/Commands.c
>>> @@ -282,16 +282,17 @@ VirtioGpuSendCommand (
>>>    }
>>>    Header->CtxId     = 0;
>>>    Header->Padding   = 0;
>>>  
>>>    ASSERT (RequestSize >= sizeof *Header);
>>> +  ASSERT (RequestSize <= MAX_UINT32);
>>>  
>>>    //
>>>    // Compose the descriptor chain.
>>>    //
>>>    VirtioPrepare (&VgpuDev->Ring, &Indices);
>>> -  VirtioAppendDesc (&VgpuDev->Ring, (UINTN)Header, RequestSize,
>>> +  VirtioAppendDesc (&VgpuDev->Ring, (UINTN)Header, (UINT32)RequestSize,
>>>      VRING_DESC_F_NEXT, &Indices);
>>>    VirtioAppendDesc (&VgpuDev->Ring, (UINTN)&Response, sizeof Response,
>>>      VRING_DESC_F_WRITE, &Indices);
>>>  
>>>    //
>>>
>>
>> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>>
> 
> Before you commit the patch, can you please change the subject line like
> this:
> 
> OvmfPkg/VirtioGpuDxe: Fix VS toolchain build failure

I just realized you may not have commit rights. I committed this patch
for you: 7f1bf51bdbca.

Thanks!
Laszlo